Merge rust-bitcoin#5000: Kill new mutants

81e149e Add mutant excludes for serde expecting messages (Jamil Lambert, PhD)
8d3d504 Add mutant excludes for deprecated to_hex methods (Jamil Lambert, PhD)
e6ea5f4 Add missing SignedAmount tests (Jamil Lambert, PhD)
f808546 Move Amount test (Jamil Lambert, PhD)

Pull request description:

  Weekly mutation testing found new mutants. There are also two in primitives found locally from changes since the last weekly run.
  
  - Move a test for `Amount` to be with the others instead of under the `SignedAmount` test.
  - Add two tests for `SignedAmount` that were previously only done for `Amount`.
  - Exclude two deprecated `to_hex` functions that created mutants.
  - Add an exclude that covers two `serde` `expecting` messages that created mutants.
  
  Closes rust-bitcoin#4987


ACKs for top commit:
  tcharding:
    ACK 81e149e
  apoelstra:
    ACK 81e149e; successfully ran local tests


Tree-SHA512: e85e0f68562a1e3e850ac00e44d9d9467ef45c3aa82beb5163141d852f2bd76d783cdb6655e8ed3afdbb778b2614c3ee9e467a698909f712524879708746466b

Author: apoelstra

.cargo/mutants.toml

@@ -9,6 +9,7 @@ exclude_re = [
     "impl fmt::Debug",
     ".*Error",
     "deserialize", # Skip serde mutation tests
+    "serde_details::<impl de::Visitor<'_>", # Skip serde mutation tests
     "Iterator", # Mutating operations in an iterator can result in an infinite loop
 
     # ----------------------------------Crate-specific exclusions----------------------------------
@@ -39,5 +40,7 @@ exclude_re = [
     "fmt_debug_pretty", # Mutants from formatting/display changes
     "CompactTarget::to_hex", # Deprecated
     "Script::to_hex", # Deprecated
+    "Script<T>::to_hex", # Deprecated
     "ScriptBuf::to_hex", # Deprecated
+    "ScriptBuf<T>::to_hex", # Deprecated
 ]

units/src/amount/result.rs

@@ -326,6 +326,18 @@ mod tests {
         assert_eq!(sum, NumOpResult::Valid(Amount::from_sat_u32(600)));
     }
 
+    #[test]
+    fn test_sum_amount_with_error_propagation() {
+        let amounts = [
+            NumOpResult::Valid(Amount::from_sat_u32(100)),
+            NumOpResult::Error(NumOpError::while_doing(MathOp::Add)),
+            NumOpResult::Valid(Amount::from_sat_u32(200)),
+        ];
+
+        let sum: NumOpResult<Amount> = amounts.into_iter().sum();
+        assert!(matches!(sum, NumOpResult::Error(_)));
+    }
+
     #[test]
     fn test_sum_signed_amount_results() {
         let amounts = [
@@ -339,14 +351,26 @@ mod tests {
     }
 
     #[test]
-    fn test_sum_with_error_propagation() {
+    fn test_sum_signed_amount_results_with_references() {
         let amounts = [
-            NumOpResult::Valid(Amount::from_sat_u32(100)),
+            NumOpResult::Valid(SignedAmount::from_sat_i32(100)),
+            NumOpResult::Valid(SignedAmount::from_sat_i32(-50)),
+            NumOpResult::Valid(SignedAmount::from_sat_i32(200)),
+        ];
+
+        let sum: NumOpResult<SignedAmount> = amounts.iter().sum();
+        assert_eq!(sum, NumOpResult::Valid(SignedAmount::from_sat_i32(250)));
+    }
+
+    #[test]
+    fn test_sum_signed_amount_with_error_propagation() {
+        let amounts = [
+            NumOpResult::Valid(SignedAmount::from_sat_i32(100)),
             NumOpResult::Error(NumOpError::while_doing(MathOp::Add)),
-            NumOpResult::Valid(Amount::from_sat_u32(200)),
+            NumOpResult::Valid(SignedAmount::from_sat_i32(200)),
         ];
 
-        let sum: NumOpResult<Amount> = amounts.into_iter().sum();
+        let sum: NumOpResult<SignedAmount> = amounts.into_iter().sum();
         assert!(matches!(sum, NumOpResult::Error(_)));
     }
 }