Merge rust-bitcoin#5106: Update rust-bitcoin-maintainer-tools version and add extra_lints.sh

92e9ff9 Add extra_lints.sh to all crates (Jamil Lambert, PhD)
11d79ed Update to latest maintainer tools version (Jamil Lambert, PhD)
5466cb2 Fix unused import clippy lint (Jamil Lambert, PhD)

Pull request description:

  The new version of `rust-bitcoin-maintainer-tools` supports running extra lints from a crate specific `extra_lints.sh`.
  
  - Fix an unused import lint error with no-default-features.
  - Update the CI commit hash to the latest version of `rust-bitcoin-maintainer-tools`.
  - Add an `extra_lints.sh` script with a run of clippy with `no-default-features` to every crate in the workspace.


ACKs for top commit:
  apoelstra:
    ACK 92e9ff9; successfully ran local tests


Tree-SHA512: 44d14d318e8af3d82891cdbfe554c33581b5bc2abd21c82b75013421cb3d8978c9cb50b3b3ff88aead0e7d0d96aeb9d3b72676b806b1aa768a2d648f259e5751

Author: apoelstra

.github/workflows/rust.yml

@@ -34,7 +34,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          ref: c3324024ced9bb1eb854397686919c3ff7d97e1e
+          ref: 22eff1e5c114949d4b88a24735da38b37e7984fb
           path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@stable
@@ -58,7 +58,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          ref: c3324024ced9bb1eb854397686919c3ff7d97e1e
+          ref: 22eff1e5c114949d4b88a24735da38b37e7984fb
           path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1
@@ -83,7 +83,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          ref: c3324024ced9bb1eb854397686919c3ff7d97e1e
+          ref: 22eff1e5c114949d4b88a24735da38b37e7984fb
           path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@stable
@@ -109,7 +109,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          ref: c3324024ced9bb1eb854397686919c3ff7d97e1e
+          ref: 22eff1e5c114949d4b88a24735da38b37e7984fb
           path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1
@@ -136,7 +136,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          ref: c3324024ced9bb1eb854397686919c3ff7d97e1e
+          ref: 22eff1e5c114949d4b88a24735da38b37e7984fb
           path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@stable
@@ -160,7 +160,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          ref: c3324024ced9bb1eb854397686919c3ff7d97e1e
+          ref: 22eff1e5c114949d4b88a24735da38b37e7984fb
           path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1
@@ -186,7 +186,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          ref: c3324024ced9bb1eb854397686919c3ff7d97e1e
+          ref: 22eff1e5c114949d4b88a24735da38b37e7984fb
           path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1

addresses/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings

base58/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings

bitcoin/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings

chacha20_poly1305/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings

consensus_encoding/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings

consensus_encoding/tests/encode.rs

@@ -5,7 +5,9 @@
 #[cfg(feature = "std")]
 use std::io::{Cursor, Write};
 
-use bitcoin_consensus_encoding::{ArrayEncoder, BytesEncoder, Encodable, Encoder};
+use bitcoin_consensus_encoding::{ArrayEncoder, BytesEncoder, Encoder};
+#[cfg(feature = "alloc")]
+use bitcoin_consensus_encoding::{Encodable};
 
 // Simple test type that implements Encodable.
 #[cfg(feature = "alloc")]

hashes/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings

internals/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings

io/contrib/extra_lints.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings