TypeScript: enable strict (#179)

Author: bakkot

src/Clause.ts

@@ -10,9 +10,11 @@ import { Context } from './Context';
 export default class Clause extends Builder {
   id: string;
   namespace: string;
+  // @ts-ignore skipping the strictPropertyInitialization check
   header: HTMLHeadingElement;
   parentClause: Clause;
-  title: string;
+  title?: string;
+  // @ts-ignore skipping the strictPropertyInitialization check
   titleHTML: string;
   subclauses: Clause[];
   number: string;

src/NonTerminal.ts

@@ -8,7 +8,7 @@ export default class NonTerminal extends Builder {
   params: string | null;
   optional: boolean;
   namespace: string;
-  entry: BiblioEntry;
+  entry?: BiblioEntry;
 
   static elements = ['EMU-NT'];
 

src/Note.ts

@@ -6,7 +6,7 @@ import { Context } from './Context';
 /*@internal*/
 export default class Note extends Builder {
   clause: Clause;
-  id: string;
+  id?: string;
   type: string; // normal, editor
   static elements = ['EMU-NOTE'];
 

src/RHS.ts

@@ -41,15 +41,15 @@ export default class RHS extends Builder {
         const text = node.textContent!.trim();
         const pieces = text.split(/\s/);
 
-        pieces.forEach(function (p) {
+        pieces.forEach(p => {
           if (p.length === 0) {
             return;
           }
           const est = this.spec.doc.createElement('emu-t');
           est.textContent = p;
 
           parentNode.insertBefore(est, node);
-        }, this);
+        });
 
         parentNode.removeChild(node);
       }

src/Spec.ts

@@ -129,6 +129,9 @@ export default class Spec {
       table: 0,
       figure: 0
     };
+    this._xrefs = [];
+    this._ntRefs = [];
+    this._prodRefs = [];
     this._textNodes = {};
 
     this.processMetadata();
@@ -216,10 +219,6 @@ export default class Spec {
       currentId: null
     };
 
-    this._xrefs = [];
-    this._ntRefs = [];
-    this._prodRefs = [];
-
     const document = this.doc;
     const walker = document.createTreeWalker(document.body, 1 | 4 /* elements and text nodes */);
 

src/tsconfig.json

@@ -3,8 +3,7 @@
         "target": "es6",
         "module": "commonjs",
         "moduleResolution": "node",
-        "strictNullChecks": true,
-        "noImplicitAny": true,
+        "strict": true,
         "declaration": true,
         "stripInternal": true,
         "outDir": "../lib",
@@ -13,4 +12,4 @@
             "../node_modules/@types"
         ]
     }
-}
+}