Skip to content

Commit d01e152

Browse files
authored
fix: replace deprecated getLevelName with IntEnum for log levels (#506)
1 parent 967cb92 commit d01e152

File tree

5 files changed

+19
-13
lines changed

5 files changed

+19
-13
lines changed

taskiq/cli/common_args.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
import enum
2+
import logging
23

34

4-
class LogLevel(str, enum.Enum):
5+
class LogLevel(enum.IntEnum):
56
"""Different log levels."""
67

7-
INFO = "INFO"
8-
WARNING = "WARNING"
9-
DEBUG = "DEBUG"
10-
ERROR = "ERROR"
11-
FATAL = "FATAL"
8+
INFO = logging.INFO
9+
WARNING = logging.WARNING
10+
DEBUG = logging.DEBUG
11+
ERROR = logging.ERROR
12+
CRITICAL = logging.CRITICAL
13+
FATAL = logging.FATAL

taskiq/cli/scheduler/args.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class SchedulerArgs:
1212

1313
scheduler: Union[str, TaskiqScheduler]
1414
modules: List[str]
15-
log_level: str = LogLevel.INFO.name
15+
log_level: LogLevel = LogLevel.INFO
1616
configure_logging: bool = True
1717
fs_discover: bool = False
1818
tasks_pattern: Sequence[str] = ("**/tasks.py",)
@@ -96,4 +96,6 @@ def from_cli(cls, args: Optional[Sequence[str]] = None) -> "SchedulerArgs":
9696
# This is an argparse limitation.
9797
if len(namespace.tasks_pattern) > 1:
9898
namespace.tasks_pattern.pop(0)
99+
# Convert log_level string to LogLevel enum
100+
namespace.log_level = LogLevel[namespace.log_level]
99101
return cls(**namespace.__dict__)

taskiq/cli/scheduler/run.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import inspect
33
import sys
44
from datetime import datetime, timedelta, timezone
5-
from logging import basicConfig, getLevelName, getLogger
5+
from logging import basicConfig, getLogger
66
from typing import Any, Dict, List, Optional, Set, Tuple
77

88
import pytz
@@ -239,14 +239,14 @@ async def run_scheduler(args: SchedulerArgs) -> None:
239239
"""
240240
if args.configure_logging:
241241
basicConfig(
242-
level=getLevelName(args.log_level),
242+
level=args.log_level,
243243
format=(
244244
"[%(asctime)s][%(levelname)-7s]"
245245
"[%(module)s:%(funcName)s:%(lineno)d]"
246246
" %(message)s"
247247
),
248248
)
249-
getLogger("taskiq").setLevel(level=getLevelName(args.log_level))
249+
getLogger("taskiq").setLevel(level=args.log_level)
250250

251251
if isinstance(args.scheduler, str):
252252
scheduler = import_object(args.scheduler)

taskiq/cli/worker/args.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,4 +261,6 @@ def from_cli(
261261
# This is an argparse limitation.
262262
if len(namespace.tasks_pattern) > 1:
263263
namespace.tasks_pattern.pop(0)
264+
# Convert log_level string to LogLevel enum
265+
namespace.log_level = LogLevel[namespace.log_level]
264266
return WorkerArgs(**namespace.__dict__)

taskiq/cli/worker/run.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def start_listen(args: WorkerArgs) -> None:
8888
hardkill_counter = 0
8989
if args.configure_logging and get_start_method() == "spawn":
9090
logging.basicConfig(
91-
level=logging.getLevelName(args.log_level),
91+
level=args.log_level,
9292
format=args.log_format,
9393
)
9494

@@ -190,10 +190,10 @@ def run_worker(args: WorkerArgs) -> Optional[int]:
190190
set_start_method("spawn")
191191
if args.configure_logging:
192192
logging.basicConfig(
193-
level=logging.getLevelName(args.log_level),
193+
level=args.log_level,
194194
format=args.log_format,
195195
)
196-
logging.getLogger("taskiq").setLevel(level=logging.getLevelName(args.log_level))
196+
logging.getLogger("taskiq").setLevel(level=args.log_level)
197197
logging.getLogger("watchdog.observers.inotify_buffer").setLevel(level=logging.INFO)
198198
logger.info("Pid of a main process: %s", str(os.getpid()))
199199
logger.info("Starting %s worker processes.", args.workers)

0 commit comments

Comments
 (0)