Changed linter to ruff.

Signed-off-by: Pavel Kirilin <win10@list.ru>

Author: s3rius

.github/workflows/test.yml

@@ -8,10 +8,8 @@ jobs:
       matrix:
         cmd:
           - black
-          - flake8
-          - isort
+          - ruff
           - mypy
-          - autoflake
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.gitignore

@@ -168,3 +168,6 @@ node_modules
 
 # macOS
 .DS_Store
+
+# Ruff
+.ruff_cache/

.pre-commit-config.yaml

@@ -12,7 +12,7 @@ repos:
   - repo: https://github.com/asottile/add-trailing-comma
     rev: v2.1.0
     hooks:
-    -   id: add-trailing-comma
+      - id: add-trailing-comma
 
   - repo: local
     hooks:
@@ -22,35 +22,19 @@ repos:
         language: system
         types: [python]
 
-      - id: autoflake
-        name: autoflake
-        entry: poetry run autoflake
-        language: system
-        types: [ python ]
-        args: [ --in-place, --remove-all-unused-imports, --remove-duplicate-keys ]
-
-      - id: isort
-        name: isort
-        entry: poetry run isort
-        language: system
-        types: [ python ]
-
-      - id: flake8
-        name: Check with Flake8
-        entry: poetry run flake8
+      - id: ruff
+        name: Run ruff lints
+        entry: poetry run ruff
         language: system
         pass_filenames: false
-        types: [ python ]
-        args: [--count, taskiq]
+        types: [python]
+        args:
+          - "--fix"
+          - "taskiq"
+          - "tests"
 
       - id: mypy
         name: Validate types with MyPy
         entry: poetry run mypy
         language: system
-        types: [ python ]
-
-      - id: yesqa
-        name: Remove usless noqa
-        entry: poetry run yesqa
-        language: system
-        types: [ python ]
+        types: [python]

poetry.lock

@@ -47,19 +47,15 @@ pytz = "*"
 
 [tool.poetry.dev-dependencies]
 pytest = "^7.1.2"
+ruff = "^0.0.291"
 black = { version = "^22.6.0", allow-prereleases = true }
-flake8 = "^6"
-isort = "^5.10.1"
 mypy = "^1"
 pre-commit = "^2.20.0"
-yesqa = "^1.3.0"
-autoflake = "^1.4"
 coverage = "^6.4.2"
 pytest-cov = "^3.0.0"
 mock = "^4.0.3"
 pytest-xdist = { version = "^2.5.0", extras = ["psutil"] }
 types-mock = "^4.0.15"
-wemake-python-styleguide = "^0.18.0"
 tox = "^4.6.4"
 freezegun = "^1.2.2"
 pytest-mock = "^3.11.1"
@@ -96,7 +92,7 @@ profile = "black"
 multi_line_output = 3
 
 [tool.pytest.ini_options]
-log_level='INFO'
+log_level = 'INFO'
 
 [tool.coverage.run]
 omit = [
@@ -113,3 +109,73 @@ omit = [
 [build-system]
 requires = ["poetry-core>=1.0.0"]
 build-backend = "poetry.core.masonry.api"
+
+[tool.ruff]
+# List of enabled rulsets.
+# See https://docs.astral.sh/ruff/rules/ for more information.
+select = [
+    "E",   # Error
+    "F",   # Pyflakes
+    "W",   # Pycodestyle
+    "C90", # McCabe complexity
+    "I",   # Isort
+    "N",   # pep8-naming
+    "D",   # Pydocstyle
+    "ANN", # Pytype annotations
+    "S",   # Bandit
+    "B",   # Bugbear
+    "COM", # Commas
+    "C4",  # Comprehensions
+    "ISC", # Implicit string concat
+    "PIE", # Unnecessary code
+    "T20", # Catch prints
+    "PYI", # validate pyi files
+    "Q",   # Checks for quotes
+    "RSE", # Checks raise statements
+    "RET", # Checks return statements
+    "SLF", # Self checks
+    "SIM", # Simplificator
+    "PTH", # Pathlib checks
+    "ERA", # Checks for commented out code
+    "PL",  # PyLint checks
+    "RUF", # Specific to Ruff checks
+]
+ignore = [
+    "D105",    # Missing docstring in magic method
+    "D107",    # Missing docstring in __init__
+    "D212",    # Multi-line docstring summary should start at the first line
+    "D401",    # First line should be in imperative mood
+    "D104",    # Missing docstring in public package
+    "D100",    # Missing docstring in public module
+    "ANN102",  # Missing type annotation for self in method
+    "ANN101",  # Missing type annotation for argument
+    "ANN401",  # typing.Any are disallowed in `**kwargs
+    "PLR0913", # Too many arguments for function call
+    "D106",    # Missing docstring in public nested class
+]
+exclude = [".venv/"]
+mccabe = { max-complexity = 10 }
+line-length = 88
+
+[tool.ruff.per-file-ignores]
+"tests/*" = [
+    "S101", # Use of assert detected
+    "S301", # Use of pickle detected
+    "D103", # Missing docstring in public function
+    "SLF001", # Private member accessed
+    "S311", # Standard pseudo-random generators are not suitable for security/cryptographic purposes
+    "D101", # Missing docstring in public class
+]
+
+[tool.ruff.pydocstyle]
+convention = "pep257"
+ignore-decorators = ["typing.overload"]
+
+[tool.ruff.pylint]
+allow-magic-value-types = ["int", "str", "float", "tuple"]
+
+[tool.ruff.flake8-bugbear]
+extend-immutable-calls = [
+    "taskiq_dependencies.Depends",
+    "taskiq.TaskiqDepends",
+]

pyproject.toml

@@ -8,7 +8,7 @@
 from taskiq.abc.cmd import TaskiqCMD
 
 
-def main() -> None:  # noqa: C901, WPS210  # pragma: no cover
+def main() -> None:  # pragma: no cover
     """
     Main entrypoint of the taskiq.
 
@@ -48,7 +48,7 @@ def main() -> None:  # noqa: C901, WPS210  # pragma: no cover
         try:
             cmd_class = entrypoint.load()
         except ImportError as exc:
-            print(f"Could not load {entrypoint.value}. Cause: {exc}")  # noqa: WPS421
+            print(f"Could not load {entrypoint.value}. Cause: {exc}")  # noqa: T201
             continue
         if issubclass(cmd_class, TaskiqCMD):
             subparsers.add_parser(
@@ -61,7 +61,7 @@ def main() -> None:  # noqa: C901, WPS210  # pragma: no cover
     args, _ = parser.parse_known_args()
 
     if args.version:
-        print(__version__)  # noqa: WPS421
+        print(__version__)  # noqa: T201
         return
 
     if args.subcommand is None:
@@ -72,7 +72,7 @@ def main() -> None:  # noqa: C901, WPS210  # pragma: no cover
     sys.argv.pop(0)
     status = command.exec(sys.argv[1:])
     if status is not None:
-        exit(status)  # noqa: WPS421
+        exit(status)  # noqa: PLR1722
 
 
 if __name__ == "__main__":  # pragma: no cover

taskiq/__main__.py

@@ -5,7 +5,7 @@
 from collections import defaultdict
 from functools import wraps
 from logging import getLogger
-from typing import (  # noqa: WPS235
+from typing import (
     TYPE_CHECKING,
     Any,
     AsyncGenerator,
@@ -39,7 +39,7 @@
     from taskiq.abc.formatter import TaskiqFormatter
     from taskiq.abc.result_backend import AsyncResultBackend
 
-_T = TypeVar("_T")  # noqa: WPS111
+_T = TypeVar("_T")
 _FuncParams = ParamSpec("_FuncParams")
 _ReturnType = TypeVar("_ReturnType")
 
@@ -307,7 +307,7 @@ def make_decorated_task(
             def inner(
                 func: Callable[_FuncParams, _ReturnType],
             ) -> AsyncTaskiqDecoratedTask[_FuncParams, _ReturnType]:
-                nonlocal inner_task_name  # noqa: WPS420
+                nonlocal inner_task_name
                 if inner_task_name is None:
                     fmodule = func.__module__
                     if fmodule == "__main__":  # pragma: no cover
@@ -319,7 +319,7 @@ def inner(
                     fname = func.__name__
                     if fname == "<lambda>":
                         fname = f"lambda_{uuid4().hex}"
-                    inner_task_name = f"{fmodule}:{fname}"  # noqa: WPS442
+                    inner_task_name = f"{fmodule}:{fname}"
                 wrapper = wraps(func)
 
                 decorated_task = wrapper(

taskiq/abc/broker.py

@@ -9,7 +9,7 @@
 logger = getLogger("taskiq.receiver")
 
 
-async def run_receiver_task(  # noqa: WPS211
+async def run_receiver_task(
     broker: AsyncBroker,
     receiver_cls: Type[Receiver] = Receiver,
     sync_workers: int = 4,

taskiq/api/receiver.py

@@ -19,5 +19,5 @@ async def run_scheduler_task(
         await source.startup()
     if run_startup:
         await scheduler.startup()
-    while True:  # noqa: WPS457
+    while True:
         await run_scheduler_loop(scheduler)

taskiq/api/scheduler.py

@@ -39,9 +39,11 @@ async def set_result(self, task_id: str, result: TaskiqResult[_ReturnType]) -> N
         :param task_id: id of a task.
         :param result: result of an execution.
         """
-        if self.max_stored_results != -1:
-            if len(self.results) >= self.max_stored_results:
-                self.results.popitem(last=False)
+        if (
+            self.max_stored_results != -1
+            and len(self.results) >= self.max_stored_results
+        ):
+            self.results.popitem(last=False)
         self.results[task_id] = result
 
     async def is_result_ready(self, task_id: str) -> bool:
@@ -85,7 +87,7 @@ class InMemoryBroker(AsyncBroker):
     It's useful for local development, if you don't want to setup real broker.
     """
 
-    def __init__(  # noqa: WPS211
+    def __init__(
         self,
         sync_tasks_pool_size: int = 4,
         max_stored_results: int = 100,