Skip to content

Commit e265d23

Browse files
authored
Merge branch 'master' into chore(env)/speed-up-build-process
2 parents 633d879 + a39a0e8 commit e265d23

File tree

6 files changed

+989
-9
lines changed

6 files changed

+989
-9
lines changed

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ WORKDIR /app
4040

4141
COPY . /app
4242
COPY ./docker/php/php.ini /usr/local/etc/php/php.ini
43+
COPY ./docker/php/www.conf /usr/local/etc/php-fpm.d/www.conf
4344

4445
RUN chmod +x /app/bin/console
4546
RUN chmod +x /app/docker-entrypoint.sh

Dockerfile_dev

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,18 +75,16 @@ COPY --from=composer:2.6.4 /usr/bin/composer /usr/bin/composer
7575
# Enable Composer autocompletion
7676
RUN composer completion bash > /etc/bash_completion.d/composer
7777

78-
# Copy development `php.ini` configuration to container
78+
# Copy development `php.ini` and PHP-FPM pool configuration to container
7979
#
80-
# Also note that this is mounted within `docker-compose.yml` file, so
80+
# Also note that these files mounted within `docker-compose.yml` file, so
8181
# you don't need to build containers again if you change something just
8282
# restart containers and you're good
8383
COPY ./docker/php/php-dev.ini /usr/local/etc/php/php.ini
84+
COPY ./docker/php/www-dev.conf /usr/local/etc/php-fpm.d/www.conf
8485

8586
RUN chmod -R o+s+w /usr/local/etc/php
8687

87-
# Enable PHP-FPM status page
88-
RUN echo 'pm.status_path = /status' >> /usr/local/etc/php-fpm.d/www.conf
89-
9088
RUN curl -s https://api.github.com/repos/fabpot/local-php-security-checker/releases/latest | \
9189
grep -E "browser_download_url(.+)linux_amd64" | \
9290
cut -d : -f 2,3 | \

docker-compose.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ services:
1515
- mariadb
1616
volumes:
1717
- ./:/app:cached
18+
- ./docker/php/php-dev.ini:/usr/local/etc/php/php.ini
19+
- ./docker/php/www-dev.conf:/usr/local/etc/php-fpm.d/www.conf
1820
tmpfs:
1921
- /app/var/:uid=$HOST_UID,gid=$HOST_GID
2022
environment:

docker-entrypoint-dev.sh

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ set -e
44
#
55
# If we're starting web-server we need to do following:
66
# 0) Basic linting of current JSON configuration file
7-
# 1) Copy updated php configuration file, with this we can change php
8-
# configuration without rebuilding image
7+
# 1) Export needed environment variables
98
# 2) Install all dependencies
109
# 3) Generate JWT encryption keys
1110
# 4) Create database if it not exists yet
@@ -17,8 +16,6 @@ set -e
1716
make lint-configuration
1817

1918
# Step 1
20-
cp /app/docker/php/php-dev.ini /usr/local/etc/php/php.ini
21-
2219
DOCKER_IP=$(/sbin/ip route|awk '/default/ { print $3 }')
2320

2421
export DOCKER_IP

0 commit comments

Comments
 (0)