Skip to content

Commit 49c2842

Browse files
committed
Code cleanup
1 parent 8f9eb12 commit 49c2842

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

tests/Integration/TestCase/EntityTestCase.php

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ public function testThatSetterReturnsInstanceOfEntity(
179179
string $type,
180180
FieldMapping|AssociationMapping $meta,
181181
): void {
182-
//if (!(isset($meta->fieldName) && $meta->columnDefinition === null)) {
183182
if (method_exists($meta, 'isManyToManyOwningSide')
184183
&& (
185184
$meta->isManyToManyOwningSide()
@@ -257,28 +256,6 @@ public function testThatGetterReturnsExpectedValue(
257256
);
258257
}
259258

260-
/*
261-
//if (array_key_exists('columnName', $meta) || array_key_exists('joinColumns', $meta)) {
262-
if (isset($meta->fieldName) && $meta->columnDefinition === null) {
263-
$value = PhpUnitUtil::getValidValueForType($type, $meta);
264-
$entity->{$setter}($value);
265-
self::assertSame(
266-
$value,
267-
$callable(),
268-
sprintf(
269-
'Getter method of %s:%s did not return expected value type (%s) and it returned (%s)',
270-
static::$entityName,
271-
$getter,
272-
gettype($value),
273-
gettype($callable()),
274-
),
275-
);
276-
} else {
277-
$type = ArrayCollection::class;
278-
self::assertInstanceOf($type, $callable());
279-
}
280-
*/
281-
282259
try {
283260
$method = 'assertIs' . ucfirst($type);
284261

tests/Utils/PhpUnitUtil.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,6 @@ private static function getValidValue(
270270

271271
if (substr_count($type, '\\') > 1 && !str_contains($type, '|')) {
272272
/** @var class-string $class */
273-
//$class = $meta !== [] && array_key_exists('targetEntity', $meta) ? $meta['targetEntity'] : $type;
274273
$class = $meta->targetEntity ?? $type;
275274

276275
$type = self::TYPE_CUSTOM_CLASS;

0 commit comments

Comments
 (0)