replicaset: drop unused worker:remove_service() function

The function was used incorrectly in the router and did nothing,
since the newly created replicasets cannot have the service, which
has not been added there, and consequently, there's nothing to drop.

The commit also drops the `remove_service` function, because we don't
have use case, where the service should be removed from the replicaset.

NO_DOC=refactoring
NO_TEST=refactoring

Author: Serpentian

test/replicaset-luatest/replicaset_3_test.lua

@@ -837,7 +837,7 @@ test_group.test_worker_service_info = function()
     end
 
     -- Check info of replicas only.
-    rs.worker:remove_service(rs_service_name)
+    rs.worker.services[rs_service_name] = nil
     info = rs:service_info(service_name)
     t.assert_equals(info.name, nil)
     t.assert_not_equals(info.replicas, nil)

vshard/replicaset.lua

@@ -2160,16 +2160,10 @@ local function worker_wakeup_service(worker, service_name)
     pcall(worker.fiber.wakeup, worker.fiber)
 end
 
-local function worker_remove_service(worker, service_name)
-    -- On the next iteration of worker service won't run.
-    worker.services[service_name] = nil
-end
-
 local worker_mt = {
     __index = {
         add_service = worker_add_service,
         wakeup_service = worker_wakeup_service,
-        remove_service = worker_remove_service,
     }
 }
 

vshard/router/init.lua

@@ -1214,12 +1214,7 @@ local function master_search_set(router)
             end
         end
     else
-        -- Do not make users pay for what they do not use - when the search is
-        -- disabled for all replicasets, there should not be any fiber.
         log.info('Master auto search is disabled')
-        for _, replicaset in pairs(router.replicasets) do
-            replicaset.worker:remove_service(service_name)
-        end
     end
 end