Skip to content

Commit c67086a

Browse files
committed
Do not set build arguments if the corresponding env variables are not set
1 parent f05df05 commit c67086a

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

src/main/java/org/testcontainers/containers/TarantoolCartridgeContainer.java

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.testcontainers.images.builder.ImageFromDockerfile;
55

66
import java.net.URL;
7+
import java.util.Arrays;
78
import java.util.List;
89
import java.util.concurrent.CompletableFuture;
910
import java.util.concurrent.ExecutionException;
@@ -159,15 +160,22 @@ private TarantoolCartridgeContainer(Future<String> image, String instancesFile,
159160
}
160161

161162
private static Future<String> withArguments(ImageFromDockerfile image) {
162-
return image
163-
.withBuildArg(ENV_TARANTOOL_VERSION, System.getenv(ENV_TARANTOOL_VERSION))
164-
.withBuildArg(ENV_TARANTOOL_SERVER_USER, System.getenv(ENV_TARANTOOL_SERVER_USER))
165-
.withBuildArg(ENV_TARANTOOL_SERVER_UID, System.getenv(ENV_TARANTOOL_SERVER_UID))
166-
.withBuildArg(ENV_TARANTOOL_SERVER_GROUP, System.getenv(ENV_TARANTOOL_SERVER_GROUP))
167-
.withBuildArg(ENV_TARANTOOL_SERVER_GID, System.getenv(ENV_TARANTOOL_SERVER_GID))
168-
.withBuildArg(ENV_TARANTOOL_WORKDIR, System.getenv(ENV_TARANTOOL_WORKDIR))
169-
.withBuildArg(ENV_TARANTOOL_RUNDIR, System.getenv(ENV_TARANTOOL_RUNDIR))
170-
.withBuildArg(ENV_TARANTOOL_DATADIR, System.getenv(ENV_TARANTOOL_DATADIR));
163+
for (String envVariable : Arrays.asList(
164+
ENV_TARANTOOL_VERSION,
165+
ENV_TARANTOOL_SERVER_USER,
166+
ENV_TARANTOOL_SERVER_UID,
167+
ENV_TARANTOOL_SERVER_GROUP,
168+
ENV_TARANTOOL_SERVER_GID,
169+
ENV_TARANTOOL_WORKDIR,
170+
ENV_TARANTOOL_RUNDIR,
171+
ENV_TARANTOOL_DATADIR
172+
)) {
173+
String variableValue = System.getenv(envVariable);
174+
if (variableValue != null) {
175+
image.withBuildArg(envVariable, variableValue);
176+
}
177+
}
178+
return image;
171179
}
172180

173181
private static ImageFromDockerfile buildImage() {

0 commit comments

Comments
 (0)