pylint: fix remaining compatibility issues

See [1] about global bad-option-value fail to work.

1. pylint-dev/pylint#3312

Part of #270

Author: DifferentialOrange

.pylintrc

@@ -1,7 +1,3 @@
-[MAIN]
-# Enable backward compatibility with pylint for pylint down to Python 3.6 one
-ignore=bad-option-value
-
 [BASIC]
 
 # Good variable names which should always be accepted, separated by a comma

setup.py

@@ -2,6 +2,7 @@
 """
 Package setup commands.
 """
+# pylint: disable=bad-option-value,too-many-ancestors
 
 import codecs
 import os

tarantool/connection.py

@@ -1,7 +1,7 @@
 """
 This module provides API for interaction with a Tarantool server.
 """
-# pylint: disable=too-many-lines
+# pylint: disable=too-many-lines,duplicate-code
 
 import os
 import time
@@ -1005,7 +1005,7 @@ def _ssl_load_cert_chain(self, context):
                                         keyfile=self.ssl_key_file,
                                         password=self.ssl_password)
                 return
-            except Exception as exc:  # pylint: disable=broad-exception-caught,broad-except
+            except Exception as exc:  # pylint: disable=bad-option-value,broad-exception-caught,broad-except
                 exc_list.append(exc)
 
         if self.ssl_password_file is not None:
@@ -1016,7 +1016,7 @@ def _ssl_load_cert_chain(self, context):
                                                 keyfile=self.ssl_key_file,
                                                 password=line.rstrip())
                         return
-                    except Exception as exc:  # pylint: disable=broad-exception-caught,broad-except
+                    except Exception as exc:  # pylint: disable=bad-option-value,broad-exception-caught,broad-except
                         exc_list.append(exc)
 
         try:
@@ -1029,7 +1029,7 @@ def password_raise_error():
                                     password=password_raise_error)
 
             return
-        except Exception as exc:  # pylint: disable=broad-exception-caught,broad-except
+        except Exception as exc:  # pylint: disable=bad-option-value,broad-exception-caught,broad-except
             exc_list.append(exc)
 
         raise SslError(exc_list)

tarantool/connection_pool.py

@@ -1,7 +1,7 @@
 """
 This module provides API for interaction with Tarantool servers cluster.
 """
-# pylint: disable=too-many-lines
+# pylint: disable=too-many-lines,duplicate-code
 
 import abc
 import itertools
@@ -167,6 +167,7 @@ class StrategyInterface(metaclass=abc.ABCMeta):
     """
     Defines strategy to choose a pool server based on a request mode.
     """
+    # pylint: disable=bad-option-value,super-init-not-called
 
     @classmethod
     def __subclasshook__(cls, subclass):
@@ -210,6 +211,7 @@ class RoundRobinStrategy(StrategyInterface):
     """
     Simple round-robin pool servers rotation.
     """
+    # pylint: disable=bad-option-value,no-self-use,super-init-not-called
 
     def __init__(self, pool):
         """
@@ -372,7 +374,7 @@ class ConnectionPool(ConnectionInterface):
         >>> resp
         - ['AAAA', 'Alpha']
     """
-    # pylint: disable=too-many-public-methods,duplicate-code,bad-option-value,no-self-use,super-init-not-called,bad-option-value
+    # pylint: disable=too-many-public-methods,duplicate-code,bad-option-value,no-self-use
 
     def __init__(self,
                  addrs,
@@ -652,7 +654,7 @@ def _request_process_loop(self, key, unit, last_refresh):
                 method = getattr(Connection, task.method_name)
                 try:
                     resp = method(unit.conn, *task.args, **task.kwargs)
-                except Exception as exc:  # pylint: disable=broad-exception-caught,broad-except
+                except Exception as exc:  # pylint: disable=bad-option-value,broad-exception-caught,broad-except
                     unit.output_queue.put(exc)
                 else:
                     unit.output_queue.put(resp)

tarantool/dbapi.py

@@ -3,7 +3,7 @@
 
 .. _PEP-249: http://www.python.org/dev/peps/pep-0249/
 """
-# pylint: disable=fixme,unused-import
+# pylint: disable=fixme,unused-import,bad-option-value,no-self-use
 # flake8: noqa: F401
 
 from tarantool.connection import Connection as BaseConnection

tarantool/mesh_connection.py

@@ -1,7 +1,7 @@
 """
 This module provides API for interaction with Tarantool servers cluster.
 """
-# pylint: disable=fixme
+# pylint: disable=fixme,duplicate-code
 
 import time
 
@@ -267,7 +267,6 @@ class MeshConnection(Connection):
     """
     Represents a connection to a cluster of Tarantool servers.
     """
-    # pylint: disable=duplicate-code
 
     def __init__(self, host=None, port=None,
                  user=None,

tarantool/msgpack_ext/packer.py

@@ -3,6 +3,7 @@
 
 .. _extension: https://www.tarantool.io/en/doc/latest/dev_guide/internals/msgpack_extensions/
 """
+# pylint: disable=duplicate-code
 
 from decimal import Decimal
 from uuid import UUID

tarantool/msgpack_ext/unpacker.py

@@ -3,6 +3,7 @@
 
 .. _extension: https://www.tarantool.io/en/doc/latest/dev_guide/internals/msgpack_extensions/
 """
+# pylint: disable=duplicate-code
 
 import tarantool.msgpack_ext.decimal as ext_decimal
 import tarantool.msgpack_ext.uuid as ext_uuid

test/suites/test_encoding.py

@@ -74,7 +74,7 @@ def setUpClass(cls):
     def assertNotRaises(self, func, *args, **kwargs):
         try:
             func(*args, **kwargs)
-        except Exception as exc:  # pylint: disable=broad-exception-caught,broad-except
+        except Exception as exc:  # pylint: disable=bad-option-value,broad-exception-caught,broad-except
             self.fail(f'Function raised Exception: {repr(exc)}')
 
     def setUp(self):

test/suites/test_pool.py

@@ -2,7 +2,7 @@
 This module tests work with a cluster of Tarantool servers through
 ConnectionPool.
 """
-# pylint: disable=missing-class-docstring,missing-function-docstring,too-many-public-methods,duplicate-code,bad-option-value,no-self-use
+# pylint: disable=missing-class-docstring,missing-function-docstring,too-many-public-methods,too-many-locals,duplicate-code,bad-option-value,no-self-use
 
 import sys
 import time
@@ -69,7 +69,7 @@ def retry(self, func, count=5, timeout=0.5):
         for i in range(count):
             try:
                 func()
-            except Exception as exc:  # pylint: disable=broad-exception-caught,broad-except
+            except Exception as exc:  # pylint: disable=bad-option-value,broad-exception-caught,broad-except
                 if i + 1 == count:
                     raise exc