build/debian: eliminate hardcoded PHP 7.0 version

Preprocess debian/control file to set proper package name like
php7.3-tarantool. Use the package name in debian/rules file to determine
installation paths.

Removed php7.0-dev dependency, because php-all-dev already depends on
proper php7.?-dev package.

This change allows to build a Deb package for distributions, which
provides PHP version other then 7.0. Those builds will be enabled in CI
in further commits.

Details
-------

It seems it is not possible to build a package with a conditional name
(depending of a distribution). `man 5 deb-substvars` explicitly states
that 'Package' field in debian/control can be parametrized using a
substitution varible.

Another possible way would be define several 'Package' fields in
debian/control and build only one for each distribution. However I don't
find a way to build only one package using `debuild` (it is used inside
`packpack`).

So it seems that the preprocessing is the only way to build, say,
php7.0-tarantool package for Debian Stretch and php7.3-tarantool for
Debian Buster.

The preprocessing is performed from debian/prebuild.sh script, which is
invoked by `packpack`. So nothing changed in the build process from a
caller perspective.

Part of #117

Author: Totktonada

debian/control renamed to debian/control.in

@@ -2,15 +2,16 @@ Source: php-tarantool
 Priority: optional
 Maintainer: Dmitry E. Oboukhov <unera@debian.org>
 Build-Depends: debhelper (>= 8),
-               php7.0-dev | php-all-dev,
+               php-all-dev,
                pkg-config
 Section: php
 Standards-Version: 3.9.4
 Homepage: https://github.com/tarantool/tarantool-php
 VCS-Browser: https://github.com/tarantool/tarantool-php
 VCS-Git: git://github.com/tarantool/tarantool-php.git
 
-Package: php7.0-tarantool
+# Package name is preprocessed in debian/prebuild.sh.
+Package: php${phpversion}-tarantool
 Architecture: any
 Priority: optional
 Conflicts: libtarantool-php

debian/prebuild.sh

@@ -0,0 +1,18 @@
+#!/bin/sh
+
+set -exu  # Strict shell (w/o -o pipefail)
+
+# Preserve DEBIAN_FRONTEND=noninteractive. It prevents packages
+# like tzdata from asking configuration parameters interactively.
+#
+# See https://github.com/packpack/packpack/issues/7
+SUDO="sudo -E"
+
+${SUDO} apt-get update > /dev/null
+${SUDO} apt-get -y install php-all-dev
+
+phpversion=$(php-config --version | sed 's/^\([0-9]\+\.[0-9]\).*/\1/')
+
+cd /build/php-tarantool-*
+sed -e "s/\${phpversion}/${phpversion}/" debian/control.in > debian/control
+rm debian/control.in

debian/rules

@@ -2,27 +2,32 @@
 
 include /usr/share/cdbs/1/rules/debhelper.mk
 
-phpapi	= $(shell php-config7.0 --phpapi)
+DEB_PACKAGE := $(strip $(shell egrep '^Package: ' debian/control | \
+	cut -f 2 -d ':'))
+
+phpversion = $(shell echo $(DEB_PACKAGE) | \
+	sed -e 's/^php\([0-9.]\+\)-tarantool$$/\1/')
+phpapi	= $(shell php-config$(phpversion) --phpapi)
 version = $(shell dpkg-parsechangelog \
 	|grep ^Version|awk '{print $$2}'|sed 's/-.*//')
 
-makebuilddir/php7.0-tarantool::
+makebuilddir/php$(phpversion)-tarantool::
 	phpize
 	./configure
 	make
-	echo "php:Depends=phpapi-$(phpapi)" > debian/php7.0-tarantool.substvars
+	echo "php:Depends=phpapi-$(phpapi)" > debian/php$(phpversion)-tarantool.substvars
 
-install/php7.0-tarantool::
-	install -m 0755 -d debian/php7.0-tarantool/usr/lib/php/$(phpapi)/
-	install -m 0755 -d debian/php7.0-tarantool/etc/php/7.0/mods-available/
+install/php$(phpversion)-tarantool::
+	install -m 0755 -d debian/php$(phpversion)-tarantool/usr/lib/php/$(phpapi)/
+	install -m 0755 -d debian/php$(phpversion)-tarantool/etc/php/$(phpversion)/mods-available/
 	install -m 0755 modules/tarantool.so \
-		debian/php7.0-tarantool/usr/lib/php/$(phpapi)/
+		debian/php$(phpversion)-tarantool/usr/lib/php/$(phpapi)/
 	echo extension=tarantool.so \
-		> debian/php7.0-tarantool/etc/php/7.0/mods-available/tarantool.ini
+		> debian/php$(phpversion)-tarantool/etc/php/$(phpversion)/mods-available/tarantool.ini
 	# Enable the extension.
-	install -m 0755 -d debian/php7.0-tarantool/etc/php/7.0/cli/conf.d
-	ln -s /etc/php/7.0/mods-available/tarantool.ini \
-		debian/php7.0-tarantool/etc/php/7.0/cli/conf.d/50-tarantool.ini
+	install -m 0755 -d debian/php$(phpversion)-tarantool/etc/php/$(phpversion)/cli/conf.d
+	ln -s /etc/php/$(phpversion)/mods-available/tarantool.ini \
+		debian/php$(phpversion)-tarantool/etc/php/$(phpversion)/cli/conf.d/50-tarantool.ini
 
 clean::
 	phpize --clean