CI: add lint and unit test stages

Author: vanyarock01

.github/workflows/test.yml

@@ -1,9 +1,20 @@
 name: Test
 on: [push]
+
 jobs:
-  build:
+  lint:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: lint
+        uses: golangci/golangci-lint-action@v2
+
+  unit_testing:
     name: Build
     runs-on: ubuntu-latest
+    needs: lint
     env:
       OPERATOR_SDK_VERSION: v0.12.0
     steps:
@@ -19,31 +30,5 @@ jobs:
     - name: Install modules
       run: go mod download
 
-    - name: Install operator-sdk
-      run: |
-        curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${OPERATOR_SDK_VERSION}/operator-sdk-${OPERATOR_SDK_VERSION}-x86_64-linux-gnu
-        chmod +x ./operator-sdk-${OPERATOR_SDK_VERSION}-x86_64-linux-gnu
-
-    - name: Build operator
-      run: ./operator-sdk-${OPERATOR_SDK_VERSION}-x86_64-linux-gnu build tarantool/tarantool-operator:${GITHUB_SHA}
-
-    - name: Setup test kubernetes cluster
-      uses: helm/kind-action@v1.0.0-rc.1
-      with:
-        cluster_name: kind
-
-    - name: Load operator image into test cluster
-      run: kind load docker-image tarantool/tarantool-operator:${GITHUB_SHA}
-
-    - name: Create CRDs
-      run: |
-        kubectl create \
-          -f deploy/crds/tarantool_v1alpha1_cluster_crd.yaml \
-          -f deploy/crds/tarantool_v1alpha1_replicasettemplate_crd.yaml \
-          -f deploy/crds/tarantool_v1alpha1_role_crd.yaml
-
     - name: Test
-      run: |
-        ./operator-sdk-${OPERATOR_SDK_VERSION}-x86_64-linux-gnu test local \
-          --image tarantool/tarantool-operator:${GITHUB_SHA} \
-          ./test/e2e
+      run: go test ./pkg/...

pkg/controller/cluster/cluster_controller.go

@@ -340,7 +340,7 @@ func (r *ReconcileCluster) Reconcile(request reconcile.Request) (reconcile.Resul
 
 	for _, sts := range stsList.Items {
 		stsAnnotations := sts.GetAnnotations()
-		weight, _ := stsAnnotations["tarantool.io/replicaset-weight"]
+		weight := stsAnnotations["tarantool.io/replicaset-weight"]
 
 		if weight == "0" {
 			reqLogger.Info("weight is set to 0, checking replicaset buckets for scheduled deletion")
@@ -384,7 +384,7 @@ func (r *ReconcileCluster) Reconcile(request reconcile.Request) (reconcile.Resul
 				return reconcile.Result{RequeueAfter: time.Duration(5 * time.Second)}, err
 			}
 
-			if tarantool.IsJoined(pod) == false {
+			if !tarantool.IsJoined(pod) {
 				reqLogger.Info("Not all instances joined, skip weight change", "StatefulSet.Name", sts.GetName())
 				return reconcile.Result{RequeueAfter: time.Duration(5 * time.Second)}, nil
 			}
@@ -421,7 +421,10 @@ func (r *ReconcileCluster) Reconcile(request reconcile.Request) (reconcile.Resul
 					reqLogger.Info("Added bootstrapped annotation", "StatefulSet.Name", sts.GetName())
 
 					cluster.Status.State = "Ready"
-					r.client.Status().Update(context.TODO(), cluster)
+					err = r.client.Status().Update(context.TODO(), cluster)
+					if err != nil {
+						return reconcile.Result{RequeueAfter: time.Duration(5 * time.Second)}, err
+					}
 					return reconcile.Result{RequeueAfter: time.Duration(5 * time.Second)}, nil
 				}
 

pkg/controller/role/role_controller.go

@@ -4,8 +4,6 @@ import (
 	"context"
 	"fmt"
 
-	goerrors "errors"
-
 	"github.com/google/uuid"
 	tarantoolv1alpha1 "github.com/tarantool/tarantool-operator/pkg/apis/tarantool/v1alpha1"
 	appsv1 "k8s.io/api/apps/v1"
@@ -102,6 +100,10 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error {
 		}),
 	})
 
+	if err != nil {
+		return err
+	}
+
 	return nil
 }
 
@@ -137,7 +139,7 @@ func (r *ReconcileRole) Reconcile(request reconcile.Request) (reconcile.Result,
 	}
 
 	if len(role.GetOwnerReferences()) == 0 {
-		return reconcile.Result{}, goerrors.New(fmt.Sprintf("Orphan role %s", role.GetName()))
+		return reconcile.Result{}, fmt.Errorf("Orphan role %s", role.GetName())
 	}
 
 	templateSelector, err := metav1.LabelSelectorAsSelector(role.Spec.Selector)
@@ -193,7 +195,7 @@ func (r *ReconcileRole) Reconcile(request reconcile.Request) (reconcile.Result,
 	}
 
 	if len(templateList.Items) == 0 {
-		return reconcile.Result{}, goerrors.New("no template")
+		return reconcile.Result{}, fmt.Errorf("no template")
 	}
 
 	template := templateList.Items[0]

pkg/topology/builtin.go

@@ -55,12 +55,6 @@ type BootstrapVshardResponse struct {
 
 // FailoverData Structure of data for changing failover status
 type FailoverData struct {
-	failover *FailoverParams `json:"failover_params"`
-}
-
-// FailoverParams returns the mode of failover which has been enabled
-type FailoverParams struct {
-	mode string `json:"mode"`
 }
 
 // FailoverResponse type struct for returning on failovers
@@ -256,7 +250,7 @@ func (s *BuiltInTopologyService) Join(pod *corev1.Pod) error {
 		return err
 	}
 
-	if resp.JoinInstance == true {
+	if resp.JoinInstance {
 		return nil
 	}
 
@@ -294,7 +288,7 @@ func (s *BuiltInTopologyService) Expel(pod *corev1.Pod) error {
 		return err
 	}
 
-	if resp.Data.ExpelInstance == false && (resp.Errors == nil || len(resp.Errors) == 0) {
+	if !resp.Data.ExpelInstance && (resp.Errors == nil || len(resp.Errors) == 0) {
 		return errors.New("something really bad happened")
 	}
 
@@ -323,7 +317,7 @@ func (s *BuiltInTopologyService) SetWeight(replicasetUUID string, replicaWeight
 		return err
 	}
 
-	if resp.Response == true {
+	if resp.Response {
 		return nil
 	}
 
@@ -353,7 +347,7 @@ func (s *BuiltInTopologyService) BootstrapVshard() error {
 
 	reqLogger.Info("Bootstrapping vshard")
 
-	req := fmt.Sprint("mutation bootstrap {bootstrapVshardResponse: bootstrap_vshard}")
+	req := "mutation bootstrap {bootstrapVshardResponse: bootstrap_vshard}"
 	j := fmt.Sprintf("{\"query\": \"%s\"}", req)
 	rawResp, err := http.Post(s.serviceHost, "application/json", strings.NewReader(j))
 	if err != nil {

test/e2e/utils.go

@@ -32,7 +32,6 @@ func InitializeScenario(ctx *framework.TestCtx, name string) error {
 	for {
 		b, err := dec.Read()
 		if err != nil {
-			fmt.Errorf("%s", err)
 			if err == io.EOF {
 				break
 			}