Add ability to change UpdateStrategy for StatefulSets (#160)

* Add ability to change UpdateStrategy for StatefulSets

Author: kluevandrew

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [unpublished]
 - Add ability to specify key in failover password secret
 - Improve leader election logic
+- Add ability to change UpdateStrategy for StatefulSets
 
 ## [1.0.0-rc1]
 

apis/v1beta1/role_types.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 
 	"github.com/tarantool/tarantool-operator/pkg/api"
+	appsv1 "k8s.io/api/apps/v1"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -65,6 +66,10 @@ type ReplicasetTemplate struct {
 	// +optional
 	// +kubebuilder:default=0
 	MinReadySeconds int32 `json:"minReadySeconds,omitempty"`
+
+	// UpdateStrategy indicates the StatefulSetUpdateStrategy that will be
+	// employed to update Pods in each StatefulSet of role when template is changed
+	UpdateStrategy appsv1.StatefulSetUpdateStrategy `json:"updateStrategy"`
 }
 
 // RoleVShardConfig defines config for vshard

apis/v1beta1/zz_generated.deepcopy.go

@@ -6548,6 +6548,22 @@ spec:
             default: 1
             format: int32
             type: integer
+          updateStrategy:
+            properties:
+              rollingUpdate:
+                properties:
+                  maxUnavailable:
+                    anyOf:
+                    - type: integer
+                    - type: string
+                    x-kubernetes-int-or-string: true
+                  partition:
+                    format: int32
+                    type: integer
+                type: object
+              type:
+                type: string
+            type: object
           volumeClaimTemplates:
             items:
               properties:
@@ -6707,6 +6723,8 @@ spec:
                   type: object
               type: object
             type: array
+        required:
+        - updateStrategy
         type: object
     served: true
     storage: false

config/crd/bases/tarantool.io_replicasettemplates.yaml

@@ -6632,6 +6632,22 @@ spec:
                     default: 1
                     format: int32
                     type: integer
+                  updateStrategy:
+                    properties:
+                      rollingUpdate:
+                        properties:
+                          maxUnavailable:
+                            anyOf:
+                            - type: integer
+                            - type: string
+                            x-kubernetes-int-or-string: true
+                          partition:
+                            format: int32
+                            type: integer
+                        type: object
+                      type:
+                        type: string
+                    type: object
                   volumeClaimTemplates:
                     items:
                       properties:
@@ -6791,6 +6807,8 @@ spec:
                           type: object
                       type: object
                     type: array
+                required:
+                - updateStrategy
                 type: object
               replicasets:
                 default: 1

config/crd/bases/tarantool.io_roles.yaml

@@ -128,9 +128,6 @@ func (r *ReplicasetsManger) createStatefulSet(ctx context.Context, cluster api.C
 			VolumeClaimTemplates: role.Spec.ReplicasetTemplate.VolumeClaimTemplates,
 			ServiceName:          cluster.GetName(),
 			PodManagementPolicy:  appsv1.ParallelPodManagement,
-			UpdateStrategy: appsv1.StatefulSetUpdateStrategy{
-				Type: appsv1.OnDeleteStatefulSetStrategyType,
-			},
 			RevisionHistoryLimit: &revisionHistoryLimit,
 			PersistentVolumeClaimRetentionPolicy: &appsv1.StatefulSetPersistentVolumeClaimRetentionPolicy{
 				WhenDeleted: appsv1.RetainPersistentVolumeClaimRetentionPolicyType,
@@ -220,6 +217,28 @@ func (r *ReplicasetsManger) syncStatefulSet(
 		changed = true
 	}
 
+	if role.Spec.ReplicasetTemplate.UpdateStrategy.Type != sts.Spec.UpdateStrategy.Type {
+		sts.Spec.UpdateStrategy.Type = role.Spec.ReplicasetTemplate.UpdateStrategy.Type
+
+		changed = true
+	}
+
+	if sts.Spec.UpdateStrategy.Type == appsv1.OnDeleteStatefulSetStrategyType {
+		if sts.Spec.UpdateStrategy.RollingUpdate != nil {
+			sts.Spec.UpdateStrategy.RollingUpdate = nil
+
+			changed = true
+		}
+	}
+
+	if sts.Spec.UpdateStrategy.Type == appsv1.RollingUpdateStatefulSetStrategyType {
+		if !cmp.Equal(role.Spec.ReplicasetTemplate.UpdateStrategy.RollingUpdate, sts.Spec.UpdateStrategy.RollingUpdate) {
+			sts.Spec.UpdateStrategy.RollingUpdate = role.Spec.ReplicasetTemplate.UpdateStrategy.RollingUpdate
+
+			changed = true
+		}
+	}
+
 	// If current hash of pod template stored in StatefulSet labels does not match
 	// calculated hash of role's pod template, when it means something changed.
 	// So we need to update StatefulSet