From 37dd8982f33575dfcaf93a6d0025a2a3abb374cc Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 20 Nov 2022 00:53:24 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- library/cartridge_restore_instance.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/library/cartridge_restore_instance.py b/library/cartridge_restore_instance.py index 1ec40dbb..8334176e 100644 --- a/library/cartridge_restore_instance.py +++ b/library/cartridge_restore_instance.py @@ -146,7 +146,26 @@ def unpack_tgz(backup_path, uid, gid): dir_path = os.path.dirname(os.path.join('/', src_member.name)) make_dirs(dir_path, uid, gid) - tar.extractall('/') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, "/") return True, None