Remove message bundle and improve error handling

Author: Bruno Castro

src/_lib/errors/BadRequestError.ts

@@ -3,9 +3,11 @@ import { makePredicate } from '@/_lib/Predicate';
 
 namespace BadRequestError {
   const type = Symbol();
-  const code = 'BadRequestError';
+  const name = 'BadRequestError';
+  const _message = 'Bad Request';
 
-  export const create = (message: string): Exception => new BaseError({ type, code, message });
+  export const create = (message: string = _message, code: string = name): Exception =>
+    new BaseError({ type, name, code, message });
 
   export const is = makePredicate<Exception>(type);
 }

src/_lib/errors/BaseError.ts

@@ -1,18 +1,21 @@
 type Exception<M = any> = Readonly<{
+  name: string;
   type: symbol;
   message: string;
   code: string;
   meta?: M;
 }>;
 
+type Props<M = any> = Omit<Exception<M>, 'name'> & { name?: string };
+
 class BaseError<M = any> extends Error implements Exception<M> {
   public readonly type: symbol;
   public readonly code: string;
   public readonly meta?: M;
 
-  constructor(props: Exception<M>) {
+  constructor(props: Props<M>) {
     super();
-    this.name = props.code;
+    this.name = props.name || props.code;
     this.type = props.type;
     this.code = props.code;
     this.meta = props.meta;

src/_lib/errors/ForbiddenError.ts

@@ -3,10 +3,11 @@ import { makePredicate } from '@/_lib/Predicate';
 
 namespace ForbiddenError {
   const type = Symbol();
-  const code = 'ForbiddenError';
-  const message = 'Forbidden';
+  const name = 'ForbiddenError';
+  const _message = 'Forbidden';
 
-  export const create = (customMsg?: string): Exception => new BaseError({ type, code, message: customMsg || message });
+  export const create = (message: string = _message, code: string = name): Exception =>
+    new BaseError({ type, name, code, message });
 
   export const is = makePredicate<Exception>(type);
 }

src/_lib/errors/NotFoundError.ts

@@ -3,9 +3,11 @@ import { makePredicate } from '@/_lib/Predicate';
 
 namespace NotFoundError {
   const type = Symbol();
-  const code = 'NotFoundError';
+  const name = 'NotFoundError';
+  const _message = 'Not Found';
 
-  export const create = (message: string): Exception => new BaseError({ type, code, message });
+  export const create = (message: string = _message, code: string = name): Exception =>
+    new BaseError({ type, name, code, message });
 
   export const is = makePredicate<Exception>(type);
 }

src/_lib/errors/UnauthorizedError.ts

@@ -3,10 +3,11 @@ import { makePredicate } from '@/_lib/Predicate';
 
 namespace UnauthorizedError {
   const type = Symbol();
-  const code = 'UnauthorizedError';
-  const message = 'Unauthorized';
+  const name = 'UnauthorizedError';
+  const _message = 'Unauthorized';
 
-  export const create = (customMsg?: string): Exception => new BaseError({ type, code, message: customMsg || message });
+  export const create = (message: string = _message, code: string = name): Exception =>
+    new BaseError({ type, name, code, message });
 
   export const is = makePredicate<Exception>(type);
 }

src/_lib/errors/ValidationError.ts

@@ -4,15 +4,15 @@ import { makePredicate } from '@/_lib/Predicate';
 
 namespace ValidationError {
   const type = Symbol();
-  const code = 'ValidationError';
+  const name = 'ValidationError';
 
   type Props = {
     readonly target: string;
     readonly error: Joi.ValidationError;
   };
 
   export const create = ({ error, target }: Props): Exception<Props> =>
-    new BaseError<Props>({ type, code, message: error.message, meta: { target, error } });
+    new BaseError<Props>({ type, name, code: name, message: error.message, meta: { target, error } });
 
   export const is = makePredicate<Exception<Props>>(type);
 }

src/_lib/message/MessageBundle.ts

@@ -3,18 +3,12 @@ import { makePredicate } from '@/_lib/Predicate';
 
 namespace BusinessError {
   const type = Symbol();
-  const code = 'BusinessError';
+  const name = 'BusinessError';
 
-  type Props = {
-    key: string;
-    template: string | null;
-    parameters?: any;
-  };
+  export const create = (message: string, code: string = name): Exception =>
+    new BaseError({ type, name, code, message });
 
-  export const create = ({ key, message, template, parameters }: Props & { message: string }): Exception<Props> =>
-    new BaseError<Props>({ type, code, message, meta: { key, template, parameters } });
-
-  export const is = makePredicate<Exception<Props>>(type);
+  export const is = makePredicate<Exception>(type);
 }
 
 export { BusinessError };

src/_sharedKernel/domain/error/BusinessError.ts

@@ -15,7 +15,8 @@ const errorConverters = [
     return {
       status,
       body: {
-        error: err.code,
+        error: err.name,
+        code: err.code,
         status,
         message: err.message,
         details: err.meta?.error.details.map((detail) => ({
@@ -28,39 +29,44 @@ const errorConverters = [
   errorConverter(BadRequestError.is, (err) => ({
     status: HttpStatus.BAD_REQUEST,
     body: {
-      error: err.code,
+      error: err.name,
+      code: err.code,
       status: HttpStatus.BAD_REQUEST,
       message: err.message,
     },
   })),
   errorConverter(NotFoundError.is, (err) => ({
     status: HttpStatus.NOT_FOUND,
     body: {
-      error: err.code,
+      error: err.name,
+      code: err.code,
       status: HttpStatus.NOT_FOUND,
       message: err.message,
     },
   })),
   errorConverter(UnauthorizedError.is, (err) => ({
     status: HttpStatus.UNAUTHORIZED,
     body: {
-      error: err.code,
+      error: err.name,
+      code: err.code,
       status: HttpStatus.UNAUTHORIZED,
       message: err.message,
     },
   })),
   errorConverter(ForbiddenError.is, (err) => ({
     status: HttpStatus.FORBIDDEN,
     body: {
-      error: err.code,
+      error: err.name,
+      code: err.code,
       status: HttpStatus.FORBIDDEN,
       message: err.message,
     },
   })),
   errorConverter(BusinessError.is, (err) => ({
     status: HttpStatus.CONFLICT,
     body: {
-      error: err.code,
+      error: err.name,
+      code: err.code,
       status: HttpStatus.CONFLICT,
       kind: err.meta?.key,
       message: err.message,
@@ -69,8 +75,14 @@ const errorConverters = [
   errorConverter(
     (err: any | BaseError): err is BaseError => err instanceof BaseError,
     (err) => ({
-      status: HttpStatus.BAD_REQUEST,
-      body: err.message,
+      status: HttpStatus.INTERNAL_SERVER_ERROR,
+      body: {
+        error: err.name,
+        code: err.code,
+        status: HttpStatus.INTERNAL_SERVER_ERROR,
+        meta: err.meta,
+        message: err.message,
+      },
     })
   ),
 ];