Skip to content

Commit 12153e2

Browse files
committed
Fixes for argument parsing
Closes gh-66
1 parent 6f3f167 commit 12153e2

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

bash_kernel/install.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def _is_root():
2929
except AttributeError:
3030
return False # assume not an admin on non-Unix platforms
3131

32-
def main(argv=[]):
32+
def main(argv=None):
3333
parser = argparse.ArgumentParser(
3434
description='Install KernelSpec for Bash Kernel'
3535
)
@@ -38,7 +38,7 @@ def main(argv=[]):
3838
prefix_locations.add_argument(
3939
'--user',
4040
help='Install KernelSpec in user homedirectory',
41-
action='store_false' if _is_root() else 'store_true'
41+
action='store_true'
4242
)
4343
prefix_locations.add_argument(
4444
'--sys-prefix',
@@ -52,19 +52,18 @@ def main(argv=[]):
5252
default=None
5353
)
5454

55-
args = parser.parse_args()
55+
args = parser.parse_args(argv)
5656

57+
user = False
58+
prefix = None
5759
if args.sys_prefix:
5860
prefix = sys.prefix
59-
user = None
60-
elif args.user:
61-
prefix = None
62-
user = True
63-
else:
61+
elif args.prefix:
6462
prefix = args.prefix
65-
user = None
63+
elif args.user or not _is_root():
64+
user = True
6665

6766
install_my_kernel_spec(user=user, prefix=prefix)
6867

6968
if __name__ == '__main__':
70-
main(argv=sys.argv)
69+
main()

0 commit comments

Comments
 (0)