Skip to content

Commit 86794df

Browse files
andrejsandrejs
committed
Replaced span buttons to real buttons. Span buttons caused "select flicker" (at least in Chrome) when pressing them fast multiple times in a row.
1 parent 94230e4 commit 86794df

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

‎js/jquery.fn.gantt.js‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -762,25 +762,25 @@
762762
ganttNavigate = $('<div class="navigate" />')
763763
.append($('<div class="nav-slider" />')
764764
.append($('<div class="nav-slider-left" />')
765-
.append($('<span role="button" class="nav-link nav-page-back"/>')
765+
.append($('<button type="button" class="nav-link nav-page-back"/>')
766766
.html('&lt;')
767767
.click(function () {
768768
core.navigatePage(element, -1);
769769
}))
770770
.append($('<div class="page-number"/>')
771771
.append($('<span/>')
772772
.html(element.pageNum + 1 + ' of ' + element.pageCount)))
773-
.append($('<span role="button" class="nav-link nav-page-next"/>')
773+
.append($('<button type="button" class="nav-link nav-page-next"/>')
774774
.html('&gt;')
775775
.click(function () {
776776
core.navigatePage(element, 1);
777777
}))
778-
.append($('<span role="button" class="nav-link nav-now"/>')
778+
.append($('<button type="button" class="nav-link nav-now"/>')
779779
.html('&#9679;')
780780
.click(function () {
781781
core.navigateTo(element, 'now');
782782
}))
783-
.append($('<span role="button" class="nav-link nav-prev-week"/>')
783+
.append($('<button type="button" class="nav-link nav-prev-week"/>')
784784
.html('&lt;&lt;')
785785
.click(function () {
786786
if (settings.scale === 'hours') {
@@ -793,7 +793,7 @@
793793
core.navigateTo(element, tools.getCellSize() * 6);
794794
}
795795
}))
796-
.append($('<span role="button" class="nav-link nav-prev-day"/>')
796+
.append($('<button type="button" class="nav-link nav-prev-day"/>')
797797
.html('&lt;')
798798
.click(function () {
799799
if (settings.scale === 'hours') {
@@ -825,7 +825,7 @@
825825
)
826826
)
827827
.append($('<div class="nav-slider-right" />')
828-
.append($('<span role="button" class="nav-link nav-next-day"/>')
828+
.append($('<button type="button" class="nav-link nav-next-day"/>')
829829
.html('&gt;')
830830
.click(function () {
831831
if (settings.scale === 'hours') {
@@ -838,7 +838,7 @@
838838
core.navigateTo(element, tools.getCellSize() * -3);
839839
}
840840
}))
841-
.append($('<span role="button" class="nav-link nav-next-week"/>')
841+
.append($('<button type="button" class="nav-link nav-next-week"/>')
842842
.html('&gt;&gt;')
843843
.click(function () {
844844
if (settings.scale === 'hours') {
@@ -851,12 +851,12 @@
851851
core.navigateTo(element, tools.getCellSize() * -6);
852852
}
853853
}))
854-
.append($('<span role="button" class="nav-link nav-zoomIn"/>')
854+
.append($('<button type="button" class="nav-link nav-zoomIn"/>')
855855
.html('&#43;')
856856
.click(function () {
857857
core.zoomInOut(element, -1);
858858
}))
859-
.append($('<span role="button" class="nav-link nav-zoomOut"/>')
859+
.append($('<button type="button" class="nav-link nav-zoomOut"/>')
860860
.html('&#45;')
861861
.click(function () {
862862
core.zoomInOut(element, 1);
@@ -869,60 +869,60 @@
869869
// Button navigation is provided by setting `settings.navigation='buttons'`
870870
} else {
871871
ganttNavigate = $('<div class="navigate" />')
872-
.append($('<span role="button" class="nav-link nav-page-back"/>')
872+
.append($('<button type="button" class="nav-link nav-page-back"/>')
873873
.html('&lt;')
874874
.click(function () {
875875
core.navigatePage(element, -1);
876876
}))
877877
.append($('<div class="page-number"/>')
878878
.append($('<span/>')
879879
.html(element.pageNum + 1 + ' of ' + element.pageCount)))
880-
.append($('<span role="button" class="nav-link nav-page-next"/>')
880+
.append($('<button type="button" class="nav-link nav-page-next"/>')
881881
.html('&gt;')
882882
.click(function () {
883883
core.navigatePage(element, 1);
884884
}))
885-
.append($('<span role="button" class="nav-link nav-begin"/>')
885+
.append($('<button type="button" class="nav-link nav-begin"/>')
886886
.html('&#124;&lt;')
887887
.click(function () {
888888
core.navigateTo(element, 'begin');
889889
}))
890-
.append($('<span role="button" class="nav-link nav-prev-week"/>')
890+
.append($('<button type="button" class="nav-link nav-prev-week"/>')
891891
.html('&lt;&lt;')
892892
.click(function () {
893893
core.navigateTo(element, tools.getCellSize() * 7);
894894
}))
895-
.append($('<span role="button" class="nav-link nav-prev-day"/>')
895+
.append($('<button type="button" class="nav-link nav-prev-day"/>')
896896
.html('&lt;')
897897
.click(function () {
898898
core.navigateTo(element, tools.getCellSize());
899899
}))
900-
.append($('<span role="button" class="nav-link nav-now"/>')
900+
.append($('<button type="button" class="nav-link nav-now"/>')
901901
.html('&#9679;')
902902
.click(function () {
903903
core.navigateTo(element, 'now');
904904
}))
905-
.append($('<span role="button" class="nav-link nav-next-day"/>')
905+
.append($('<button type="button" class="nav-link nav-next-day"/>')
906906
.html('&gt;')
907907
.click(function () {
908908
core.navigateTo(element, tools.getCellSize() * -1);
909909
}))
910-
.append($('<span role="button" class="nav-link nav-next-week"/>')
910+
.append($('<button type="button" class="nav-link nav-next-week"/>')
911911
.html('&gt;&gt;')
912912
.click(function () {
913913
core.navigateTo(element, tools.getCellSize() * -7);
914914
}))
915-
.append($('<span role="button" class="nav-link nav-end"/>')
915+
.append($('<button type="button" class="nav-link nav-end"/>')
916916
.html('&gt;&#124;')
917917
.click(function () {
918918
core.navigateTo(element, 'end');
919919
}))
920-
.append($('<span role="button" class="nav-link nav-zoomIn"/>')
920+
.append($('<button type="button" class="nav-link nav-zoomIn"/>')
921921
.html('&#43;')
922922
.click(function () {
923923
core.zoomInOut(element, -1);
924924
}))
925-
.append($('<span role="button" class="nav-link nav-zoomOut"/>')
925+
.append($('<button type="button" class="nav-link nav-zoomOut"/>')
926926
.html('&#45;')
927927
.click(function () {
928928
core.zoomInOut(element, 1);

0 commit comments

Comments
 (0)