Skip to content

Commit 2e4119b

Browse files
committed
Use already imported Event variants instead of prefixing them by Event::
1 parent 46b096b commit 2e4119b

File tree

2 files changed

+15
-22
lines changed

2 files changed

+15
-22
lines changed

tests/test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ fn fuzz_53() {
122122
let mut buf = vec![];
123123
loop {
124124
match reader.read_event_into(&mut buf) {
125-
Ok(quick_xml::events::Event::Eof) | Err(..) => break,
125+
Ok(Eof) | Err(..) => break,
126126
_ => buf.clear(),
127127
}
128128
}
@@ -138,7 +138,7 @@ fn test_issue94() {
138138
let mut buf = vec![];
139139
loop {
140140
match reader.read_event_into(&mut buf) {
141-
Ok(quick_xml::events::Event::Eof) | Err(..) => break,
141+
Ok(Eof) | Err(..) => break,
142142
_ => buf.clear(),
143143
}
144144
buf.clear();

tests/unit_tests.rs

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ use std::io::Cursor;
33
use std::str::from_utf8;
44

55
use quick_xml::events::attributes::{AttrError, Attribute};
6-
use quick_xml::events::{BytesDecl, BytesEnd, BytesStart, BytesText, Event};
6+
use quick_xml::events::Event::*;
7+
use quick_xml::events::{BytesDecl, BytesEnd, BytesStart, BytesText};
78
use quick_xml::name::QName;
8-
use quick_xml::{events::Event::*, Reader, Result, Writer};
9+
use quick_xml::{Reader, Result, Writer};
910

1011
use pretty_assertions::assert_eq;
1112

@@ -621,7 +622,7 @@ fn test_read_write_roundtrip_escape() -> Result<()> {
621622
Text(e) => {
622623
let t = e.escaped();
623624
assert!(writer
624-
.write_event(Event::Text(BytesText::from_escaped(t.to_vec())))
625+
.write_event(Text(BytesText::from_escaped(t.to_vec())))
625626
.is_ok());
626627
}
627628
e => assert!(writer.write_event(e).is_ok()),
@@ -654,7 +655,7 @@ fn test_read_write_roundtrip_escape_text() -> Result<()> {
654655
Text(e) => {
655656
let t = e.unescape_and_decode(&reader).unwrap();
656657
assert!(writer
657-
.write_event(Event::Text(BytesText::from_plain_str(&t)))
658+
.write_event(Text(BytesText::from_plain_str(&t)))
658659
.is_ok());
659660
}
660661
e => assert!(writer.write_event(e).is_ok()),
@@ -799,10 +800,8 @@ mod decode_with_bom_removal {
799800

800801
loop {
801802
match reader.read_event_into(&mut buf) {
802-
Ok(Event::StartText(e)) => {
803-
txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap())
804-
}
805-
Ok(Event::Eof) => break,
803+
Ok(StartText(e)) => txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap()),
804+
Ok(Eof) => break,
806805
_ => (),
807806
}
808807
}
@@ -825,10 +824,8 @@ mod decode_with_bom_removal {
825824

826825
loop {
827826
match reader.read_event_into(&mut buf) {
828-
Ok(Event::StartText(e)) => {
829-
txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap())
830-
}
831-
Ok(Event::Eof) => break,
827+
Ok(StartText(e)) => txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap()),
828+
Ok(Eof) => break,
832829
_ => (),
833830
}
834831
}
@@ -846,10 +843,8 @@ mod decode_with_bom_removal {
846843

847844
loop {
848845
match reader.read_event_into(&mut buf) {
849-
Ok(Event::StartText(e)) => {
850-
txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap())
851-
}
852-
Ok(Event::Eof) => break,
846+
Ok(StartText(e)) => txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap()),
847+
Ok(Eof) => break,
853848
_ => (),
854849
}
855850
}
@@ -869,10 +864,8 @@ mod decode_with_bom_removal {
869864

870865
loop {
871866
match reader.read_event_into(&mut buf) {
872-
Ok(Event::StartText(e)) => {
873-
txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap())
874-
}
875-
Ok(Event::Eof) => break,
867+
Ok(StartText(e)) => txt.push(e.decode_with_bom_removal(reader.decoder()).unwrap()),
868+
Ok(Eof) => break,
876869
_ => (),
877870
}
878871
}

0 commit comments

Comments
 (0)