Officially require Emacs 25.3.

This change updates the startup check to reject versions older than 25.3
instead of 24.3 and documents the change.

Also removes some backward-compatibility code that was necessary to run
the test under Emacs 24..

Author: szermatt

README.md

@@ -132,8 +132,8 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for more details.
 
 ## COMPATIBILITY
 
-bash-completion.el is known to work with Bash 3, 4 and 5, on Emacs,
-starting with version 24.3, under Linux and OSX. It does not work on
+bash-completion.el is known to work with Bash 4 and 5, on Emacs,
+starting with version 25.3, under Linux and OSX. It does not work on
 XEmacs.
 
 [new_issue]: https://github.com/szermatt/emacs-bash-completion/issues/new

bash-completion.el

@@ -7,7 +7,7 @@
 ;; Version: 3.1.0
 ;; Keywords: convenience, unix
 ;; URL: http://github.com/szermatt/emacs-bash-completion
-;; Package-Requires: ((emacs "24.3"))
+;; Package-Requires: ((emacs "25.3"))
 
 ;; This program is free software: you can redistribute it and/or
 ;; modify it under the terms of the GNU General Public License as
@@ -99,8 +99,8 @@
 
 ;;; Compatibility:
 
-;; bash-completion.el is known to work with Bash 3, 4 and 5, on Emacs,
-;; starting with version 24.3, under Linux and OSX. It does not work
+;; bash-completion.el is known to work with Bash 4 and 5, on Emacs,
+;; starting with version 25.3, under Linux and OSX. It does not work
 ;; on XEmacs.
 
 ;;; History:
@@ -274,13 +274,13 @@ Bash processes.")
   "Value for the special PS1 prompt set for completions, quoted.")
 
 (eval-when-compile
-  (unless (or (and (= emacs-major-version 24) (>= emacs-minor-version 3))
-              (>= emacs-major-version 25))
+  (unless (or (and (= emacs-major-version 25) (>= emacs-minor-version 3))
+              (>= emacs-major-version 26))
     (error
      (concat
-      "Emacs version 24.3 or later is required to run emacs-bash-completion.\n"
-      "Download emacs-bash-completion version 2.1 to run on older Emacs "
-      "versions, from 22 to 24."))))
+      "Emacs version 25.3 or later is required to run emacs-bash-completion.\n"
+      "Download emacs-bash-completion version 2.1 to run on Emacs 22 and 23"
+      "version 3.1.0 to run on Emacs 24."))))
 
 (defvar bash-completion--debug-info nil
   "Alist that stores info about the last call to `bash-completion-send'.

test/bash-completion-integration-test.el

@@ -182,9 +182,7 @@ for testing completion."
 (defun bash-completion_test-teardown-env (test-env-dir)
   "Deletes everything `bash-completion_test-setup-env' set up."
   (when test-env-dir
-    (if (>= emacs-major-version 24)
-        (delete-directory test-env-dir 'recursive)
-      (dired-delete-file test-env-dir 'always))))
+    (delete-directory test-env-dir 'recursive)))
 
 (defun bash-completion_test-equal-any-order (expected actual)
   "Compare a sorted list of string EXPECTED with ACTUAL.

test/bash-completion-test.el

@@ -32,9 +32,6 @@
 (require 'cl-lib)
 (require 'ert)
 
-; for Emacs 24.1
-(unless (fboundp 'cl-letf) (defalias 'cl-letf 'letf))
-
 (defmacro bash-completion-test-with-buffer (content &rest body)
   "Create a temporary buffer with CONTENT and execute BODY.