Added additional tools, updated components, docs.

Author: dmitriy

.circleci/config.yml

@@ -37,6 +37,26 @@ jobs:
             make ecs
             make phpcs
 
+      - run:
+          name: Run PHP copy/paste detector
+          command: |
+            make phpcpd
+
+      - run:
+          name: Run PHP mess detector
+          command: |
+            make phpmd
+
+      - run:
+          name: Run PHPStan static analysis tool
+          command: |
+            make phpstan
+
+      - run:
+          name: Run Phpinsights PHP quality checks
+          command: |
+            make phpinsights
+
       - store_artifacts:
           path: reports
 

.github/workflows/ci.yml

@@ -34,9 +34,17 @@ jobs:
               run: make messenger-setup-transports
             - name: Run test suite
               run: make phpunit
-            - name: Run coding standard
+            - name: Run PHP coding standard
               run: make ecs
-            - name: Run codeSniffer
+            - name: Run PHP codeSniffer
               run: make phpcs
+            - name: Run PHP copy/paste detector
+              run: make phpcpd
+            - name: Run PHP mess detector
+              run: make phpmd
+            - name: Run PHPStan static analysis tool
+              run: make phpstan
+            - name: Run Phpinsights PHP quality checks
+              run: make phpinsights
             - name: Stop the docker images
               run: make stop-test

.gitlab-ci.yml

@@ -33,6 +33,10 @@ build:
     - make phpunit
     - make ecs
     - make phpcs
+    - make phpcpd
+    - make phpmd
+    - make phpstan
+    - make phpinsights
     - make stop-test
   artifacts:
     paths:

.php_cs.dist

@@ -0,0 +1,8 @@
+<?php
+
+return PhpCsFixer\Config::create()
+    ->setRules([
+        '@Symfony' => true,
+        'array_syntax' => ['syntax' => 'short'],
+    ])
+;

Makefile

@@ -147,15 +147,15 @@ report-code-coverage: ## update code coverage on coveralls.io. Note: COVERALLS_R
 
 ###> phpcs ###
 phpcs: ## Run PHP CodeSniffer
-	@make exec-bash cmd="./vendor/bin/phpcs --version && ./vendor/bin/phpcs --standard=PSR2 --colors -p src"
+	@make exec-bash cmd="./vendor/bin/phpcs --version && ./vendor/bin/phpcs --standard=PSR2 --colors -p src tests"
 ###< phpcs ###
 
 ###> ecs ###
 ecs: ## Run Easy Coding Standard
-	@make exec-bash cmd="error_reporting=0 ./vendor/bin/ecs --clear-cache check src"
+	@make exec-bash cmd="./vendor/bin/ecs --version && ./vendor/bin/ecs --clear-cache check src tests"
 
 ecs-fix: ## Run The Easy Coding Standard to fix issues
-	@make exec-bash cmd="error_reporting=0 ./vendor/bin/ecs --clear-cache --fix check src"
+	@make exec-bash cmd="./vendor/bin/ecs --version && ./vendor/bin/ecs --clear-cache --fix check src tests"
 ###< ecs ###
 
 ###> phpmetrics ###
@@ -172,3 +172,27 @@ phpmetrics-process: ## Generates PhpMetrics static analysis, should be run insid
 	@php ./vendor/bin/phpmetrics --version
 	@./vendor/bin/phpmetrics --junit=reports/junit.xml --report-html=reports/phpmetrics .
 ###< phpmetrics ###
+
+###> php copy/paste detector ###
+phpcpd:
+	@make exec cmd="php phpcpd.phar --fuzzy src tests"
+###< php copy/paste detector ###
+
+###> php mess detector ###
+phpmd:
+	@make exec cmd="php ./vendor/bin/phpmd src text phpmd_ruleset.xml --suffixes php --exclude *src/Migrations/*"
+###< php mess detector ###
+
+###> PHPStan static analysis tool ###
+phpstan:
+	@echo "\033[32mRunning PHPStan - PHP Static Analysis Tool\033[39m"
+	@make exec cmd="bin/console cache:clear --env=test"
+	@make exec cmd="./vendor/bin/phpstan --version"
+	@make exec cmd="./vendor/bin/phpstan analyze src tests"
+###< PHPStan static analysis tool ###
+
+###> Phpinsights PHP quality checks ###
+phpinsights:
+	@echo "\033[32mRunning PHP Insights\033[39m"
+	@make exec cmd="php -d error_reporting=0 ./vendor/bin/phpinsights analyse --no-interaction --min-quality=100 --min-complexity=85 --min-architecture=100 --min-style=100"
+###< Phpinsights PHP quality checks ###

bin/console

@@ -5,30 +5,33 @@ declare(strict_types = 1);
 use App\Kernel;
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Input\ArgvInput;
+use Symfony\Component\Dotenv\Dotenv;
 use Symfony\Component\ErrorHandler\Debug;
 
+set_time_limit(0);
+
 if (!in_array(PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {
-    echo 'Warning: The console should be invoked via the CLI version of PHP, not the '.PHP_SAPI.' SAPI'.PHP_EOL;
+    echo 'Warning: The console should be invoked via the CLI version of PHP, not the ' . PHP_SAPI . ' SAPI' . PHP_EOL;
 }
 
-set_time_limit(0);
-
-require dirname(__DIR__).'/vendor/autoload.php';
+require dirname(__DIR__) . '/vendor/autoload.php';
 
-if (!class_exists(Application::class)) {
-    throw new LogicException('You need to add "symfony/framework-bundle" as a Composer dependency.');
+if (!class_exists(Application::class) || !class_exists(Dotenv::class)) {
+    throw new LogicException('You need to add "symfony/framework-bundle" and "symfony/dotenv" as Composer dependencies.');
 }
 
 $input = new ArgvInput();
-if (null !== $env = $input->getParameterOption(['--env', '-e'], null, true)) {
-    putenv('APP_ENV='.$_SERVER['APP_ENV'] = $_ENV['APP_ENV'] = $env);
+$env = $input->getParameterOption(['--env', '-e'], null, true);
+
+if ($env) {
+    putenv('APP_ENV=' . $_SERVER['APP_ENV'] = $_ENV['APP_ENV'] = $env);
 }
 
 if ($input->hasParameterOption('--no-debug', true)) {
-    putenv('APP_DEBUG='.$_SERVER['APP_DEBUG'] = $_ENV['APP_DEBUG'] = '0');
+    putenv('APP_DEBUG=' . $_SERVER['APP_DEBUG'] = $_ENV['APP_DEBUG'] = '0');
 }
 
-require dirname(__DIR__).'/config/bootstrap.php';
+require dirname(__DIR__) . '/config/bootstrap.php';
 
 if ($_SERVER['APP_DEBUG']) {
     umask(0000);
@@ -38,6 +41,7 @@ if ($_SERVER['APP_DEBUG']) {
     }
 }
 
-$kernel = new Kernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
-$application = new Application($kernel);
-$application->run($input);
+$kernel = new Kernel($_SERVER['APP_ENV'], (bool)$_SERVER['APP_DEBUG']);
+
+/** @noinspection PhpUnhandledExceptionInspection */
+(new Application($kernel))->run($input);

bitbucket-pipelines.yml

@@ -19,4 +19,8 @@ pipelines:
           - make phpunit
           - make ecs
           - make phpcs
+          - make phpcpd
+          - make phpmd
+          - make phpstan
+          - make phpinsights
           - make stop-test

composer.json

@@ -31,11 +31,10 @@
 		"ext-mbstring": "*",
 		"ext-pdo": "*",
 		"ext-pdo_mysql": "*",
-		"doctrine/doctrine-migrations-bundle": "^2.2",
+		"doctrine/doctrine-migrations-bundle": "^3.0",
 		"easycorp/easy-log-handler": "1.0.*",
-		"jmose/command-scheduler-bundle": "^2.2",
-		"sensio/framework-extra-bundle": "^5.5",
-		"sensiolabs/security-checker": "^6.0",
+		"jmose/command-scheduler-bundle": "^3.0",
+		"sensio/framework-extra-bundle": "^5.6",
 		"symfony/apache-pack": "^1.0",
 		"symfony/asset": "4.4.*",
 		"symfony/config": "4.4.*",
@@ -49,7 +48,7 @@
 		"symfony/intl": "4.4.*",
 		"symfony/mailer": "4.4.*",
 		"symfony/messenger": "4.4.*",
-		"symfony/monolog-bundle": "^3.5",
+		"symfony/monolog-bundle": "^3.6",
 		"symfony/orm-pack": "*",
 		"symfony/process": "4.4.*",
 		"symfony/routing": "4.4.*",
@@ -76,11 +75,14 @@
 	"require-dev": {
 		"bamarni/composer-bin-plugin": "^1.4",
 		"doctrine/doctrine-fixtures-bundle": "^3.3",
-		"ergebnis/composer-normalize": "^2.6",
+		"ergebnis/composer-normalize": "^2.9",
 		"roave/security-advisories": "dev-master",
-		"symfony/debug-pack": "*",
-		"symfony/maker-bundle": "^1.20",
-		"symfony/requirements-checker": "^1.1"
+		"sensiolabs/security-checker": "^6.0",
+		"symfony/debug-bundle": "4.4.*",
+		"symfony/maker-bundle": "^1.22",
+		"symfony/requirements-checker": "^2.0",
+		"symfony/var-dumper": "4.4.*",
+		"symfony/web-profiler-bundle": "4.4.*"
 	},
 	"config": {
 		"platform": {
@@ -108,28 +110,33 @@
 	"autoload-dev": {
 		"psr-4": {
 			"App\\Tests\\": "tests/",
-			"PHPUnit\\": "tools/01_phpunit/vendor/phpunit/phpunit/src/",
+			"PHPUnit\\": "tools/01_phpunit/vendor/phpunit/phpunit/src",
 			"Symfony\\Component\\BrowserKit\\": "tools/01_phpunit/vendor/symfony/browser-kit",
-			"Symfony\\Bridge\\PhpUnit\\": "tools/01_phpunit/vendor/symfony/phpunit-bridge"
+			"Symfony\\Bridge\\PhpUnit\\": "tools/01_phpunit/vendor/symfony/phpunit-bridge",
+			"PHPMD\\": "tools/06_phpmd/vendor/phpmd/phpmd/src/bin",
+			"PhpCsFixer\\": "tools/03_ecs/vendor/friendsofphp/php-cs-fixer/src",
+			"SlevomatCodingStandard\\": "tools/03_ecs/vendor/slevomat/coding-standard/SlevomatCodingStandard",
+			"Symplify\\CodingStandard\\": "tools/03_ecs/vendor/symplify/coding-standard/src"
 		}
 	},
 	"prefer-stable": true,
 	"scripts": {
 		"post-install-cmd": [
 			"if test -d vendor/symfony/requirements-checker; then ./vendor/bin/requirements-checker; fi",
+			"if test -d vendor/sensiolabs/security-checker; then ./vendor/bin/security-checker security:check; fi",
 			"if test -d vendor/bamarni/composer-bin-plugin; then composer bin all install; fi",
 			"@auto-scripts"
 		],
 		"post-update-cmd": [
 			"if test -d vendor/symfony/requirements-checker; then ./vendor/bin/requirements-checker; fi",
+			"if test -d vendor/sensiolabs/security-checker; then ./vendor/bin/security-checker security:check; fi",
 			"if test -d vendor/bamarni/composer-bin-plugin; then composer bin all update; fi",
 			"@auto-scripts"
 		],
 		"auto-scripts": {
 			"cache:clear": "symfony-cmd",
 			"cache:warmup": "symfony-cmd",
-			"assets:install %PUBLIC_DIR%": "symfony-cmd",
-			"security-checker security:check": "script"
+			"assets:install %PUBLIC_DIR%": "symfony-cmd"
 		}
 	},
 	"support": {