Merge pull request #4 from rota1001/fix-producer-stopping-condition

jserv · web-flow · commit 3b8529980996 · 2025-03-27T00:41:25.000+08:00
Fix incorrect open count check in release function
diff --git a/simrupt.c b/simrupt.c
@@ -298,7 +298,7 @@ static int simrupt_open(struct inode *inode, struct file *filp)
 static int simrupt_release(struct inode *inode, struct file *filp)
 {
     pr_debug("simrupt: %s\n", __func__);
-    if (atomic_dec_and_test(&open_cnt) == 0) {
+    if (atomic_dec_and_test(&open_cnt)) {
         del_timer_sync(&timer);
         flush_workqueue(simrupt_workqueue);
         fast_buf_clear();

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ static int simrupt_open(struct inode inode, struct file filp)`
`298`	`298`	`static int simrupt_release(struct inode inode, struct file filp)`
`299`	`299`	`{`
`300`	`300`	`pr_debug("simrupt: %s\n", __func__);`
`301`		`- if (atomic_dec_and_test(&open_cnt) == 0) {`
	`301`	`+ if (atomic_dec_and_test(&open_cnt)) {`
`302`	`302`	`del_timer_sync(&timer);`
`303`	`303`	`flush_workqueue(simrupt_workqueue);`
`304`	`304`	`fast_buf_clear();`