AGP 8.10.0

Author: syslogic

README.md

@@ -25,7 +25,7 @@ Only GitHub traffic is being permitted, see [`network_security_config.xml`](mobi
 
 The [`:library`](library/src/main/java/io/syslogic/github/api) module is available on JitPack; either by version tag or `master-SNAPSHOT`.<br/>
 It provides the relevant GitHub API calls & data-models with data-binding annotations.<br/>
-The JitPack repository URL would be: `maven { url 'https://jitpack.io' }`
+The JitPack repository URL would be: `maven { url = uri("https://jitpack.io") }`
 
     dependencies {
         // implementation "io.syslogic:androidx-github:master-SNAPSHOT"

gradle.properties

@@ -9,5 +9,3 @@ org.gradle.welcome=never
 
 android.useAndroidX=true
 android.enableJetifier=false
-
-android.suppressUnsupportedCompileSdk=35

gradle/libs.versions.toml

@@ -1,30 +1,30 @@
 [versions]
 app_version_code             = '4'
-app_version_name             = '1.0.4'
-android_build_tools          = '35.0.0'
-android_compile_sdk          = '35'
-android_target_sdk           = '35'
+app_version_name             = '1.0.5'
+android_build_tools          = '36.0.0'
+android_compile_sdk          = '36'
+android_target_sdk           = '36'
 android_min_sdk              = '22'
 
 # Gradle Plugins
-android_gradle_plugin        = '8.9.0'
-kotlin                       = '2.0.21'
+android_gradle_plugin        = '8.10.0'
+kotlin                       = '2.1.20'
 material_design              = '1.12.0'
 retrofit                     = '2.11.0'
-gson                         = '2.11.0'
+gson                         = '2.12.1'
 junit                        = '4.13.2'
 flexbox                      = '3.0.0'
 # Note: DirCacheCheckout.java uses InputStream.transferTo() since jgit 6.3; no such method on Android.
 jgit                         = '6.2.0.202206071550-r'
 slf4j                        = '2.0.16'
 androidx_appcompat           = '1.7.0'
 androidx_annotation          = '1.9.1'
-androidx_navigation          = '2.8.9'
+androidx_navigation          = '2.9.0'
 androidx_fragment            = '1.8.6'
 androidx_recyclerview        = '1.4.0'
 androidx_cardview            = '1.0.0'
 androidx_preference          = '1.2.1'
-androidx_room                = '2.6.1'
+androidx_room                = '2.7.1'
 androidx_splashscreen        = '1.0.1'
 androidx_test_junit          = '1.2.1'
 androidx_test_core           = '1.6.1'

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 #Mon May 15 03:22:49 CEST 2023
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

library/build.gradle

@@ -4,6 +4,9 @@ plugins {
     id 'maven-publish'
 }
 
+group = 'io.syslogic'
+version = libs.versions.app.version.name.get()
+
 base {
     String versionName = libs.versions.app.version.name.get()
     archivesName = "androidx_github_$versionName"
@@ -28,8 +31,8 @@ android {
     }
 
     compileOptions {
-        sourceCompatibility JavaVersion.VERSION_17
-        targetCompatibility JavaVersion.VERSION_17
+        sourceCompatibility = JavaVersion.VERSION_17
+        targetCompatibility = JavaVersion.VERSION_17
     }
 
     buildFeatures {
@@ -67,31 +70,31 @@ android {
 dependencies {
 
     // Material Design Components
-    implementation libs.material.design
+    implementation(libs.material.design)
 
     // Annotations
-    implementation libs.androidx.annotation
+    implementation(libs.androidx.annotation)
 
     // App Compat
-    implementation libs.androidx.appcompat
+    implementation(libs.androidx.appcompat)
 
     // Data-Binding Runtime
-    implementation libs.androidx.databinding
+    implementation(libs.androidx.databinding)
 
     // Room Runtime
-    annotationProcessor libs.androidx.room.compiler
-    testImplementation libs.androidx.room.testing
-    implementation libs.androidx.room.runtime
+    annotationProcessor(libs.androidx.room.compiler)
+    testImplementation(libs.androidx.room.testing)
+    implementation(libs.androidx.room.runtime)
 
     // Retrofit2
-    implementation libs.gson
-    implementation libs.retrofit
-    implementation (libs.retrofit.gson.converter) {
-        exclude group: "com.google.code.gson", module: "gson"
+    implementation(libs.gson)
+    implementation(libs.retrofit)
+    implementation(libs.retrofit.gson.converter) {
+        exclude(group: "com.google.code.gson", module: "gson")
     }
 
-    testImplementation libs.junit
-    androidTestImplementation libs.androidx.test.junit
+    testImplementation(libs.junit)
+    androidTestImplementation(libs.androidx.test.junit)
 }
 
 tasks.register('javadoc', Javadoc) {
@@ -105,7 +108,7 @@ tasks.register('javadoc', Javadoc) {
     android.getBootClasspath().forEach{ classpath += fileTree(it) }
     classpath += fileTree(dir: project.file("build/tmp/aarsToJars/").absolutePath)
     classpath += configurations.implementation
-    exclude "**/BuildConfig.java", "**/R.java", "**/*.kt"
+    exclude("**/BuildConfig.java", "**/R.java", "**/*.kt")
     failOnError = false
 
     // options.verbose()
@@ -116,6 +119,10 @@ tasks.register('javadoc', Javadoc) {
     options.linkSource true
     options.author true
 
+    onlyIf {
+        project.file("build/intermediates/aar_main_jar").exists()
+    }
+
     doFirst {
 
         // extract AAR files
@@ -141,33 +148,26 @@ tasks.register('javadoc', Javadoc) {
     }
     doLast {
         // delete temporary directory.
-        delete project.fileTree('build/tmp7aarsToJars')
+        delete project.fileTree("build/tmp/aarsToJars")
     }
 }
 
-javadoc.onlyIf {
-    project.file("build/intermediates/aar_main_jar").exists()
-}
-
-tasks.register('javadocJar', Jar) {
-    dependsOn javadoc
-    archiveClassifier.set('javadoc')
-    from javadoc.destinationDir
+tasks.register("javadocJar", Jar) {
+    dependsOn(javadoc)
+    archiveClassifier.set("javadoc")
+    from(javadoc.destinationDir)
 }
 
 tasks.register('sourcesJar', Jar) {
-    from android.sourceSets.main.java.srcDirs
+    from(android.sourceSets.main.java.srcDirs)
     archiveClassifier.set('sources')
 }
 
 artifacts {
-    archives javadocJar
-    archives sourcesJar
+    archives(javadocJar)
+    archives(sourcesJar)
 }
 
-group = 'io.syslogic'
-version = libs.versions.app.version.name.get()
-
 afterEvaluate {
     publishing {
         publications {

mobile/src/main/java/io/syslogic/github/recyclerview/QueryStringsAdapter.java

@@ -23,6 +23,7 @@
 import io.syslogic.github.activity.BaseActivity;
 import io.syslogic.github.api.model.QueryString;
 import io.syslogic.github.api.room.Abstraction;
+import io.syslogic.github.api.room.QueryStringsDao;
 import io.syslogic.github.databinding.CardviewQueryStringBinding;
 
 /**
@@ -40,19 +41,15 @@ public class QueryStringsAdapter extends RecyclerView.Adapter<RecyclerView.ViewH
     /** Debug Output */
     static final boolean mDebug = BuildConfig.DEBUG;
 
-    private WeakReference<Context> mContext;
-    private RecyclerView mRecyclerView;
+    private final WeakReference<Context> mContext;
     private List<QueryString> mItems;
 
     public QueryStringsAdapter(@NonNull Context context) {
         this.mContext = new WeakReference<>(context);
-        Abstraction.executorService.execute(() -> mItems = Abstraction.getInstance(getContext()).queryStringsDao().getItems());
-    }
-
-    @Override
-    public void onAttachedToRecyclerView(@NonNull RecyclerView recyclerView) {
-        super.onAttachedToRecyclerView(recyclerView);
-        this.mRecyclerView = recyclerView;
+        Abstraction.executorService.execute(() -> {
+            QueryStringsDao dao = Abstraction.getInstance(getContext()).queryStringsDao();
+            if (dao != null) {mItems = dao.getItems();}
+        });
     }
 
     @NonNull
@@ -98,7 +95,6 @@ protected Context getContext() {
     private static class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {
 
         private final CardviewQueryStringBinding mDataBinding;
-        private QueryStringsLinearView mRecyclerView;
         private CardView cardView;
         private long itemId;
 
@@ -118,9 +114,9 @@ private static class ViewHolder extends RecyclerView.ViewHolder implements View.
 
         @Override
         public void onClick(@NonNull View viewHolder) {
-            this.mRecyclerView = (QueryStringsLinearView) viewHolder.getParent();
+            QueryStringsLinearView mRecyclerView = (QueryStringsLinearView) viewHolder.getParent();
             QueryString item = (QueryString) viewHolder.getTag();
-            BaseActivity activity = (BaseActivity) this.mRecyclerView.getContext();
+            BaseActivity activity = (BaseActivity) mRecyclerView.getContext();
             ViewDataBinding databinding = activity.getFragmentDataBinding();
             if (databinding != null) {
                 Bundle args = new Bundle();
@@ -134,6 +130,7 @@ public void onClick(@NonNull View viewHolder) {
         public void setId(long value) {
             this.itemId = value;
         }
+
         void setCardView(CardView view) {
             this.cardView = view;
         }
@@ -142,6 +139,7 @@ void setCardView(CardView view) {
         public long getId() {
             return this.itemId;
         }
+
         CardviewQueryStringBinding getDataBinding() {
             return this.mDataBinding;
         }

settings.gradle renamed to settings.gradle.kts

@@ -6,22 +6,21 @@ pluginManagement {
     }
 }
 
+@Suppress("UnstableApiUsage")
 dependencyResolutionManagement {
     repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
     repositories {
-        maven {
-            url = "https://repo.eclipse.org/content/groups/releases/"
-        }
+        maven { url = uri("https://repo.eclipse.org/content/groups/releases/") }
         mavenCentral()
         google()
     }
 }
 
 rootProject.name = "GitHub Client"
 
-include ":library"
+include(":library")
 
-/* JitPack: exclude module. */
-if (! System.env.JITPACK) {
-    include ":mobile"
+/* JitPack: exclude module `:mobile` */
+if (System.getenv("JITPACK") == null) {
+    include(":mobile")
 }