fix: require bug and sampler bug (#177)

* The object destructured require statements where incorrect
* The sampler looked for objects instead of classes (when creating methods)

Author: dstallenberg

libraries/search-javascript/lib/testbuilding/ContextBuilder.ts

@@ -90,7 +90,7 @@ export class ContextBuilder {
     let variableName = statement.name;
 
     variableName =
-      "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ".includes(
+      "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_".includes(
         variableName[0]
       )
         ? variableName[0].toLowerCase() + variableName.slice(1)

libraries/search-javascript/lib/testbuilding/JavaScriptDecoder.ts

@@ -101,7 +101,12 @@ export class JavaScriptDecoder implements Decoder<JavaScriptTestCase, string> {
 
     if (requires.length > 0) {
       beforeEachLines = [
-        ...requires.map((m) => `\tlet ${m.left};`),
+        ...requires.map(
+          (m) =>
+            `\tlet ${(m.left.includes(":") ? m.left.split(":")[1] : m.left)
+              .replace("{", "")
+              .replace("}", "")};`
+        ),
         `\tbeforeEach(() => {`,
         "\t\t// This is a hack to force the require cache to be emptied",
         "\t\t// Without this we would be using the same required object for each test",
@@ -112,7 +117,7 @@ export class JavaScriptDecoder implements Decoder<JavaScriptTestCase, string> {
               "require.resolve"
             )}];`
         ),
-        ...requires.map((m) => `\t\t${m.left} = ${m.right}`),
+        ...requires.map((m) => `\t\t(${m.left} = ${m.right});`),
         `\t});`,
         "",
       ];
@@ -125,7 +130,7 @@ export class JavaScriptDecoder implements Decoder<JavaScriptTestCase, string> {
       `describe('${targetName}', function() {`,
       ...beforeEachLines,
       ...tests.flatMap((testLines: string[], index) => [
-        `\tit("Test ${index} for '${targetName}'", async () => {`,
+        `\tit("Test ${index + 1} for '${targetName}'", async () => {`,
         ...testLines.map((line) => `\t\t${line}`),
         index === tests.length - 1 ? "\t})" : "\t})\n",
       ]),

libraries/search-javascript/lib/testcase/sampling/JavaScriptRandomSampler.ts

@@ -325,8 +325,7 @@ export class JavaScriptRandomSampler extends JavaScriptTestCaseSampler {
       .filter((target) =>
         isExported(
           targets.find(
-            (objectTarget) =>
-              objectTarget.id === (<ObjectFunctionTarget>target).objectId
+            (objectTarget) => objectTarget.id === (<MethodTarget>target).classId
           )
         )
       );
@@ -353,8 +352,7 @@ export class JavaScriptRandomSampler extends JavaScriptTestCaseSampler {
       .filter((target) =>
         isExported(
           targets.find(
-            (objectTarget) =>
-              objectTarget.id === (<ObjectFunctionTarget>target).objectId
+            (objectTarget) => objectTarget.id === (<MethodTarget>target).classId
           )
         )
       );
@@ -381,8 +379,7 @@ export class JavaScriptRandomSampler extends JavaScriptTestCaseSampler {
       .filter((target) =>
         isExported(
           targets.find(
-            (objectTarget) =>
-              objectTarget.id === (<ObjectFunctionTarget>target).objectId
+            (objectTarget) => objectTarget.id === (<MethodTarget>target).classId
           )
         )
       );