Refactor code-style

Author: wooorm

index.js

@@ -48,7 +48,7 @@
  * @returns {node is Y}
  */
 
-export var is =
+export const is =
   /**
    * Check if a node passes a test.
    * When a `parent` node is known the `index` of node should also be given.
@@ -77,7 +77,7 @@ export var is =
      */
     // eslint-disable-next-line max-params
     function is(node, test, index, parent, context) {
-      var check = convert(test)
+      const check = convert(test)
 
       if (
         index !== undefined &&
@@ -111,7 +111,7 @@ export var is =
     }
   )
 
-export var convert =
+export const convert =
   /**
    * @type {(
    *   (<T extends Node>(test: T['type']|Partial<T>|TestFunctionPredicate<T>) => AssertPredicate<T>) &
@@ -139,8 +139,7 @@ export var convert =
       }
 
       if (typeof test === 'object') {
-        // @ts-ignore looks like a list of tests / partial test object.
-        return 'length' in test ? anyFactory(test) : propsFactory(test)
+        return Array.isArray(test) ? anyFactory(test) : propsFactory(test)
       }
 
       if (typeof test === 'function') {
@@ -156,8 +155,8 @@ export var convert =
  */
 function anyFactory(tests) {
   /** @type {Array.<AssertAnything>} */
-  var checks = []
-  var index = -1
+  const checks = []
+  let index = -1
 
   while (++index < tests.length) {
     checks[index] = convert(tests[index])
@@ -171,7 +170,7 @@ function anyFactory(tests) {
    * @returns {boolean}
    */
   function any(...parameters) {
-    var index = -1
+    let index = -1
 
     while (++index < checks.length) {
       if (checks[index].call(this, ...parameters)) return true
@@ -195,7 +194,7 @@ function propsFactory(check) {
    */
   function all(node) {
     /** @type {string} */
-    var key
+    let key
 
     for (key in check) {
       if (node[key] !== check[key]) return

package.json

@@ -71,12 +71,7 @@
     "trailingComma": "none"
   },
   "xo": {
-    "prettier": true,
-    "rules": {
-      "import/no-mutable-exports": "off",
-      "no-var": "off",
-      "prefer-arrow-callback": "off"
-    }
+    "prettier": true
   },
   "remarkConfig": {
     "plugins": [

readme.md

@@ -26,8 +26,8 @@ npm install unist-util-is
 ```js
 import {is} from 'unist-util-is'
 
-var node = {type: 'strong'}
-var parent = {type: 'paragraph', children: [node]}
+const node = {type: 'strong'}
+const parent = {type: 'paragraph', children: [node]}
 
 function test(node, n) {
   return n === 5

test/main.js

@@ -6,12 +6,12 @@ import {is} from '../index.js'
  * @typedef {import('unist').Parent} Parent
  */
 
-test('unist-util-is', function (t) {
-  var node = {type: 'strong'}
-  var parent = {type: 'paragraph', children: []}
+test('unist-util-is', (t) => {
+  const node = {type: 'strong'}
+  const parent = {type: 'paragraph', children: []}
 
   t.throws(
-    function () {
+    () => {
       // @ts-ignore runtime.
       is(null, false)
     },
@@ -20,23 +20,23 @@ test('unist-util-is', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       is(node, null, -1, parent)
     },
     /Expected positive finite index/,
     'should throw when `index` is invalid (#1)'
   )
 
   t.throws(
-    function () {
+    () => {
       is(node, null, Number.POSITIVE_INFINITY, parent)
     },
     /Expected positive finite index/,
     'should throw when `index` is invalid (#2)'
   )
 
   t.throws(
-    function () {
+    () => {
       // @ts-ignore runtime.
       is(node, null, false, parent)
     },
@@ -45,7 +45,7 @@ test('unist-util-is', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       // @ts-ignore runtime.
       is(node, null, 0, {})
     },
@@ -54,7 +54,7 @@ test('unist-util-is', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       // @ts-ignore runtime.
       is(node, null, 0, {type: 'paragraph'})
     },
@@ -63,15 +63,15 @@ test('unist-util-is', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       is(node, null, 0)
     },
     /Expected both parent and index/,
     'should throw `parent` xor `index` are given (#1)'
   )
 
   t.throws(
-    function () {
+    () => {
       is(node, null, null, parent)
     },
     /Expected both parent and index/,
@@ -89,7 +89,7 @@ test('unist-util-is', function (t) {
   t.ok(is(parent, {type: 'paragraph'}), 'should match partially (#3)')
   t.notok(is(node, {type: 'paragraph'}), 'should match partially (#4)')
 
-  t.test('should accept a test', function (t) {
+  t.test('should accept a test', (t) => {
     /**
      * @param {unknown} _
      * @param {number} n
@@ -106,8 +106,8 @@ test('unist-util-is', function (t) {
     t.end()
   })
 
-  t.test('should invoke test', function (t) {
-    var context = {foo: 'bar'}
+  t.test('should invoke test', (t) => {
+    const context = {foo: 'bar'}
 
     t.plan(4)
 
@@ -130,8 +130,8 @@ test('unist-util-is', function (t) {
   t.ok(is(node, ['strong', 'emphasis']), 'should match arrays (#1)')
   t.notok(is(node, ['b', 'i']), 'should match arrays (#2)')
 
-  t.test('should match arrays (#3)', function (t) {
-    var context = {foo: 'bar'}
+  t.test('should match arrays (#3)', (t) => {
+    const context = {foo: 'bar'}
 
     t.plan(5)
 

test/property.js

@@ -3,7 +3,7 @@ import fc from 'fast-check'
 import lodash from 'lodash'
 import {is} from '../index.js'
 
-var {isObject, isPlainObject, pick, cloneDeep} = lodash
+const {isObject, isPlainObject, pick, cloneDeep} = lodash
 
 test('unist-util-is properties', (t) => {
   t.plan(4)