Refactor code-style

Author: wooorm

index.js

@@ -7,7 +7,7 @@ import gfmTableToMarkdown from 'mdast-util-gfm-table/to-markdown.js'
 import gfmTaskListItemFromMarkdown from 'mdast-util-gfm-task-list-item/from-markdown.js'
 import gfmTaskListItemToMarkdown from 'mdast-util-gfm-task-list-item/to-markdown.js'
 
-var own = {}.hasOwnProperty
+const own = {}.hasOwnProperty
 
 export const gfmFromMarkdown = configure([
   gfmAutolinkLiteralFromMarkdown,
@@ -28,9 +28,9 @@ export function gfmToMarkdown(options) {
 }
 
 function configure(extensions) {
-  var config = {transforms: [], canContainEols: []}
-  var length = extensions.length
-  var index = -1
+  const config = {transforms: [], canContainEols: []}
+  const length = extensions.length
+  let index = -1
 
   while (++index < length) {
     extension(config, extensions[index])
@@ -40,18 +40,20 @@ function configure(extensions) {
 }
 
 function extension(config, extension) {
-  var key
-  var left
-  var right
+  let key
+  let left
+  let right
 
   for (key in extension) {
-    left = own.call(config, key) ? config[key] : (config[key] = {})
-    right = extension[key]
-
-    if (key === 'canContainEols' || key === 'transforms') {
-      config[key] = [].concat(left, right)
-    } else {
-      Object.assign(left, right)
+    if (own.call(extension, key)) {
+      left = own.call(config, key) ? config[key] : (config[key] = {})
+      right = extension[key]
+
+      if (key === 'canContainEols' || key === 'transforms') {
+        config[key] = [].concat(left, right)
+      } else {
+        Object.assign(left, right)
+      }
     }
   }
 }

package.json

@@ -73,13 +73,7 @@
     "trailingComma": "none"
   },
   "xo": {
-    "prettier": true,
-    "rules": {
-      "no-var": "off",
-      "prefer-arrow-callback": "off",
-      "guard-for-in": "off",
-      "unicorn/prefer-optional-catch-binding": "off"
-    }
+    "prettier": true
   },
   "remarkConfig": {
     "plugins": [

test/index.js

@@ -11,46 +11,47 @@ import {gfmFromMarkdown, gfmToMarkdown} from '../index.js'
 
 const spec = JSON.parse(fs.readFileSync(path.join('test', 'spec.json')))
 
-test('markdown -> mdast', function (t) {
+test('markdown -> mdast', (t) => {
   const files = spec.filter(
     (example) => !/disallowed raw html/i.test(example.category)
   )
   let index = -1
 
   while (++index < files.length) {
     const example = files[index]
-    var category = Slugger.slug(example.category)
-    var name = index + '-' + category
-    var fixtureHtmlPath = path.join('test', name + '.html')
-    var fixtureMarkdownPath = path.join('test', name + '.md')
-    var fixtureHtml
-    var fixtureMarkdown
-    var mdast
-    var html
-    var md
-
-    mdast = fromMarkdown(example.input, {
+    const category = Slugger.slug(example.category)
+    const name = index + '-' + category
+    const fixtureHtmlPath = path.join('test', name + '.html')
+    const fixtureMarkdownPath = path.join('test', name + '.md')
+
+    const mdast = fromMarkdown(example.input, {
       extensions: [gfm()],
       mdastExtensions: [gfmFromMarkdown]
     })
 
-    html = toHtml(toHast(mdast, {allowDangerousHtml: true, commonmark: true}), {
-      allowDangerousHtml: true,
-      entities: {useNamedReferences: true},
-      closeSelfClosing: true
-    })
+    const html = toHtml(
+      toHast(mdast, {allowDangerousHtml: true, commonmark: true}),
+      {
+        allowDangerousHtml: true,
+        entities: {useNamedReferences: true},
+        closeSelfClosing: true
+      }
+    )
+
+    let fixtureHtml
+    let fixtureMarkdown
 
     try {
       fixtureHtml = String(fs.readFileSync(fixtureHtmlPath))
-    } catch (_) {
+    } catch {
       fixtureHtml = example.output.slice(0, -1)
     }
 
-    md = toMarkdown(mdast, {extensions: [gfmToMarkdown()]})
+    const md = toMarkdown(mdast, {extensions: [gfmToMarkdown()]})
 
     try {
       fixtureMarkdown = String(fs.readFileSync(fixtureMarkdownPath))
-    } catch (_) {
+    } catch {
       fixtureMarkdown = md
       fs.writeFileSync(fixtureMarkdownPath, fixtureMarkdown)
     }