minor symfony#61329 Remove some unneeded var annotations (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

Remove some unneeded var annotations

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Commits
-------

ecdb536 Remove some unneeded var annotations

Author: nicolas-grekas

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

@@ -23,7 +23,6 @@
 use Symfony\Component\Filesystem\Exception\IOException;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\Finder;
-use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 use Symfony\Component\HttpKernel\KernelInterface;
 
 /**
@@ -119,7 +118,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $copyUsed = false;
         $exitCode = 0;
         $validAssetDirs = [];
-        /** @var BundleInterface $bundle */
         foreach ($kernel->getBundles() as $bundle) {
             if (!is_dir($originDir = $bundle->getPath().'/Resources/public') && !is_dir($originDir = $bundle->getPath().'/public')) {
                 continue;

src/Symfony/Component/AssetMapper/ImportMap/Resolver/JsDelivrEsmResolver.php

@@ -20,6 +20,7 @@
 use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Contracts\HttpClient\Exception\HttpExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
+use Symfony\Contracts\HttpClient\ResponseInterface;
 
 final class JsDelivrEsmResolver implements PackageResolverInterface
 {
@@ -165,6 +166,7 @@ public function resolvePackages(array $packagesToRequire): array
      */
     public function downloadPackages(array $importMapEntries, ?callable $progressCallback = null): array
     {
+        /** @var array<string, array{0: ResponseInterface, 1: ImportMapEntry}> $responses */
         $responses = [];
         foreach ($importMapEntries as $package => $entry) {
             if (!$entry->isRemotePackage()) {
@@ -184,7 +186,6 @@ public function downloadPackages(array $importMapEntries, ?callable $progressCal
         $errors = [];
         $contents = [];
         $extraFileResponses = [];
-        /** @var ImportMapEntry $entry */
         foreach ($responses as $package => [$response, $entry]) {
             if (200 !== $response->getStatusCode()) {
                 $errors[] = [$package, $response];

src/Symfony/Component/Console/Descriptor/ApplicationDescription.php

@@ -85,7 +85,6 @@ private function inspectApplication(): void
         foreach ($this->sortCommands($all) as $namespace => $commands) {
             $names = [];
 
-            /** @var Command $command */
             foreach ($commands as $name => $command) {
                 if (!$command->getName() || (!$this->showHidden && $command->isHidden())) {
                     continue;
@@ -104,6 +103,9 @@ private function inspectApplication(): void
         }
     }
 
+    /**
+     * @return array<string, array<string, Command>>
+     */
     private function sortCommands(array $commands): array
     {
         $namespacedCommands = [];

src/Symfony/Component/CssSelector/XPath/Translator.php

@@ -91,7 +91,6 @@ public function cssToXPath(string $cssExpr, string $prefix = 'descendant-or-self
     {
         $selectors = $this->parseSelectors($cssExpr);
 
-        /** @var SelectorNode $selector */
         foreach ($selectors as $index => $selector) {
             if (null !== $selector->getPseudoElement()) {
                 throw new ExpressionErrorException('Pseudo-elements are not supported.');

src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php

@@ -100,8 +100,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
         if ($options['expanded'] || $options['multiple']) {
             // Make sure that scalar, submitted values are converted to arrays
             // which can be submitted to the checkboxes/radio buttons
-            $builder->addEventListener(FormEvents::PRE_SUBMIT, static function (FormEvent $event) use ($choiceList, $options, &$unknownValues) {
-                /** @var PreSubmitEvent $event */
+            $builder->addEventListener(FormEvents::PRE_SUBMIT, static function (PreSubmitEvent $event) use ($choiceList, $options, &$unknownValues) {
                 $form = $event->getForm();
                 $data = $event->getData();
 

src/Symfony/Component/Form/Extension/Validator/ViolationMapper/ViolationMapper.php

@@ -17,7 +17,6 @@
 use Symfony\Component\Form\FormRendererInterface;
 use Symfony\Component\Form\Util\InheritDataAwareIterator;
 use Symfony\Component\PropertyAccess\PropertyPathBuilder;
-use Symfony\Component\PropertyAccess\PropertyPathInterface;
 use Symfony\Component\PropertyAccess\PropertyPathIterator;
 use Symfony\Component\PropertyAccess\PropertyPathIteratorInterface;
 use Symfony\Component\Validator\Constraints\File;
@@ -229,6 +228,7 @@ private function matchChild(FormInterface $form, PropertyPathIteratorInterface $
         $foundAtIndex = null;
 
         // Construct mapping rules for the given form
+        /** @var MappingRule[] $rules */
         $rules = [];
 
         foreach ($form->getConfig()->getOption('error_mapping') as $propertyPath => $targetPath) {
@@ -238,6 +238,7 @@ private function matchChild(FormInterface $form, PropertyPathIteratorInterface $
             }
         }
 
+        /** @var FormInterface[] $children */
         $children = iterator_to_array(new \RecursiveIteratorIterator(new InheritDataAwareIterator($form)), false);
 
         while ($it->valid()) {
@@ -249,8 +250,6 @@ private function matchChild(FormInterface $form, PropertyPathIteratorInterface $
 
             // Test mapping rules as long as we have any
             foreach ($rules as $key => $rule) {
-                /** @var MappingRule $rule */
-
                 // Mapping rule matches completely, terminate.
                 if (null !== ($form = $rule->match($chunk))) {
                     return $form;
@@ -262,7 +261,6 @@ private function matchChild(FormInterface $form, PropertyPathIteratorInterface $
                 }
             }
 
-            /** @var FormInterface $child */
             foreach ($children as $i => $child) {
                 $childPath = (string) $child->getPropertyPath();
                 if ($childPath === $chunk) {
@@ -313,7 +311,6 @@ private function reconstructPath(ViolationPath $violationPath, FormInterface $or
                 // Cut the piece out of the property path and proceed
                 $propertyPathBuilder->remove($i);
             } else {
-                /** @var PropertyPathInterface $propertyPath */
                 $propertyPath = $scope->getPropertyPath();
 
                 if (null === $propertyPath) {

src/Symfony/Component/Form/ResolvedFormType.php

@@ -117,7 +117,6 @@ public function finishView(FormView $view, FormInterface $form, array $options):
 
         $this->innerType->finishView($view, $form, $options);
 
-        /** @var FormTypeExtensionInterface $extension */
         foreach ($this->typeExtensions as $extension) {
             $extension->finishView($view, $form, $options);
         }

src/Symfony/Component/Messenger/Middleware/HandleMessageMiddleware.php

@@ -62,7 +62,6 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope
                 $handler = $handlerDescriptor->getHandler();
                 $batchHandler = $handlerDescriptor->getBatchHandler();
 
-                /** @var AckStamp $ackStamp */
                 if ($batchHandler && $ackStamp = $envelope->last(AckStamp::class)) {
                     $ack = new Acknowledger(get_debug_type($batchHandler), static function (?\Throwable $e = null, $result = null) use ($envelope, $ackStamp, $handlerDescriptor) {
                         if (null !== $e) {
@@ -99,9 +98,7 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope
             }
         }
 
-        /** @var FlushBatchHandlersStamp $flushStamp */
         if ($flushStamp = $envelope->last(FlushBatchHandlersStamp::class)) {
-            /** @var NoAutoAckStamp $stamp */
             foreach ($envelope->all(NoAutoAckStamp::class) as $stamp) {
                 try {
                     $handler = $stamp->getHandlerDescriptor()->getBatchHandler();
@@ -129,7 +126,6 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope
 
     private function messageHasAlreadyBeenHandled(Envelope $envelope, HandlerDescriptor $handlerDescriptor): bool
     {
-        /** @var HandledStamp $stamp */
         foreach ($envelope->all(HandledStamp::class) as $stamp) {
             if ($stamp->getHandlerName() === $handlerDescriptor->getName()) {
                 return true;

src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php

@@ -80,7 +80,6 @@ public function __construct(?DocBlockFactoryInterface $docBlockFactory = null, ?
 
     public function getShortDescription(string $class, string $property, array $context = []): ?string
     {
-        /** @var DocBlock $docBlock */
         [$docBlock] = $this->findDocBlock($class, $property);
         if (!$docBlock) {
             return null;
@@ -107,7 +106,6 @@ public function getShortDescription(string $class, string $property, array $cont
 
     public function getLongDescription(string $class, string $property, array $context = []): ?string
     {
-        /** @var DocBlock $docBlock */
         [$docBlock] = $this->findDocBlock($class, $property);
         if (!$docBlock) {
             return null;
@@ -125,7 +123,6 @@ public function getTypes(string $class, string $property, array $context = []):
     {
         trigger_deprecation('symfony/property-info', '7.3', 'The "%s()" method is deprecated, use "%s::getType()" instead.', __METHOD__, self::class);
 
-        /** @var DocBlock $docBlock */
         [$docBlock, $source, $prefix] = $this->findDocBlock($class, $property);
         if (!$docBlock) {
             return null;

src/Symfony/Component/Translation/Extractor/PhpAstExtractor.php

@@ -51,7 +51,6 @@ public function extract(iterable|string $resource, MessageCatalogue $catalogue):
             $nameResolver = new NodeVisitor\NameResolver();
             $traverser->addVisitor($nameResolver);
 
-            /** @var AbstractVisitor&NodeVisitor $visitor */
             foreach ($this->visitors as $visitor) {
                 $visitor->initialize($catalogue, $file, $this->prefix);
                 $traverser->addVisitor($visitor);