Merge branch '6.4' into 7.1

* 6.4:
  do not mix named and positional arguments in data provider definitions
  session names must not be empty
  fix Contracts directory name in PHPUnit configuration
  Passing null to parameter symfony#2 ($subject) of type string is deprecated

Author: xabbuh

phpunit.xml.dist

@@ -34,7 +34,7 @@
             <directory>./src/Symfony/Component/*/Tests/</directory>
             <directory>./src/Symfony/Component/*/*/Tests/</directory>
             <directory>./src/Symfony/Component/*/*/*/Tests/</directory>
-            <directory>./src/Symfony/Contract/*/Tests/</directory>
+            <directory>./src/Symfony/Contracts/*/Tests/</directory>
             <directory>./src/Symfony/Bundle/*/Tests/</directory>
         </testsuite>
     </testsuites>
@@ -63,7 +63,7 @@
             <directory>./src/Symfony/Bundle/*/vendor</directory>
             <directory>./src/Symfony/Component/*/vendor</directory>
             <directory>./src/Symfony/Component/*/*/vendor</directory>
-            <directory>./src/Symfony/Contract/*/vendor</directory>
+            <directory>./src/Symfony/Contracts/*/vendor</directory>
         </exclude>
     </coverage>
 

src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php

@@ -36,7 +36,7 @@ public function onKernelResponse(ResponseEvent $event): void
             return;
         }
 
-        if (!preg_match(static::USER_AGENT_REGEX, $event->getRequest()->headers->get('User-Agent'))) {
+        if (!preg_match(static::USER_AGENT_REGEX, $event->getRequest()->headers->get('User-Agent', ''))) {
             self::$sendHeaders = false;
             $this->headers = [];
 

src/Symfony/Bridge/Monolog/Tests/Handler/ChromePhpHandlerTest.php

@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bridge\Monolog\Tests\Handler;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Bridge\Monolog\Handler\ChromePhpHandler;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Event\ResponseEvent;
+use Symfony\Component\HttpKernel\HttpKernelInterface;
+
+class ChromePhpHandlerTest extends TestCase
+{
+    public function testOnKernelResponseShouldNotTriggerDeprecation()
+    {
+        $request = Request::create('/');
+        $request->headers->remove('User-Agent');
+
+        $response = new Response('foo');
+        $event = new ResponseEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MAIN_REQUEST, $response);
+
+        $error = null;
+        set_error_handler(function ($type, $message) use (&$error) { $error = $message; }, \E_DEPRECATED);
+
+        $listener = new ChromePhpHandler();
+        $listener->onKernelResponse($event);
+        restore_error_handler();
+
+        $this->assertNull($error);
+    }
+}

src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php

@@ -73,7 +73,7 @@ public static function provideCreateConnection(): array
                 'Redis',
             ],
             [
-                'dsn' => sprintf('redis:?%s', implode('&', \array_slice($hosts, 0, 2))),
+                sprintf('redis:?%s', implode('&', \array_slice($hosts, 0, 2))),
                 'RedisArray',
             ],
         ];

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractRedisSessionHandlerTestCase.php

@@ -89,7 +89,7 @@ public function testUseSessionGcMaxLifetimeAsTimeToLive()
 
     public function testDestroySession()
     {
-        $this->storage->open('', '');
+        $this->storage->open('', 'test');
         $this->redisClient->set(self::PREFIX.'id', 'foo');
 
         $this->assertTrue((bool) $this->redisClient->exists(self::PREFIX.'id'));

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php

@@ -109,7 +109,7 @@ public function testWriteSessionWithLargeTTL()
 
     public function testDestroySession()
     {
-        $this->storage->open('', '');
+        $this->storage->open('', 'sid');
         $this->memcached
             ->expects($this->once())
             ->method('delete')