Merge branch '7.3' into 7.4

* 7.3:
  remove deprecated nullable option from primary key columns
  specific fix to avoid 'outag' when inflecting 'outages'
  [DependencyInjection] Don’t autowire excluded services
  Add bool return type to CustomCredentials callable parameter
  [Process] Enhance hasSystemCallBeenInterrupted function for non-english locale
  [FrameworkBundle] Make `cache:warmup` warm up read-only caches

Author: nicolas-grekas

src/Symfony/Bridge/Doctrine/Tests/Fixtures/CompositeObjectNoToStringIdEntity.php

@@ -22,12 +22,12 @@ class CompositeObjectNoToStringIdEntity
     public function __construct(
         #[ORM\Id]
         #[ORM\ManyToOne(cascade: ['persist'])]
-        #[ORM\JoinColumn(name: 'object_one_id', nullable: false)]
+        #[ORM\JoinColumn(name: 'object_one_id')]
         protected SingleIntIdNoToStringEntity $objectOne,
 
         #[ORM\Id]
         #[ORM\ManyToOne(cascade: ['persist'])]
-        #[ORM\JoinColumn(name: 'object_two_id', nullable: false)]
+        #[ORM\JoinColumn(name: 'object_two_id')]
         protected SingleIntIdNoToStringEntity $objectTwo,
     ) {
     }

src/Symfony/Bridge/Doctrine/Tests/Fixtures/SingleAssociationToIntIdEntity.php

@@ -22,7 +22,7 @@ class SingleAssociationToIntIdEntity
 {
     public function __construct(
         #[Id, OneToOne(cascade: ['ALL'])]
-        #[JoinColumn(nullable: false)]
+        #[JoinColumn()]
         protected SingleIntIdNoToStringEntity $entity,
 
         #[Column(nullable: true)]

src/Symfony/Bundle/FrameworkBundle/Command/CacheWarmupCommand.php

@@ -69,9 +69,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $kernel->warmUp($cacheDir);
         }
 
-        $preload = $this->cacheWarmer->warmUp($cacheDir);
-
         $buildDir = $kernel->getContainer()->getParameter('kernel.build_dir');
+
+        $preload = $this->cacheWarmer->warmUp($cacheDir, $buildDir);
+
         if ($preload && $cacheDir === $buildDir && file_exists($preloadFile = $buildDir.'/'.$kernel->getContainer()->getParameter('kernel.container_class').'.preload.php')) {
             Preloader::append($preloadFile, $preload);
         }

src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php

@@ -459,11 +459,11 @@ private function getAutowiredReference(TypedReference $reference, bool $filterTy
         $name = $target = (array_filter($reference->getAttributes(), static fn ($a) => $a instanceof Target)[0] ?? null)?->name;
 
         if (null !== $name ??= $reference->getName()) {
-            if (null !== ($alias = $this->getCombinedAlias($type, $name, $target)) && !$this->container->findDefinition($alias)->isAbstract()) {
+            if (null !== ($alias = $this->getCombinedAlias($type, $name, $target)) && $this->canDefinitionBeAutowired($alias)) {
                 return new TypedReference($alias, $type, $reference->getInvalidBehavior());
             }
 
-            if ($this->container->has($name) && !$this->container->findDefinition($name)->isAbstract()) {
+            if ($this->container->has($name) && $this->canDefinitionBeAutowired($name)) {
                 foreach ($this->container->getAliases() as $id => $alias) {
                     if ($name === (string) $alias && str_starts_with($id, $type.' $')) {
                         return new TypedReference($name, $type, $reference->getInvalidBehavior());
@@ -476,13 +476,20 @@ private function getAutowiredReference(TypedReference $reference, bool $filterTy
             }
         }
 
-        if (null !== ($alias = $this->getCombinedAlias($type)) && !$this->container->findDefinition($alias)->isAbstract()) {
+        if (null !== ($alias = $this->getCombinedAlias($type)) && $this->canDefinitionBeAutowired($alias)) {
             return new TypedReference($alias, $type, $reference->getInvalidBehavior());
         }
 
         return null;
     }
 
+    private function canDefinitionBeAutowired(string $id): bool
+    {
+        $definition = $this->container->findDefinition($id);
+
+        return !$definition->isAbstract() && !$definition->hasTag('container.excluded');
+    }
+
     /**
      * Populates the list of available types.
      */
@@ -659,7 +666,7 @@ private function getAliasesSuggestionForType(ContainerBuilder $container, string
     {
         $aliases = [];
         foreach (class_parents($type) + class_implements($type) as $parent) {
-            if ($container->has($parent) && !$container->findDefinition($parent)->isAbstract()) {
+            if ($container->has($parent) && $this->canDefinitionBeAutowired($parent)) {
                 $aliases[] = $parent;
             }
         }
@@ -704,7 +711,7 @@ private function getCombinedAlias(string $type, ?string $name = null, ?string $t
         $suffix = $name ? ' $'.($target ?? $name) : '';
         $parsedName = $target ?? ($name ? (new Target($name))->getParsedName() : null);
 
-        if ($this->container->has($alias = $prefix.$type.$suffix) && !$this->container->findDefinition($alias)->isAbstract()) {
+        if ($this->container->has($alias = $prefix.$type.$suffix) && $this->canDefinitionBeAutowired($alias)) {
             return $alias;
         }
 

src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php

@@ -1350,7 +1350,7 @@ public function testTypeSymbolExcluded()
     {
         $container = new ContainerBuilder();
 
-        $container->register(Foo::class)->setAbstract(true)->addTag('container.excluded', ['source' => 'for tests']);
+        $container->register(Foo::class)->addTag('container.excluded', ['source' => 'for tests']);
         $aDefinition = $container->register('a', NotGuessableArgument::class);
         $aDefinition->setAutowired(true);
 
@@ -1367,7 +1367,7 @@ public function testTypeNamespaceExcluded()
     {
         $container = new ContainerBuilder();
 
-        $container->register(__NAMESPACE__)->setAbstract(true)->addTag('container.excluded');
+        $container->register(__NAMESPACE__)->addTag('container.excluded');
         $aDefinition = $container->register('a', NotGuessableArgument::class);
         $aDefinition->setAutowired(true);
 

src/Symfony/Component/Process/Pipes/AbstractPipes.php

@@ -52,14 +52,26 @@ public function close(): void
 
     /**
      * Returns true if a system call has been interrupted.
+     *
+     * stream_select() returns false when the `select` system call is interrupted by an incoming signal.
      */
     protected function hasSystemCallBeenInterrupted(): bool
     {
         $lastError = $this->lastError;
         $this->lastError = null;
 
-        // stream_select returns false when the `select` system call is interrupted by an incoming signal
-        return null !== $lastError && false !== stripos($lastError, 'interrupted system call');
+        if (null === $lastError) {
+            return false;
+        }
+
+        if (false !== stripos($lastError, 'interrupted system call')) {
+            return true;
+        }
+
+        // on applications with a different locale than english, the message above is not found because
+        // it's translated. So we also check for the SOCKET_EINTR constant which is defined under
+        // Windows and UNIX-like platforms (if available on the platform).
+        return \defined('SOCKET_EINTR') && str_starts_with($lastError, 'stream_select(): Unable to select ['.\SOCKET_EINTR.']');
     }
 
     /**

src/Symfony/Component/Security/Http/Authenticator/Passport/Credentials/CustomCredentials.php

@@ -27,9 +27,9 @@ class CustomCredentials implements CredentialsInterface
     private bool $resolved = false;
 
     /**
-     * @param callable(mixed, UserInterface) $customCredentialsChecker If the callable does not return `true`, a
-     *                                                                 BadCredentialsException is thrown. You may
-     *                                                                 also throw a more specific exception.
+     * @param callable(mixed, UserInterface): bool $customCredentialsChecker If the callable does not return `true`, a
+     *                                                                       BadCredentialsException is thrown. You may
+     *                                                                       also throw a more specific exception.
      */
     public function __construct(
         callable $customCredentialsChecker,

src/Symfony/Component/String/Inflector/EnglishInflector.php

@@ -166,6 +166,9 @@ final class EnglishInflector implements InflectorInterface
         // edges (edge)
         ['segd', 4, true, true, 'dge'],
 
+        // outages (outage) - specific fix to avoid 'outag'
+        ['segatuo', 7, true, true, 'outage'],
+
         // roses (rose), garages (garage), cassettes (cassette),
         // waltzes (waltz), heroes (hero), bushes (bush), arches (arch),
         // shoes (shoe)

src/Symfony/Component/String/Tests/Inflector/EnglishInflectorTest.php

@@ -125,6 +125,7 @@ public static function singularizeProvider()
             ['news', 'news'],
             ['oases', ['oas', 'oase', 'oasis']],
             ['objectives', 'objective'],
+            ['outages', 'outage'],
             ['oxen', 'ox'],
             ['parties', 'party'],
             ['people', 'person'],