bug symfony#58289 [HttpKernel] Skip logging uncaught exceptions in ErrorHandler, assume $kernel->terminateWithException() will do it (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[HttpKernel] Skip logging uncaught exceptions in `ErrorHandler`, assume `$kernel->terminateWithException()` will do it

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#57902
| License       | MIT

When uncaught exceptions are handled by `ErrorHandler::handleException()`, that method logs them, then calls a callback to let the app know about the exception itself.

This causes two issues:
1. that log happens without context, which leads to symfony#57902
2. logs are duplicated: one by ErrorHandler, twice by the callback

In this PR, I propose to consider that if terminateWithException is configured as a callback, we assume that the app will handle the logging on its own.

Tested in practice, this works nicely.

Adding a test case is quite complex as all this involves many pieces and global state, so I skipped adding one.

Commits
-------

3b87c32 [HttpKernel] Skip logging uncaught exceptions in ErrorHandler, assume $kernel->terminateWithException() will do it

Author: nicolas-grekas

src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php

@@ -82,6 +82,7 @@ public function configure(?object $event = null)
             return;
         }
         $this->firstCall = $this->hasTerminatedWithException = false;
+        $hasRun = null;
 
         $handler = set_exception_handler('is_int');
         $handler = \is_array($handler) ? $handler[0] : null;
@@ -144,6 +145,19 @@ public function configure(?object $event = null)
         if ($this->exceptionHandler) {
             if ($handler instanceof ErrorHandler) {
                 $handler->setExceptionHandler($this->exceptionHandler);
+                if (null !== $hasRun) {
+                    $throwAt = $handler->throwAt(0) | \E_ERROR | \E_CORE_ERROR | \E_COMPILE_ERROR | \E_USER_ERROR | \E_RECOVERABLE_ERROR | \E_PARSE;
+                    $loggers = [];
+
+                    foreach ($handler->setLoggers([]) as $type => $log) {
+                        if ($type & $throwAt) {
+                            $loggers[$type] = [null, $log[1]];
+                        }
+                    }
+
+                    // Assume $kernel->terminateWithException() will log uncaught exceptions appropriately
+                    $handler->setLoggers($loggers);
+                }
             }
             $this->exceptionHandler = null;
         }