bug symfony#54547 [HttpKernel] Force non lazy controller services (smnandre)

This PR was submitted for the 6.4 branch but it was merged into the 5.4 branch instead.

Discussion
----------

[HttpKernel] Force non lazy controller services

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#54542
| License       | MIT

Controllers registered as lazy services created a bug where IsGranted attribute were ignored.

Following `@nicolas`-grekas suggestion, this PR enfore that controllers are not registered as lazy.

Commits
-------

38d71d6 [HttpKernel] Ensure controllers are not lazy

Author: nicolas-grekas

src/Symfony/Component/HttpKernel/DependencyInjection/RegisterControllerArgumentLocatorsPass.php

@@ -70,6 +70,7 @@ public function process(ContainerBuilder $container)
         foreach ($container->findTaggedServiceIds($this->controllerTag, true) as $id => $tags) {
             $def = $container->getDefinition($id);
             $def->setPublic(true);
+            $def->setLazy(false);
             $class = $def->getClass();
             $autowire = $def->isAutowired();
             $bindings = $def->getBindings();

src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php

@@ -25,6 +25,7 @@
 use Symfony\Component\DependencyInjection\TypedReference;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\DependencyInjection\RegisterControllerArgumentLocatorsPass;
+use Symfony\Component\HttpKernel\Tests\Fixtures\DataCollector\DummyController;
 use Symfony\Component\HttpKernel\Tests\Fixtures\Suit;
 
 class RegisterControllerArgumentLocatorsPassTest extends TestCase
@@ -285,6 +286,21 @@ public function testControllersAreMadePublic()
         $this->assertTrue($container->getDefinition('foo')->isPublic());
     }
 
+    public function testControllersAreMadeNonLazy()
+    {
+        $container = new ContainerBuilder();
+        $container->register('argument_resolver.service')->addArgument([]);
+
+        $container->register('foo', DummyController::class)
+            ->addTag('controller.service_arguments')
+            ->setLazy(true);
+
+        $pass = new RegisterControllerArgumentLocatorsPass();
+        $pass->process($container);
+
+        $this->assertFalse($container->getDefinition('foo')->isLazy());
+    }
+
     /**
      * @dataProvider provideBindings
      */