minor symfony#61556 [Intl] Add metadata about currencies' validity dates (Crovitche-1623, nicolas-grekas)

This PR was merged into the 6.4 branch.

Discussion
----------

[Intl] Add metadata about currencies' validity dates

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

This backports intl data from symfony#61431 to 6.4
This also syncs the ICU compilation scripts with 7.4.
This allows generating ICU data once on 6.4 and not have to care about running that again on higher branches.

Commits
-------

4a85bb3 Sync intl scripts
243f8f9 [Intl] Add metadata about currencies' validtity dates

Author: nicolas-grekas

.github/expected-missing-return-types.diff

@@ -2328,21 +2328,21 @@ diff --git a/src/Symfony/Component/Console/EventListener/ErrorListener.php b/src
 diff --git a/src/Symfony/Component/Console/Formatter/OutputFormatter.php b/src/Symfony/Component/Console/Formatter/OutputFormatter.php
 --- a/src/Symfony/Component/Console/Formatter/OutputFormatter.php
 +++ b/src/Symfony/Component/Console/Formatter/OutputFormatter.php
-@@ -87,5 +87,5 @@ class OutputFormatter implements WrappableOutputFormatterInterface
+@@ -88,5 +88,5 @@ class OutputFormatter implements WrappableOutputFormatterInterface
       * @return void
       */
 -    public function setDecorated(bool $decorated)
 +    public function setDecorated(bool $decorated): void
      {
          $this->decorated = $decorated;
-@@ -100,5 +100,5 @@ class OutputFormatter implements WrappableOutputFormatterInterface
+@@ -101,5 +101,5 @@ class OutputFormatter implements WrappableOutputFormatterInterface
       * @return void
       */
 -    public function setStyle(string $name, OutputFormatterStyleInterface $style)
 +    public function setStyle(string $name, OutputFormatterStyleInterface $style): void
      {
          $this->styles[strtolower($name)] = $style;
-@@ -127,5 +127,5 @@ class OutputFormatter implements WrappableOutputFormatterInterface
+@@ -128,5 +128,5 @@ class OutputFormatter implements WrappableOutputFormatterInterface
       * @return string
       */
 -    public function formatAndWrap(?string $message, int $width)
@@ -2488,21 +2488,21 @@ diff --git a/src/Symfony/Component/Console/Helper/Helper.php b/src/Symfony/Compo
 +    public function setHelperSet(?HelperSet $helperSet = null): void
      {
          if (1 > \func_num_args()) {
-@@ -97,5 +97,5 @@ abstract class Helper implements HelperInterface
+@@ -101,5 +101,5 @@ abstract class Helper implements HelperInterface
       * @return string
       */
 -    public static function formatTime(int|float $secs, int $precision = 1)
 +    public static function formatTime(int|float $secs, int $precision = 1): string
      {
          $secs = (int) floor($secs);
-@@ -140,5 +140,5 @@ abstract class Helper implements HelperInterface
+@@ -144,5 +144,5 @@ abstract class Helper implements HelperInterface
       * @return string
       */
 -    public static function formatMemory(int $memory)
 +    public static function formatMemory(int $memory): string
      {
          if ($memory >= 1024 * 1024 * 1024) {
-@@ -160,5 +160,5 @@ abstract class Helper implements HelperInterface
+@@ -164,5 +164,5 @@ abstract class Helper implements HelperInterface
       * @return string
       */
 -    public static function removeDecoration(OutputFormatterInterface $formatter, ?string $string)
@@ -8905,24 +8905,6 @@ diff --git a/src/Symfony/Component/HttpKernel/TerminableInterface.php b/src/Symf
 -    public function terminate(Request $request, Response $response);
 +    public function terminate(Request $request, Response $response): void;
  }
-diff --git a/src/Symfony/Component/Intl/Data/Bundle/Compiler/BundleCompilerInterface.php b/src/Symfony/Component/Intl/Data/Bundle/Compiler/BundleCompilerInterface.php
---- a/src/Symfony/Component/Intl/Data/Bundle/Compiler/BundleCompilerInterface.php
-+++ b/src/Symfony/Component/Intl/Data/Bundle/Compiler/BundleCompilerInterface.php
-@@ -27,4 +27,4 @@ interface BundleCompilerInterface
-      * @return void
-      */
--    public function compile(string $sourcePath, string $targetDir);
-+    public function compile(string $sourcePath, string $targetDir): void;
- }
-diff --git a/src/Symfony/Component/Intl/Data/Bundle/Writer/BundleWriterInterface.php b/src/Symfony/Component/Intl/Data/Bundle/Writer/BundleWriterInterface.php
---- a/src/Symfony/Component/Intl/Data/Bundle/Writer/BundleWriterInterface.php
-+++ b/src/Symfony/Component/Intl/Data/Bundle/Writer/BundleWriterInterface.php
-@@ -24,4 +24,4 @@ interface BundleWriterInterface
-      * @return void
-      */
--    public function write(string $path, string $locale, mixed $data);
-+    public function write(string $path, string $locale, mixed $data): void;
- }
 diff --git a/src/Symfony/Component/Intl/Transliterator/EmojiTransliterator.php b/src/Symfony/Component/Intl/Transliterator/EmojiTransliterator.php
 --- a/src/Symfony/Component/Intl/Transliterator/EmojiTransliterator.php
 +++ b/src/Symfony/Component/Intl/Transliterator/EmojiTransliterator.php
@@ -9465,28 +9447,28 @@ diff --git a/src/Symfony/Component/Lock/Store/MemcachedStore.php b/src/Symfony/C
 diff --git a/src/Symfony/Component/Lock/Store/MongoDbStore.php b/src/Symfony/Component/Lock/Store/MongoDbStore.php
 --- a/src/Symfony/Component/Lock/Store/MongoDbStore.php
 +++ b/src/Symfony/Component/Lock/Store/MongoDbStore.php
-@@ -209,5 +209,5 @@ class MongoDbStore implements PersistingStoreInterface
+@@ -213,5 +213,5 @@ class MongoDbStore implements PersistingStoreInterface
       * @throws DriverRuntimeException        for other driver errors (e.g. connection errors)
       */
 -    public function createTtlIndex(int $expireAfterSeconds = 0)
 +    public function createTtlIndex(int $expireAfterSeconds = 0): void
      {
          $server = $this->getManager()->selectServer();
-@@ -231,5 +231,5 @@ class MongoDbStore implements PersistingStoreInterface
+@@ -235,5 +235,5 @@ class MongoDbStore implements PersistingStoreInterface
       * @throws LockExpiredException when save is called on an expired lock
       */
 -    public function save(Key $key)
 +    public function save(Key $key): void
      {
          $key->reduceLifetime($this->initialTtl);
-@@ -257,5 +257,5 @@ class MongoDbStore implements PersistingStoreInterface
+@@ -261,5 +261,5 @@ class MongoDbStore implements PersistingStoreInterface
       * @throws LockExpiredException
       */
 -    public function putOffExpiration(Key $key, float $ttl)
 +    public function putOffExpiration(Key $key, float $ttl): void
      {
          $key->reduceLifetime($ttl);
-@@ -276,5 +276,5 @@ class MongoDbStore implements PersistingStoreInterface
+@@ -280,5 +280,5 @@ class MongoDbStore implements PersistingStoreInterface
       * @return void
       */
 -    public function delete(Key $key)

src/Symfony/Component/Intl/Data/Bundle/Compiler/BundleCompilerInterface.php

@@ -23,8 +23,6 @@ interface BundleCompilerInterface
     /**
      * Compiles a resource bundle at the given source to the given target
      * directory.
-     *
-     * @return void
      */
-    public function compile(string $sourcePath, string $targetDir);
+    public function compile(string $sourcePath, string $targetDir): void;
 }

src/Symfony/Component/Intl/Data/Bundle/Reader/BufferedBundleReader.php

@@ -20,13 +20,13 @@
  */
 class BufferedBundleReader implements BundleReaderInterface
 {
-    private BundleReaderInterface $reader;
     /** @var RingBuffer<string, mixed> */
     private RingBuffer $buffer;
 
-    public function __construct(BundleReaderInterface $reader, int $bufferSize)
-    {
-        $this->reader = $reader;
+    public function __construct(
+        private BundleReaderInterface $reader,
+        int $bufferSize,
+    ) {
         $this->buffer = new RingBuffer($bufferSize);
     }
 

src/Symfony/Component/Intl/Data/Bundle/Reader/BundleEntryReader.php

@@ -28,8 +28,6 @@
  */
 class BundleEntryReader implements BundleEntryReaderInterface
 {
-    private BundleReaderInterface $reader;
-
     /**
      * A mapping of locale aliases to locales.
      */
@@ -38,9 +36,9 @@ class BundleEntryReader implements BundleEntryReaderInterface
     /**
      * Creates an entry reader based on the given resource bundle reader.
      */
-    public function __construct(BundleReaderInterface $reader)
-    {
-        $this->reader = $reader;
+    public function __construct(
+        private BundleReaderInterface $reader,
+    ) {
     }
 
     /**

src/Symfony/Component/Intl/Data/Bundle/Writer/BundleWriterInterface.php

@@ -20,8 +20,5 @@
  */
 interface BundleWriterInterface
 {
-    /**
-     * @return void
-     */
-    public function write(string $path, string $locale, mixed $data);
+    public function write(string $path, string $locale, mixed $data): void;
 }

src/Symfony/Component/Intl/Data/Bundle/Writer/PhpBundleWriter.php

@@ -25,11 +25,11 @@ class PhpBundleWriter implements BundleWriterInterface
     public function write(string $path, string $locale, mixed $data): void
     {
         $template = <<<'TEMPLATE'
-<?php
+            <?php
 
-return %s;
+            return %s;
 
-TEMPLATE;
+            TEMPLATE;
 
         if ($data instanceof \Traversable) {
             $data = iterator_to_array($data);

src/Symfony/Component/Intl/Data/Generator/AbstractDataGenerator.php

@@ -27,13 +27,10 @@
  */
 abstract class AbstractDataGenerator
 {
-    private BundleCompilerInterface $compiler;
-    private string $dirName;
-
-    public function __construct(BundleCompilerInterface $compiler, string $dirName)
-    {
-        $this->compiler = $compiler;
-        $this->dirName = $dirName;
+    public function __construct(
+        private BundleCompilerInterface $compiler,
+        private string $dirName,
+    ) {
     }
 
     public function generateData(GeneratorConfig $config): void

src/Symfony/Component/Intl/Data/Generator/CurrencyDataGenerator.php

@@ -102,6 +102,7 @@ protected function generateDataForMeta(BundleEntryReaderInterface $reader, strin
         $data = [
             'Currencies' => $this->currencyCodes,
             'Meta' => $this->generateCurrencyMeta($supplementalDataBundle),
+            'Map' => $this->generateCurrencyMap($supplementalDataBundle),
             'Alpha3ToNumeric' => $this->generateAlpha3ToNumericMapping($numericCodesBundle, $this->currencyCodes),
         ];
 
@@ -127,6 +128,70 @@ private function generateCurrencyMeta(ArrayAccessibleResourceBundle $supplementa
         return iterator_to_array($supplementalDataBundle['CurrencyMeta']);
     }
 
+    /**
+     * @return array<string, array>
+     */
+    private function generateCurrencyMap(mixed $supplementalDataBundle): array
+    {
+        /**
+         * @var list<string, list<string, array{from?: string, to?: string, tender?: false}>> $regionsData
+         */
+        $regionsData = [];
+
+        foreach ($supplementalDataBundle['CurrencyMap'] as $regionId => $region) {
+            foreach ($region as $metadata) {
+                /**
+                 * Note 1: The "to" property (if present) is always greater than "from".
+                 * Note 2: The "to" property may be missing if the currency is still in use.
+                 * Note 3: The "tender" property indicates whether the country legally recognizes the currency within
+                 *         its borders. This property is explicitly set to `false` only if that is not the case;
+                 *         otherwise, it is `true` by default.
+                 * Note 4: The "from" and "to" dates are not stored as strings; they are stored as a pair of integers.
+                 * Note 5: The "to" property may be missing if "tender" is set to `false`.
+                 *
+                 * @var array{
+                 *        from?: array{0: int, 1: int},
+                 *        to?: array{0: int, 2: int},
+                 *        tender?: bool,
+                 *        id: string
+                 *      } $metadata
+                 */
+                $metadata = iterator_to_array($metadata);
+
+                $id = $metadata['id'];
+
+                unset($metadata['id']);
+
+                if (\array_key_exists($id, self::DENYLIST)) {
+                    continue;
+                }
+
+                if (\array_key_exists('from', $metadata)) {
+                    $metadata['from'] = self::icuPairToDate($metadata['from']);
+                }
+
+                if (\array_key_exists('to', $metadata)) {
+                    $metadata['to'] = self::icuPairToDate($metadata['to']);
+                }
+
+                if (\array_key_exists('tender', $metadata)) {
+                    $metadata['tender'] = filter_var($metadata['tender'], \FILTER_VALIDATE_BOOLEAN, \FILTER_NULL_ON_FAILURE);
+
+                    if (null === $metadata['tender']) {
+                        throw new \RuntimeException('Unexpected boolean value for tender attribute.');
+                    }
+                }
+
+                $regionsData[$regionId][$id] = $metadata;
+            }
+
+            // Do not exclude countries with no currencies or excluded currencies (e.g. Antartica)
+            $regionsData[$regionId] ??= [];
+        }
+
+        return $regionsData;
+    }
+
     private function generateAlpha3ToNumericMapping(ArrayAccessibleResourceBundle $numericCodesBundle, array $currencyCodes): array
     {
         $alpha3ToNumericMapping = iterator_to_array($numericCodesBundle['codeMap']);
@@ -156,4 +221,41 @@ private function generateNumericToAlpha3Mapping(array $alpha3ToNumericMapping):
 
         return $numericToAlpha3Mapping;
     }
+
+    /**
+     * Decodes ICU "date pair" into a DateTimeImmutable (UTC).
+     *
+     * ICU stores UDate = milliseconds since 1970-01-01T00:00:00Z in a signed 64-bit.
+     *
+     * @param array{0: int, 1: int} $pair
+     */
+    private static function icuPairToDate(array $pair): string
+    {
+        [$highBits32, $lowBits32] = $pair;
+
+        // Recompose a 64-bit unsigned integer from two 32-bit chunks.
+        $unsigned64 = ((($highBits32 & 0xFFFFFFFF) << 32) | ($lowBits32 & 0xFFFFFFFF));
+
+        // Convert to signed 64-bit (two's complement) if sign bit is set.
+        if ($unsigned64 >= (1 << 63)) {
+            $unsigned64 -= (1 << 64);
+        }
+
+        // Split into seconds and milliseconds.
+        $seconds = intdiv($unsigned64, 1000);
+        $millisecondsRemainder = $unsigned64 - $seconds * 1000;
+
+        // Normalize negative millisecond remainders (e.g., for pre-1970 values)
+        if (0 > $millisecondsRemainder) {
+            --$seconds;
+        }
+
+        $datetime = \DateTimeImmutable::createFromFormat('U', $seconds, new \DateTimeZone('Etc/UTC'));
+
+        if (false === $datetime) {
+            throw new \RuntimeException('Unable to parse ICU milliseconds pair.');
+        }
+
+        return $datetime->format('Y-m-d');
+    }
 }

src/Symfony/Component/Intl/Data/Generator/GeneratorConfig.php

@@ -22,18 +22,15 @@
  */
 class GeneratorConfig
 {
-    private string $sourceDir;
-    private string $icuVersion;
-
     /**
      * @var BundleWriterInterface[]
      */
     private array $bundleWriters = [];
 
-    public function __construct(string $sourceDir, string $icuVersion)
-    {
-        $this->sourceDir = $sourceDir;
-        $this->icuVersion = $icuVersion;
+    public function __construct(
+        private string $sourceDir,
+        private string $icuVersion,
+    ) {
     }
 
     /**