minor symfony#59753 [WebProfilerBundle] Fix tests (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 4897024d6599 · 2025-02-11T17:44:43.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [WebProfilerBundle] Fix tests | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 5cf6c66 [WebProfilerBundle] Fix tests
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Tests/EventListener/WebDebugToolbarListenerTest.php b/src/Symfony/Bundle/WebProfilerBundle/Tests/EventListener/WebDebugToolbarListenerTest.php
@@ -63,6 +63,7 @@ public static function getInjectToolbarTests()
     public function testHtmlRedirectionIsIntercepted($statusCode)
     {
         $response = new Response('Some content', $statusCode);
+        $response->headers->set('Location', 'https://example.com/');
         $response->headers->set('X-Debug-Token', 'xxxxxxxx');
         $event = new ResponseEvent($this->createMock(Kernel::class), new Request(), HttpKernelInterface::MAIN_REQUEST, $response);
 
@@ -76,6 +77,7 @@ public function testHtmlRedirectionIsIntercepted($statusCode)
     public function testNonHtmlRedirectionIsNotIntercepted()
     {
         $response = new Response('Some content', '301');
+        $response->headers->set('Location', 'https://example.com/');
         $response->headers->set('X-Debug-Token', 'xxxxxxxx');
         $event = new ResponseEvent($this->createMock(Kernel::class), new Request([], [], ['_format' => 'json']), HttpKernelInterface::MAIN_REQUEST, $response);
 
@@ -139,6 +141,7 @@ public function testToolbarIsNotInjectedOnContentDispositionAttachment()
     public function testToolbarIsNotInjectedOnRedirection($statusCode)
     {
         $response = new Response('<html><head></head><body></body></html>', $statusCode);
+        $response->headers->set('Location', 'https://example.com/');
         $response->headers->set('X-Debug-Token', 'xxxxxxxx');
         $event = new ResponseEvent($this->createMock(Kernel::class), new Request(), HttpKernelInterface::MAIN_REQUEST, $response);
 

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ public static function getInjectToolbarTests()`
`63`	`63`	`public function testHtmlRedirectionIsIntercepted($statusCode)`
`64`	`64`	`{`
`65`	`65`	`$response = new Response('Some content', $statusCode);`
	`66`	`+ $response->headers->set('Location', 'https://example.com/');`
`66`	`67`	`$response->headers->set('X-Debug-Token', 'xxxxxxxx');`
`67`	`68`	`$event = new ResponseEvent($this->createMock(Kernel::class), new Request(), HttpKernelInterface::MAIN_REQUEST, $response);`
`68`	`69`
`@@ -76,6 +77,7 @@ public function testHtmlRedirectionIsIntercepted($statusCode)`
`76`	`77`	`public function testNonHtmlRedirectionIsNotIntercepted()`
`77`	`78`	`{`
`78`	`79`	`$response = new Response('Some content', '301');`
	`80`	`+ $response->headers->set('Location', 'https://example.com/');`
`79`	`81`	`$response->headers->set('X-Debug-Token', 'xxxxxxxx');`
`80`	`82`	`$event = new ResponseEvent($this->createMock(Kernel::class), new Request([], [], ['_format' => 'json']), HttpKernelInterface::MAIN_REQUEST, $response);`
`81`	`83`
`@@ -139,6 +141,7 @@ public function testToolbarIsNotInjectedOnContentDispositionAttachment()`
`139`	`141`	`public function testToolbarIsNotInjectedOnRedirection($statusCode)`
`140`	`142`	`{`
`141`	`143`	`$response = new Response('<html><head></head><body></body></html>', $statusCode);`
	`144`	`+ $response->headers->set('Location', 'https://example.com/');`
`142`	`145`	`$response->headers->set('X-Debug-Token', 'xxxxxxxx');`
`143`	`146`	`$event = new ResponseEvent($this->createMock(Kernel::class), new Request(), HttpKernelInterface::MAIN_REQUEST, $response);`
`144`	`147`