minor symfony#61203 Remove some implicit bool type juggling (Girgias)

This PR was merged into the 7.4 branch.

Discussion
----------

Remove some implicit bool type juggling

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

No real bug fixed but still edge cases that are better handled explicitly.
This is both a subset and a superset of symfony#60890 by `@Girgias`
It fixes all spots reported by php/php-src#18879 that can be consider as legit to me.

Commits
-------

8680ce4 Remove some implicit bool type juggling

Author: nicolas-grekas

src/Symfony/Bridge/Twig/Tests/Extension/SecurityExtensionTest.php

@@ -91,8 +91,8 @@ public static function provideObjectFieldAclCases()
         return [
             [null, null, null],
             ['object', null, 'object'],
-            ['object', false, new FieldVote('object', false)],
-            ['object', 0, new FieldVote('object', 0)],
+            ['object', '', new FieldVote('object', false)],
+            ['object', '0', new FieldVote('object', 0)],
             ['object', '', new FieldVote('object', '')],
             ['object', 'field', new FieldVote('object', 'field')],
         ];

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php

@@ -184,7 +184,7 @@ private function getFileLink(string $class): string
             return '';
         }
 
-        return (string) $this->fileLinkFormatter->format($r->getFileName(), $r->getStartLine());
+        return $r->getFileName() ? ($this->fileLinkFormatter->format($r->getFileName(), $r->getStartLine()) ?: '') : '';
     }
 
     public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void

src/Symfony/Bundle/TwigBundle/Tests/Functional/AttributeExtensionTest.php

@@ -139,8 +139,9 @@ public static function fooTest(bool $value): bool
 
 class RuntimeExtensionWithAttributes
 {
-    public function __construct(private bool $prefix)
-    {
+    public function __construct(
+        private string $prefix,
+    ) {
     }
 
     #[AsTwigFilter('prefix_foo')]

src/Symfony/Bundle/WebProfilerBundle/Profiler/CodeExtension.php

@@ -94,7 +94,7 @@ public function formatArgs(array $args): string
                 $formattedValue = '<em>'.strtolower(htmlspecialchars(var_export($item[1], true), \ENT_COMPAT | \ENT_SUBSTITUTE, $this->charset)).'</em>';
             } elseif ('resource' === $item[0]) {
                 $formattedValue = '<em>resource</em>';
-            } elseif (preg_match('/[^\x07-\x0D\x1B\x20-\xFF]/', $item[1])) {
+            } elseif (\is_string($item[1]) && preg_match('/[^\x07-\x0D\x1B\x20-\xFF]/', $item[1])) {
                 $formattedValue = '<em>binary string</em>';
             } else {
                 $formattedValue = str_replace("\n", '', htmlspecialchars(var_export($item[1], true), \ENT_COMPAT | \ENT_SUBSTITUTE, $this->charset));

src/Symfony/Component/AssetMapper/AssetMapperDevServerSubscriber.php

@@ -146,7 +146,7 @@ public function onKernelRequest(RequestEvent $event): void
         if ($mediaType = $this->getMediaType($asset->publicPath)) {
             $response->headers->set('Content-Type', $mediaType);
         }
-        $response->headers->set('X-Assets-Dev', true);
+        $response->headers->set('X-Assets-Dev', '1');
 
         $event->setResponse($response);
         $event->stopPropagation();

src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php

@@ -56,7 +56,7 @@ public function testUrlDecodeParameters()
 
     public static function provideCreateConnection(): array
     {
-        $hosts = array_map(fn ($host) => \sprintf('host[%s]', $host), explode(' ', getenv('REDIS_CLUSTER_HOSTS')));
+        $hosts = array_map(fn ($host) => \sprintf('host[%s]', $host), explode(' ', getenv('REDIS_CLUSTER_HOSTS') ?: ''));
 
         return [
             [
@@ -79,7 +79,7 @@ public static function provideCreateConnection(): array
     }
 
     /**
-     * Due to a bug in phpredis, the persistent connection will keep its last selected database. So when re-using
+     * Due to a bug in phpredis, the persistent connection will keep its last selected database. So when reusing
      * a persistent connection, the database has to be re-selected, too.
      *
      * @see https://github.com/phpredis/phpredis/issues/1920

src/Symfony/Component/DependencyInjection/Tests/AliasTest.php

@@ -87,7 +87,6 @@ public static function invalidDeprecationMessageProvider(): array
             "With \ns" => ["invalid \n message %alias_id%"],
             'With */s' => ['invalid */ message %alias_id%'],
             'message not containing required %alias_id% variable' => ['this is deprecated'],
-            'template not containing required %alias_id% variable' => [true],
         ];
     }
 }

src/Symfony/Component/DependencyInjection/Tests/DefinitionTest.php

@@ -204,7 +204,6 @@ public static function invalidDeprecationMessageProvider(): array
             "With \ns" => ["invalid \n message %service_id%"],
             'With */s' => ['invalid */ message %service_id%'],
             'message not containing require %service_id% variable' => ['this is deprecated'],
-            'template not containing require %service_id% variable' => [true],
         ];
     }
 

src/Symfony/Component/DomCrawler/UriResolver.php

@@ -71,7 +71,7 @@ public static function resolve(string $uri, ?string $baseUri): string
 
         // relative path
         $path = parse_url(substr($baseUri, \strlen($baseUriCleaned)), \PHP_URL_PATH) ?? '';
-        $path = self::canonicalizePath(substr($path, 0, strrpos($path, '/')).'/'.$uri);
+        $path = self::canonicalizePath((str_contains($path, '/') ? substr($path, 0, strrpos($path, '/')) : '').'/'.$uri);
 
         return $baseUriCleaned.('' === $path || '/' !== $path[0] ? '/' : '').$path;
     }

src/Symfony/Component/ErrorHandler/DebugClassLoader.php

@@ -380,7 +380,7 @@ public function checkAnnotations(\ReflectionClass $refl, string $class): array
 
         // Don't trigger deprecations for classes in the same vendor
         if ($class !== $className) {
-            $vendor = preg_match('/^namespace ([^;\\\\\s]++)[;\\\\]/m', @file_get_contents($refl->getFileName()), $vendor) ? $vendor[1].'\\' : '';
+            $vendor = $refl->getFileName() && preg_match('/^namespace ([^;\\\\\s]++)[;\\\\]/m', @file_get_contents($refl->getFileName()) ?: '', $vendor) ? $vendor[1].'\\' : '';
             $vendorLen = \strlen($vendor);
         } elseif (2 > $vendorLen = 1 + (strpos($class, '\\') ?: strpos($class, '_'))) {
             $vendorLen = 0;