bug symfony#59648 [HttpClient] Fix retrying requests with Psr18Client and NTLM connections (nicolas-grekas, ajgarlag)

This PR was merged into the 7.2 branch.

Discussion
----------

[HttpClient] Fix retrying requests with `Psr18Client` and NTLM connections

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#59489, Fix symfony#59629
| License       | MIT

Commits
-------

b647cdf Prevent empty request body stream in HttplugClient and Psr18Client
f0239d8 [HttpClient] Fix retrying requests with Psr18Client and NTLM connections

Author: nicolas-grekas

src/Symfony/Component/HttpClient/CurlHttpClient.php

@@ -236,6 +236,10 @@ public function request(string $method, string $url, array $options = []): Respo
         }
 
         if (!\is_string($body)) {
+            if (isset($options['auth_ntlm'])) {
+                $curlopts[\CURLOPT_FORBID_REUSE] = true; // Reusing NTLM connections requires seeking capability, which only string bodies support
+            }
+
             if (\is_resource($body)) {
                 $curlopts[\CURLOPT_INFILE] = $body;
             } else {

src/Symfony/Component/HttpClient/HttplugClient.php

@@ -224,23 +224,44 @@ private function sendPsr7Request(RequestInterface $request, ?bool $buffer = null
     {
         try {
             $body = $request->getBody();
+            $headers = $request->getHeaders();
 
-            if ($body->isSeekable()) {
-                try {
-                    $body->seek(0);
-                } catch (\RuntimeException) {
-                    // ignore
-                }
+            $size = $request->getHeader('content-length')[0] ?? -1;
+            if (0 > $size && 0 < $size = $body->getSize() ?? -1) {
+                $headers['Content-Length'] = [$size];
             }
 
-            $headers = $request->getHeaders();
-            if (!$request->hasHeader('content-length') && 0 <= $size = $body->getSize() ?? -1) {
-                $headers['Content-Length'] = [$size];
+            if (0 === $size) {
+                $body = '';
+            } elseif (0 < $size && $size < 1 << 21) {
+                if ($body->isSeekable()) {
+                    try {
+                        $body->seek(0);
+                    } catch (\RuntimeException) {
+                        // ignore
+                    }
+                }
+
+                $body = $body->getContents();
+            } else {
+                $body = static function (int $size) use ($body) {
+                    if ($body->isSeekable()) {
+                        try {
+                            $body->seek(0);
+                        } catch (\RuntimeException) {
+                            // ignore
+                        }
+                    }
+
+                    while (!$body->eof()) {
+                        yield $body->read($size);
+                    }
+                };
             }
 
             $options = [
                 'headers' => $headers,
-                'body' => static fn (int $size) => $body->read($size),
+                'body' => $body,
                 'buffer' => $buffer,
             ];
 

src/Symfony/Component/HttpClient/Psr18Client.php

@@ -88,23 +88,44 @@ public function sendRequest(RequestInterface $request): ResponseInterface
     {
         try {
             $body = $request->getBody();
+            $headers = $request->getHeaders();
 
-            if ($body->isSeekable()) {
-                try {
-                    $body->seek(0);
-                } catch (\RuntimeException) {
-                    // ignore
-                }
+            $size = $request->getHeader('content-length')[0] ?? -1;
+            if (0 > $size && 0 < $size = $body->getSize() ?? -1) {
+                $headers['Content-Length'] = [$size];
             }
 
-            $headers = $request->getHeaders();
-            if (!$request->hasHeader('content-length') && 0 <= $size = $body->getSize() ?? -1) {
-                $headers['Content-Length'] = [$size];
+            if (0 === $size) {
+                $body = '';
+            } elseif (0 < $size && $size < 1 << 21) {
+                if ($body->isSeekable()) {
+                    try {
+                        $body->seek(0);
+                    } catch (\RuntimeException) {
+                        // ignore
+                    }
+                }
+
+                $body = $body->getContents();
+            } else {
+                $body = static function (int $size) use ($body) {
+                    if ($body->isSeekable()) {
+                        try {
+                            $body->seek(0);
+                        } catch (\RuntimeException) {
+                            // ignore
+                        }
+                    }
+
+                    while (!$body->eof()) {
+                        yield $body->read($size);
+                    }
+                };
             }
 
             $options = [
                 'headers' => $headers,
-                'body' => static fn (int $size) => $body->read($size),
+                'body' => $body,
             ];
 
             if ('1.0' === $request->getProtocolVersion()) {