use value of DIRECTORY_SEPARATOR to detect Windows

xabbuh · xabbuh · commit 0bf19b8d2320 · 2014-12-31T10:20:32.000+01:00
This commit unifies the detection of Windows builds across the Symfony
codebase.
diff --git a/Dumper/CliDumper.php b/Dumper/CliDumper.php
@@ -52,7 +52,7 @@ public function __construct($output = null)
     {
         parent::__construct($output);
 
-        if (defined('PHP_WINDOWS_VERSION_MAJOR') && false !== @getenv('ANSICON')) {
+        if ('\\' === DIRECTORY_SEPARATOR && false !== @getenv('ANSICON')) {
             // Use only the base 16 xterm colors when using ANSICON
             $this->setStyles(array(
                 'default' => '31',
@@ -394,7 +394,7 @@ protected function supportsColors()
             }
         }
 
-        if (defined('PHP_WINDOWS_VERSION_MAJOR')) {
+        if ('\\' === DIRECTORY_SEPARATOR) {
             static::$defaultColors = @(false !== getenv('ANSICON') || 'ON' === getenv('ConEmuANSI'));
         } elseif (function_exists('posix_isatty')) {
             $h = stream_get_meta_data($this->outputStream) + array('wrapper_type' => null);

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function __construct($output = null)`
`52`	`52`	`{`
`53`	`53`	`parent::__construct($output);`
`54`	`54`
`55`		`- if (defined('PHP_WINDOWS_VERSION_MAJOR') && false !== @getenv('ANSICON')) {`
	`55`	`+ if ('\\' === DIRECTORY_SEPARATOR && false !== @getenv('ANSICON')) {`
`56`	`56`	`// Use only the base 16 xterm colors when using ANSICON`
`57`	`57`	`$this->setStyles(array(`
`58`	`58`	`'default' => '31',`
`@@ -394,7 +394,7 @@ protected function supportsColors()`
`394`	`394`	`}`
`395`	`395`	`}`
`396`	`396`
`397`		`- if (defined('PHP_WINDOWS_VERSION_MAJOR')) {`
	`397`	`+ if ('\\' === DIRECTORY_SEPARATOR) {`
`398`	`398`	`static::$defaultColors = @(false !== getenv('ANSICON') \|\| 'ON' === getenv('ConEmuANSI'));`
`399`	`399`	`} elseif (function_exists('posix_isatty')) {`
`400`	`400`	`$h = stream_get_meta_data($this->outputStream) + array('wrapper_type' => null);`