feature #3045 Ensure PHP 8.5 compatibility (Kocal)

Kocal · Kocal · commit 1de49076df9d · 2025-08-22T16:39:10.000+02:00
This PR was merged into the 2.x branch. Discussion ---------- Ensure PHP 8.5 compatibility | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes  | Docs? | yes  | Issues | Fix #...  | License | MIT  Commits ------- 0f7eb82 Ensure PHP 8.5 compatibility
diff --git a/.github/workflows/code-quality.yaml b/.github/workflows/code-quality.yaml
@@ -49,7 +49,7 @@ jobs:
                 include:
                     # dev packages (probably not needed to have multiple such jobs)
                     - minimum-stability: 'dev'
-                      php-version: 8.4
+                      php-version: 8.5
                     # lowest deps
                     - dependency-version: 'lowest'
                     # LTS version of Symfony
diff --git a/.github/workflows/functional-tests.yml b/.github/workflows/functional-tests.yml
@@ -21,15 +21,15 @@ jobs:
         strategy:
            fail-fast: false
            matrix:
-               php-version: ['8.1', '8.2', '8.3', '8.4']
+               php-version: ['8.1', '8.2', '8.3', '8.4', '8.5']
                dependency-version: ['']
                symfony-version: ['']
                minimum-stability: ['stable']
                os: ['']
                include:
                    # dev packages (probably not needed to have multiple such jobs)
                    -   minimum-stability: 'dev'
-                       php-version: '8.4'
+                       php-version: '8.5'
                    # lowest deps
                    -   php-version: '8.1'
                        dependency-version: 'lowest'
diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml
@@ -28,15 +28,15 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php-version: ['8.1', '8.2', '8.3', '8.4']
+                php-version: ['8.1', '8.2', '8.3', '8.4', '8.5']
                 dependency-version: ['']
                 symfony-version: ['']
                 minimum-stability: ['stable']
                 os: ['']
                 include:
                     # dev packages (probably not needed to have multiple such jobs)
                     -   minimum-stability: 'dev'
-                        php-version: '8.4'
+                        php-version: '8.5'
                     # lowest deps
                     -   php-version: '8.1'
                         dependency-version: 'lowest'
@@ -50,8 +50,8 @@ jobs:
                     -  php-version: '8.1'
                        symfony-version: '6.4.*'
                     -  php-version: '8.2'
-                       symfony-version: '7.3.*' # TODO: change to '7.4' when Symfony 7.4 is released
-                    -  php-version: '8.4'
+                       symfony-version: '7.4.x-dev' # TODO: change to '7.4' when Symfony 7.4 is released
+                    -  php-version: '8.5'
                        symfony-version: '8.0.x-dev' # TODO: change to '8.0' when Symfony 8.0 is released
                        minimum-stability: 'dev' # TODO: remove when Symfony 8.0 is released
 
diff --git a/src/Autocomplete/CHANGELOG.md b/src/Autocomplete/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Chartjs/CHANGELOG.md b/src/Chartjs/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Cropperjs/CHANGELOG.md b/src/Cropperjs/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Dropzone/CHANGELOG.md b/src/Dropzone/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Icons/CHANGELOG.md b/src/Icons/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/LazyImage/CHANGELOG.md b/src/LazyImage/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/LiveComponent/CHANGELOG.md b/src/LiveComponent/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Map/CHANGELOG.md b/src/Map/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## 2.30
 
+- Ensure compatibility with PHP 8.5
+
+## 2.30
+
 -  Deprecate option `title` from `Polygon`, `Polyline`, `Rectangle` and `Circle` in favor of `infoWindow`
 
 ## 2.29.0
diff --git a/src/Map/src/Bridge/Google/CHANGELOG.md b/src/Map/src/Bridge/Google/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Map/src/Bridge/Google/tests/GoogleRendererTest.php b/src/Map/src/Bridge/Google/tests/GoogleRendererTest.php
@@ -71,7 +71,7 @@ public static function provideTestRenderMap(): iterable
                 ->addMarker($marker1)
                 ->addMarker($marker2)
                 ->removeMarker($marker1)
-                ->removeMarker($marker2),
+                ->removeMarker('marker2'),
         ];
 
         yield 'with marker remove and new ones added' => [
diff --git a/src/Map/src/Bridge/Leaflet/CHANGELOG.md b/src/Map/src/Bridge/Leaflet/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Map/src/Bridge/Leaflet/tests/LeafletRendererTest.php b/src/Map/src/Bridge/Leaflet/tests/LeafletRendererTest.php
@@ -66,7 +66,7 @@ public static function provideTestRenderMap(): iterable
                 ->addMarker($marker1)
                 ->addMarker($marker2)
                 ->removeMarker($marker1)
-                ->removeMarker($marker2),
+                ->removeMarker('marker2'),
         ];
 
         yield 'with marker remove and new ones added' => [
diff --git a/src/Map/src/Elements.php b/src/Map/src/Elements.php
@@ -27,18 +27,18 @@ public function __construct(
     ) {
         $this->elements = new \SplObjectStorage();
         foreach ($elements as $element) {
-            $this->elements->attach($element);
+            $this->add($element);
         }
     }
 
     public function add(Element $element): static
     {
-        $this->elements->attach($element, $element->id ?? $this->elements->getHash($element));
+        $this->elements[$element] = $element->id ?? $this->elements->getHash($element);
 
         return $this;
     }
 
-    private function getElement(string $id): ?Element
+    private function getElementById(string $id): ?Element
     {
         foreach ($this->elements as $element) {
             if ($element->id === $id) {
@@ -52,15 +52,13 @@ private function getElement(string $id): ?Element
     public function remove(Element|string $elementOrId): static
     {
         if (\is_string($elementOrId)) {
-            $elementOrId = $this->getElement($elementOrId);
+            $element = $this->getElementById($elementOrId);
+        } else {
+            $element = $elementOrId;
         }
 
-        if (null === $elementOrId) {
-            return $this;
-        }
-
-        if ($this->elements->contains($elementOrId)) {
-            $this->elements->detach($elementOrId);
+        if (null !== $element && $this->elements->offsetExists($element)) {
+            unset($this->elements[$element]);
         }
 
         return $this;
diff --git a/src/Notify/CHANGELOG.md b/src/Notify/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/React/CHANGELOG.md b/src/React/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/StimulusBundle/CHANGELOG.md b/src/StimulusBundle/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Svelte/CHANGELOG.md b/src/Svelte/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Swup/CHANGELOG.md b/src/Swup/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/TogglePassword/CHANGELOG.md b/src/TogglePassword/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Toolkit/src/Installer/PoolResolver.php b/src/Toolkit/src/Installer/PoolResolver.php
@@ -37,11 +37,11 @@ public function resolveForRecipe(Kit $kit, Recipe $recipe): Pool
             $currentRecipe = array_pop($recipesStack);
 
             // Skip circular references
-            if ($visitedRecipes->contains($currentRecipe)) {
+            if ($visitedRecipes->offsetExists($currentRecipe)) {
                 continue;
             }
 
-            $visitedRecipes->attach($currentRecipe);
+            $visitedRecipes[$currentRecipe] = null;
 
             foreach ($currentRecipe->getFiles() as $file) {
                 $pool->addFile($currentRecipe, $file);
diff --git a/src/Translator/CHANGELOG.md b/src/Translator/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Turbo/CHANGELOG.md b/src/Turbo/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/TwigComponent/CHANGELOG.md b/src/TwigComponent/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/TwigComponent/src/Command/TwigComponentDebugCommand.php b/src/TwigComponent/src/Command/TwigComponentDebugCommand.php
@@ -298,7 +298,7 @@ private function getComponentProperties(ComponentMetadata $metadata): array
                 } else {
                     $typeName = (string) $type;
                 }
-                $value = $property->getDefaultValue();
+                $value = $property->hasDefaultValue() ? $property->getDefaultValue() : null;
                 $propertyDisplay = $typeName.' $'.$propertyName.(null !== $value ? ' = '.json_encode($value) : '');
                 $properties[$property->name] = $propertyDisplay;
             }
diff --git a/src/Typed/CHANGELOG.md b/src/Typed/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
diff --git a/src/Vue/CHANGELOG.md b/src/Vue/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.30
+
+- Ensure compatibility with PHP 8.5
+
 ## 2.29.0
 
 -  Add Symfony 8 support
