minor #24613 Remove redundant sprintf argument. (Aliance)

This PR was merged into the 2.7 branch.

Discussion
----------

Remove redundant sprintf argument.

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22820
| License       | MIT
| Doc PR        | –

cc @fabpot @ogizanagi

Commits
-------

c8012f0448 Remove redundant sprintf arguments.

Author: Tobion

Extension/CodeExtension.php

@@ -68,9 +68,9 @@ public function abbrMethod($method)
             list($class, $method) = explode('::', $method, 2);
             $result = sprintf('%s::%s()', $this->abbrClass($class), $method);
         } elseif ('Closure' === $method) {
-            $result = sprintf('<abbr title="%s">%s</abbr>', $method, $method);
+            $result = sprintf('<abbr title="%s">%1$s</abbr>', $method);
         } else {
-            $result = sprintf('<abbr title="%s">%s</abbr>()', $method, $method);
+            $result = sprintf('<abbr title="%s">%1$s</abbr>()', $method);
         }
 
         return $result;

Tests/Node/FormThemeTest.php

@@ -74,11 +74,11 @@ public function testCompile()
     protected function getVariableGetter($name)
     {
         if (\PHP_VERSION_ID >= 70000) {
-            return sprintf('($context["%s"] ?? null)', $name, $name);
+            return sprintf('($context["%s"] ?? null)', $name);
         }
 
         if (\PHP_VERSION_ID >= 50400) {
-            return sprintf('(isset($context["%s"]) ? $context["%s"] : null)', $name, $name);
+            return sprintf('(isset($context["%s"]) ? $context["%1$s"] : null)', $name);
         }
 
         return sprintf('$this->getContext($context, "%s")', $name);

Tests/Node/SearchAndRenderBlockNodeTest.php

@@ -272,11 +272,11 @@ public function testCompileLabelWithLabelThatEvaluatesToNullAndAttributes()
     protected function getVariableGetter($name)
     {
         if (\PHP_VERSION_ID >= 70000) {
-            return sprintf('($context["%s"] ?? null)', $name, $name);
+            return sprintf('($context["%s"] ?? null)', $name);
         }
 
         if (\PHP_VERSION_ID >= 50400) {
-            return sprintf('(isset($context["%s"]) ? $context["%s"] : null)', $name, $name);
+            return sprintf('(isset($context["%s"]) ? $context["%1$s"] : null)', $name);
         }
 
         return sprintf('$this->getContext($context, "%s")', $name);

Tests/Node/TransNodeTest.php

@@ -45,11 +45,11 @@ public function testCompileStrict()
     protected function getVariableGetterWithoutStrictCheck($name)
     {
         if (\PHP_VERSION_ID >= 70000) {
-            return sprintf('($context["%s"] ?? null)', $name, $name);
+            return sprintf('($context["%s"] ?? null)', $name);
         }
 
         if (\PHP_VERSION_ID >= 50400) {
-            return sprintf('(isset($context["%s"]) ? $context["%s"] : null)', $name, $name);
+            return sprintf('(isset($context["%s"]) ? $context["%1$s"] : null)', $name);
         }
 
         return sprintf('$this->getContext($context, "%s", true)', $name);
@@ -58,15 +58,15 @@ protected function getVariableGetterWithoutStrictCheck($name)
     protected function getVariableGetterWithStrictCheck($name)
     {
         if (Environment::MAJOR_VERSION >= 2) {
-            return sprintf('(isset($context["%s"]) || array_key_exists("%s", $context) ? $context["%s"] : (function () { throw new Twig_Error_Runtime(\'Variable "%s" does not exist.\', 0, $this->getSourceContext()); })())', $name, $name, $name, $name);
+            return sprintf('(isset($context["%s"]) || array_key_exists("%1$s", $context) ? $context["%1$s"] : (function () { throw new Twig_Error_Runtime(\'Variable "%1$s" does not exist.\', 0, $this->getSourceContext()); })())', $name);
         }
 
         if (\PHP_VERSION_ID >= 70000) {
-            return sprintf('($context["%s"] ?? $this->getContext($context, "%s"))', $name, $name, $name);
+            return sprintf('($context["%s"] ?? $this->getContext($context, "%1$s"))', $name);
         }
 
         if (\PHP_VERSION_ID >= 50400) {
-            return sprintf('(isset($context["%s"]) ? $context["%s"] : $this->getContext($context, "%s"))', $name, $name, $name);
+            return sprintf('(isset($context["%s"]) ? $context["%1$s"] : $this->getContext($context, "%1$s"))', $name);
         }
 
         return sprintf('$this->getContext($context, "%s")', $name);