improve deprecation messages

Author: xabbuh

DependencyInjection/TranslatorPass.php

@@ -27,7 +27,7 @@ class TranslatorPass implements CompilerPassInterface
     public function __construct($translatorServiceId = 'translator.default', $readerServiceId = 'translation.loader', $loaderTag = 'translation.loader', $debugCommandServiceId = 'console.command.translation_debug', $updateCommandServiceId = 'console.command.translation_update')
     {
         if ('translation.loader' === $readerServiceId && 2 > func_num_args()) {
-            @trigger_error('The default value for $readerServiceId will change in 4.0 to "translation.reader".', E_USER_DEPRECATED);
+            @trigger_error(sprintf('The default value for $readerServiceId in "%s()" will change in 4.0 to "translation.reader".', __METHOD__), E_USER_DEPRECATED);
         }
 
         $this->translatorServiceId = $translatorServiceId;

Tests/DependencyInjection/TranslationPassTest.php

@@ -57,7 +57,7 @@ public function testValidCollector()
 
     /**
      * @group legacy
-     * @expectedDeprecation The default value for $readerServiceId will change in 4.0 to "translation.reader".
+     * @expectedDeprecation The default value for $readerServiceId in "Symfony\Component\Translation\DependencyInjection\TranslatorPass::__construct()" will change in 4.0 to "translation.reader".
      *
      * A test that verifies the deprecated "translation.loader" gets the LoaderInterfaces added.
      *

Tests/Writer/TranslationWriterTest.php

@@ -20,7 +20,7 @@ class TranslationWriterTest extends TestCase
 {
     /**
      * @group legacy
-     * @expectedDeprecation Method Symfony\Component\Translation\Writer\TranslationWriter::writeTranslations() is deprecated since Symfony 3.4 and will be removed in 4.0. Use write() instead.
+     * @expectedDeprecation The "Symfony\Component\Translation\Writer\TranslationWriter::writeTranslations()" method is deprecated since Symfony 3.4 and will be removed in 4.0. Use write() instead.
      */
     public function testWriteTranslations()
     {

Translator.php

@@ -87,7 +87,7 @@ public function __construct($locale, $formatter = null, $cacheDir = null, $debug
 
         if ($formatter instanceof MessageSelector) {
             $formatter = new MessageFormatter($formatter);
-            @trigger_error(sprintf('Passing a "%s" instance into the "%s" as a second argument is deprecated since Symfony 3.4 and will be removed in 4.0. Inject a "%s" implementation instead.', MessageSelector::class, __METHOD__, MessageFormatterInterface::class), E_USER_DEPRECATED);
+            @trigger_error(sprintf('Passing a "%s" instance into the "%s()" method as a second argument is deprecated since Symfony 3.4 and will be removed in 4.0. Inject a "%s" implementation instead.', MessageSelector::class, __METHOD__, MessageFormatterInterface::class), E_USER_DEPRECATED);
         } elseif (null === $formatter) {
             $formatter = new MessageFormatter();
         }

Writer/TranslationWriter.php

@@ -97,7 +97,7 @@ public function write(MessageCatalogue $catalogue, $format, $options = array())
      */
     public function writeTranslations(MessageCatalogue $catalogue, $format, $options = array())
     {
-        @trigger_error(sprintf('Method %s() is deprecated since Symfony 3.4 and will be removed in 4.0. Use write() instead.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.4 and will be removed in 4.0. Use write() instead.', __METHOD__), E_USER_DEPRECATED);
         $this->write($catalogue, $format, $options);
     }
 }