Merge branch '4.0'

* 4.0: (26 commits)
  Fixed the default value for toolbar configuration
  Remove leading slash from rm -rf /vendor/*
  Recommend being lenient only with other vendors
  Close the tag
  Using better cache syntax
  Using PHPUNIT_FLAGS
  Added back php-versions
  Moved coverage to PHP 7.2 with latest deps
  Fixed minor things
  Fixed typos and created more variables
  Added comment and install simple-phpunit deps
  Use tilde or composer validate will never pass
  ...

Author: javiereguiluz

bundles.rst

@@ -53,7 +53,7 @@ Start by creating a ``src/Acme/TestBundle/`` directory and adding a new file
 called ``AcmeTestBundle.php``::
 
     // src/Acme/TestBundle/AcmeTestBundle.php
-    namespace Acme\TestBundle;
+    namespace App\Acme\TestBundle;
 
     use Symfony\Component\HttpKernel\Bundle\Bundle;
 
@@ -75,7 +75,7 @@ of the bundle. Now that you've created the bundle, enable it::
     // config/bundles.php
     return [
         // ...
-        Acme\TestBundle\AcmeTestBundle::class => ['all' => true],
+        App\Acme\TestBundle\AcmeTestBundle::class => ['all' => true],
     ];
 
 And while it doesn't do anything yet, AcmeTestBundle is now ready to be used.

bundles/best_practices.rst

@@ -166,6 +166,80 @@ the ``Tests/`` directory. Tests should follow the following principles:
     A test suite must not contain ``AllTests.php`` scripts, but must rely on the
     existence of a ``phpunit.xml.dist`` file.
 
+Continuous Integration
+----------------------
+
+Testing bundle code continuously, including all its commits and pull requests,
+is a good practice called Continuous Integration. There are several services
+providing this feature for free for open source projects. The most popular
+service for Symfony bundles is called `Travis CI`_.
+
+Here is the recommended configuration file (``.travis.yml``) for Symfony bundles,
+which test the two latest :doc:`LTS versions </contributing/community/releases>`
+of Symfony and the latest beta release:
+
+.. code-block:: yaml
+
+    language: php
+    sudo: false
+    cache:
+        directories:
+            - $HOME/.composer/cache/files
+            - $HOME/symfony-bridge/.phpunit
+
+    env:
+        global:
+            - PHPUNIT_FLAGS="-v"
+            - SYMFONY_PHPUNIT_DIR="$HOME/symfony-bridge/.phpunit"
+
+    matrix:
+        fast_finish: true
+        include:
+              # Minimum supported dependencies with the latest and oldest PHP version
+            - php: 7.2
+              env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak_vendors"
+            - php: 7.0
+              env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak_vendors"
+
+              # Test the latest stable release
+            - php: 7.0
+            - php: 7.1
+            - php: 7.2
+              env: COVERAGE=true PHPUNIT_FLAGS="-v --coverage-text"
+
+              # Test LTS versions. This makes sure we do not use Symfony packages with version greater
+              # than 2 or 3 respectively. Read more at https://github.com/symfony/lts
+            - php: 7.2
+              env: DEPENDENCIES="symfony/lts:^2"
+            - php: 7.2
+              env: DEPENDENCIES="symfony/lts:^3"
+
+              # Latest commit to master
+            - php: 7.2
+              env: STABILITY="dev"
+
+        allow_failures:
+              # Dev-master is allowed to fail.
+            - env: STABILITY="dev"
+
+    before_install:
+        - if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi
+        - if ! [ -z "$STABILITY" ]; then composer config minimum-stability ${STABILITY}; fi;
+        - if ! [ -v "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi;
+
+    install:
+        # To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
+        - if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
+        - composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
+        - ./vendor/bin/simple-phpunit install
+
+    script:
+        - composer validate --strict --no-check-lock
+        - ./vendor/bin/simple-phpunit $PHPUNIT_FLAGS
+
+Consider using `Travis cron`_ too to make sure your project is built even if
+there are no new pull requests or commits.
+
 Installation
 ------------
 
@@ -476,3 +550,5 @@ Learn more
 .. _`Packagist`: https://packagist.org/
 .. _`choose any license`: http://choosealicense.com/
 .. _`valid license identifier`: https://spdx.org/licenses/
+.. _`Travis CI`: https://travis-ci.org/
+.. _`Travis Cron`: https://docs.travis-ci.com/user/cron-jobs/

bundles/override.rst

@@ -56,8 +56,9 @@ example, the implementing class for the ``original-service-id`` is changed to
     // ...
     + use App\Service\YourService;
     + use Symfony\Component\DependencyInjection\ContainerBuilder;
+    + use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 
-    class Kernel extends BaseKernel
+    class Kernel extends BaseKernel implements CompilerPassInterface
     {
     +     public function process(ContainerBuilder $container)
     +     {

doctrine.rst

@@ -580,6 +580,7 @@ But what if you need a more complex query? When you generated your entity with
 
     use App\Entity\Product;
     use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
+    use Symfony\Bridge\Doctrine\RegistryInterface;
 
     class ProductRepository extends ServiceEntityRepository
     {

page_creation.rst

@@ -281,9 +281,12 @@ project:
 
 ``src/``
     All your PHP code lives here.
+    
+``templates/``
+    All your Twig templates live here.
 
-Most of the time, you'll be working in ``src/`` (PHP files) or ``config/`` As you
-keep reading, you'll learn what can be done inside each of these.
+Most of the time, you'll be working in ``src/``, ``templates/`` or ``config/``.
+As you keep reading, you'll learn what can be done inside each of these.
 
 So what about the other directories in the project?
 

reference/configuration/web_profiler.rst

@@ -21,7 +21,7 @@ Configuration
 toolbar
 ~~~~~~~
 
-**type**: ``boolean`` **default**: ``true``
+**type**: ``boolean`` **default**: ``false``
 
 It enables and disables the toolbar entirely. Usually you set this to ``true``
 in the ``dev`` and ``test`` environments and to ``false`` in the ``prod``

reference/forms/types/collection.rst

@@ -212,7 +212,7 @@ And update the template as follows:
 
         <a href="#"
             class="add-another-collection-widget"
-            data-list="#email-field-list>Add another email</a>
+            data-list="#email-field-list">Add another email</a>
 
         {# ... #}
     {{ form_end(form) }}

setup/file_permissions.rst

@@ -15,5 +15,5 @@ was writable. But that is no longer true! In Symfony 4, everything works automat
 
     If you decide to store log files on disk, you *will* need to make sure your
     logs directory (e.g. ``var/log/``) is writable by your web server user and
-    terminal user. One way this can be done is by using ``chmod 777 -R var/log/``.
+    terminal user. One way this can be done is by using ``chmod -R 777 var/log/``.
     Just be aware that your logs are readable by any user on your production system.

setup/flex.rst

@@ -195,7 +195,7 @@ manual steps:
 
    .. code-block:: terminal
 
-       $ rm -fr /vendor/*
+       $ rm -fr vendor/*
        $ composer install
 
 #. No matter which of the previous steps you followed. At this point, you'll have