Merge branch '4.4' into 5.0

* 4.4:
  Update mailer.rst
  Update ssi.rst
  Fixed some minor issues
  Update form.rst
  Update workflow.rst

Author: javiereguiluz

components/form.rst

@@ -383,7 +383,7 @@ Creating a simple Form
 
     If you're using the Symfony Framework, then the form factory is available
     automatically as a service called ``form.factory``. Also, the default
-    base controller class has a :method:`Symfony\\Bundle\\FrameworkBundle\\Controller::createFormBuilder`
+    base controller class has a :method:`Symfony\\Bundle\\FrameworkBundle\\Controller\\AbstractController::createFormBuilder`
     method, which is a shortcut to fetch the form factory and call ``createBuilder()``
     on it.
 

http_cache/ssi.rst

@@ -114,7 +114,7 @@ The profile index page has not public caching, but the GDPR block has
     {# templates/profile/index.html.twig #}
 
     {# you can use a controller reference #}
-    {{ render_ssi(controller('App\Controller\ProfileController::gdpr')) }}
+    {{ render_ssi(controller('App\\Controller\\ProfileController::gdpr')) }}
 
     {# ... or a URL #}
     {{ render_ssi(url('profile_gdpr')) }}

mailer.rst

@@ -277,6 +277,29 @@ images inside the HTML contents::
         ->html('<img src="cid:logo"> ... <img src="cid:footer-signature"> ...')
     ;
 
+Handling Sending Failures
+-------------------------
+
+Symfony Mailer considers that sending was successful when your transport (SMTP
+server or third-party provider) accepts the mail for further delivery. The message
+can later be lost or not delivered because of some problem in your provider, but
+that's out of reach for your Symfony application.
+
+If there's an error when handing over the email to your transport, Symfony throws
+a :class:`Symfony\\Component\\Mailer\\Exception\\TransportExceptionInterface`.
+Catch that exception to recover from the error or to display some message::
+
+    use Symfony\Component\Mailer\Exception\TransportExceptionInterface;
+
+    $email = new Email();
+    // ...
+    try {
+        $mailer->send($email);
+    } catch (TransportExceptionInterface $e) {
+        // some error prevented the email sending; display an
+        // error message or try to resend the message
+    }
+
 Debugging Emails
 ----------------
 

workflow.rst

@@ -165,9 +165,12 @@ like this:
 
 The configured property will be used via it's implemented getter/setter methods by the marking store::
 
+    // src/Entity/BlogPost.php
+    namespace App\Entity;
+
     class BlogPost
     {
-        // the configured property must be declared
+        // the configured marking store property must be declared
         private $currentPlace;
         private $title;
         private $content;
@@ -236,11 +239,11 @@ Accessing the Workflow in a Class
 To access workflow inside a class, use dependency injection and inject the
 registry in the constructor::
 
+    use App\Entity\BlogPost;
     use Symfony\Component\Workflow\Registry;
 
     class MyClass
     {
-
         private $workflowRegistry;
 
         public function __construct(Registry $workflowRegistry)
@@ -356,11 +359,14 @@ order:
 Here is an example of how to enable logging for every time a "blog_publishing"
 workflow leaves a place::
 
+    // src/App/EventSubscriber/WorkflowLoggerSubscriber.php
+    namespace App\EventSubscriber;
+
     use Psr\Log\LoggerInterface;
     use Symfony\Component\EventDispatcher\EventSubscriberInterface;
     use Symfony\Component\Workflow\Event\Event;
 
-    class WorkflowLogger implements EventSubscriberInterface
+    class WorkflowLoggerSubscriber implements EventSubscriberInterface
     {
         private $logger;
 
@@ -406,14 +412,18 @@ list of the guard event names.
 This example stops any blog post being transitioned to "reviewed" if it is
 missing a title::
 
+    // src/App/EventSubscriber/BlogPostReviewSubscriber.php
+    namespace App\EventSubscriber;
+
+    use App\Entity\BlogPost;
     use Symfony\Component\EventDispatcher\EventSubscriberInterface;
     use Symfony\Component\Workflow\Event\GuardEvent;
 
-    class BlogPostReviewListener implements EventSubscriberInterface
+    class BlogPostReviewSubscriber implements EventSubscriberInterface
     {
         public function guardReview(GuardEvent $event)
         {
-            /** @var App\Entity\BlogPost $post */
+            /** @var BlogPost $post */
             $post = $event->getSubject();
             $title = $post->title;
 
@@ -595,13 +605,14 @@ This example has been simplified; in production you may prefer to use the
 :doc:`Translation </translation>` component to manage messages in one
 place::
 
-    namespace App\Listener\Workflow\Task;
+    // src/App/EventSubscriber/BlogPostPublishSubscriber.php
+    namespace App\EventSubscriber;
 
     use Symfony\Component\EventDispatcher\EventSubscriberInterface;
     use Symfony\Component\Workflow\Event\GuardEvent;
     use Symfony\Component\Workflow\TransitionBlocker;
 
-    class BlogPostPublishListener implements EventSubscriberInterface
+    class BlogPostPublishSubscriber implements EventSubscriberInterface
     {
         public function guardPublish(GuardEvent $event)
         {
@@ -796,10 +807,12 @@ requires:
 
 Then you can access this metadata in your controller as follows::
 
+    // src/App/Controller/BlogPostController.php
     use App\Entity\BlogPost;
     use Symfony\Component\Workflow\Registry;
+    // ...
 
-    public function myController(Registry $registry, BlogPost $post)
+    public function myAction(Registry $registry, BlogPost $post)
     {
         $workflow = $registry->get($post);
 
@@ -818,6 +831,8 @@ Then you can access this metadata in your controller as follows::
             ->getMetadataStore()
             ->getTransitionMetadata($aTransition)['priority'] ?? 0
         ;
+
+        // ...
     }
 
 There is a ``getMetadata()`` method that works with all kinds of metadata::
@@ -867,7 +882,7 @@ In Twig templates, metadata is available via the ``workflow_metadata()`` functio
             {% for transition in workflow_transitions(blog_post) %}
                 <li>
                     {{ transition.name }}:
-                    <code>{{ workflow_metadata(blog_post, 'priority', transition) ?: '0' }}</code>
+                    <code>{{ workflow_metadata(blog_post, 'priority', transition) ?: 0 }}</code>
                 </li>
             {% endfor %}
         </ul>