Merge branch '2.8' into 3.3

* 2.8:
  minor #8205 Move JavaScript to separate file (technetium, javiereguiluz)
  [error_pages] Removing misleading  checker in code example
  add default option value for collection type
  minor #8831 Update collection.rst (babaorum)
  Move JavaScript to seperate file
  Remove section about forms using validation
  Removed extra class
  Renamed TestedTypeTests to TestedTypeTest
  Add docs about the validator TypeTestCase class

Author: javiereguiluz

controller/error_pages.rst

@@ -99,10 +99,6 @@ To override the 404 error template for HTML pages, create a new
     {% block body %}
         <h1>Page not found</h1>
 
-        {% if is_granted('IS_AUTHENTICATED_FULLY') %}
-            {# ... #}
-        {% endif %}
-
         <p>
             The requested page couldn't be located. Checkout for any URL
             misspelling or <a href="{{ path('homepage') }}">return to the homepage</a>.

form/unit_testing.rst

@@ -115,7 +115,7 @@ To solve this, you have to mock the injected dependencies, instantiate your own
 form type and use the :class:`Symfony\\Component\\Form\\PreloadedExtension` to
 make sure the ``FormRegistry`` uses the created instance::
 
-    // tests/AppBundle/Form/Type/TestedTypeTests.php
+    // tests/AppBundle/Form/Type/TestedTypeTest.php
     namespace Tests\AppBundle\Form\Type;
 
     use AppBundle\Form\Type\TestedType;
@@ -169,7 +169,7 @@ will be raised if you try to test a class that depends on other extensions.
 The :method:`Symfony\\Component\\Form\\Test\\TypeTestCase::getExtensions` method
 allows you to return a list of extensions to register::
 
-    // tests/AppBundle/Form/Type/TestedTypeTests.php
+    // tests/AppBundle/Form/Type/TestedTypeTest.php
     namespace Tests\AppBundle\Form\Type;
 
     // ...
@@ -220,7 +220,7 @@ Testing against Different Sets of Data
 If you are not familiar yet with PHPUnit's `data providers`_, this might be
 a good opportunity to use them::
 
-    // tests/AppBundle/Form/Type/TestedTypeTests.php
+    // tests/AppBundle/Form/Type/TestedTypeTest.php
     namespace Tests\AppBundle\Form\Type;
 
     use AppBundle\Form\Type\TestedType;

reference/forms/types/collection.rst

@@ -160,55 +160,64 @@ Using jQuery, a simple example might look like this. If you're rendering
 your collection fields all at once (e.g. ``form_row(form.emails)``), then
 things are even easier because the ``data-prototype`` attribute is rendered
 automatically for you (with a slight difference - see note below) and all
-you need is the JavaScript:
+you need is this JavaScript code:
+
+.. code-block:: javascript
+
+    // add-collection-widget.js
+    jQuery(document).ready(function () {
+        jQuery('.add-another-collection-widget').click(function (e) {
+            e.preventDefault();
+            var list = jQuery(jQuery(this).attr('data-list'));
+            // Try to find the counter of the list
+            var counter = list.data('widget-counter') | list.children().length;
+            // If the counter does not exist, use the length of the list
+            if (!counter) { counter = list.children().length; }
+
+            // grab the prototype template
+            var newWidget = list.attr('data-prototype');
+            // replace the "__name__" used in the id and name of the prototype
+            // with a number that's unique to your emails
+            // end name attribute looks like name="contact[emails][2]"
+            newWidget = newWidget.replace(/__name__/g, counter);
+            // Increase the counter
+            counter++;
+            // And store it, the length cannot be used if deleting widgets is allowed
+            list.data(' widget-counter', counter);
+
+            // create a new list element and add it to the list
+            var newElem = jQuery(list.attr('data-widget-tags')).html(newWidget);
+            newElem.appendTo(list);
+        });
+    });
+
+And update the template as follows:
+
+.. code-block:: html+twig
+
+    {{ form_start(form) }}
+        {# ... #}
+
+        {# store the prototype on the data-prototype attribute #}
+        <ul id="email-fields-list"
+            data-prototype="{{ form_widget(form.emails.vars.prototype)|e }}"
+            data-widget-tags="{{ '<li></li>'|e }}">
+        {% for emailField in form.emails %}
+            <li>
+                {{ form_errors(emailField) }}
+                {{ form_widget(emailField) }}
+            </li>
+        {% endfor %}
+        </ul>
 
-.. configuration-block::
+        <a href="#"
+            class="add-another-collection-widget"
+            data-list="#email-field-list>Add another email</a>
 
-    .. code-block:: html+twig
+        {# ... #}
+    {{ form_end(form) }}
 
-        {{ form_start(form) }}
-            {# ... #}
-
-            {# store the prototype on the data-prototype attribute #}
-            <ul id="email-fields-list"
-                data-prototype="{{ form_widget(form.emails.vars.prototype)|e }}">
-            {% for emailField in form.emails %}
-                <li>
-                    {{ form_errors(emailField) }}
-                    {{ form_widget(emailField) }}
-                </li>
-            {% endfor %}
-            </ul>
-
-            <a href="#" id="add-another-email">Add another email</a>
-
-            {# ... #}
-        {{ form_end(form) }}
-
-        <script type="text/javascript">
-            // keep track of how many email fields have been rendered
-            var emailCount = '{{ form.emails|length }}';
-
-            jQuery(document).ready(function() {
-                jQuery('#add-another-email').click(function(e) {
-                    e.preventDefault();
-
-                    var emailList = jQuery('#email-fields-list');
-
-                    // grab the prototype template
-                    var newWidget = emailList.attr('data-prototype');
-                    // replace the "__name__" used in the id and name of the prototype
-                    // with a number that's unique to your emails
-                    // end name attribute looks like name="contact[emails][2]"
-                    newWidget = newWidget.replace(/__name__/g, emailCount);
-                    emailCount++;
-
-                    // create a new list element and add it to the list
-                    var newLi = jQuery('<li></li>').html(newWidget);
-                    newLi.appendTo(emailList);
-                });
-            })
-        </script>
+    <script src="add-collection-widget.js"></script>
 
 .. tip::