Merge remote-tracking branch 'upstream/3.3' into 3.3

Author: javiereguiluz

best_practices/business-logic.rst

@@ -283,7 +283,7 @@ looking for mapping information:
          *      mappedBy="post",
          *      orphanRemoval=true
          * )
-         * @ORM\OrderBy({"publishedAt" = "ASC"})
+         * @ORM\OrderBy({"publishedAt"="ASC"})
          */
         private $comments;
 
@@ -359,6 +359,10 @@ were defined by the PHP community. You can learn more about
 use the `PHP-CS-Fixer`_, which is a command-line utility that can fix the
 coding standards of an entire codebase in a matter of seconds.
 
+----
+
+Next: :doc:`/best_practices/controllers`
+
 .. _`full definition`: https://en.wikipedia.org/wiki/Business_logic
 .. _`Doctrine project`: http://www.doctrine-project.org/
 .. _`fixture class`: https://symfony.com/doc/current/bundles/DoctrineFixturesBundle/index.html#writing-simple-fixtures

best_practices/configuration.rst

@@ -215,5 +215,9 @@ through environment variables:
     was added in Symfony 3.2. Prior to version 3.2, you needed to use the
     :doc:`special SYMFONY__ variables </configuration/external_parameters>`.
 
+----
+
+Next: :doc:`/best_practices/business-logic`
+
 .. _`feature toggles`: https://en.wikipedia.org/wiki/Feature_toggle
 .. _`constant() function`: http://twig.sensiolabs.org/doc/functions/constant.html

best_practices/controllers.rst

@@ -182,7 +182,7 @@ manually. In our application, we have this situation in ``CommentController``:
 .. code-block:: php
 
     /**
-     * @Route("/comment/{postSlug}/new", name = "comment_new")
+     * @Route("/comment/{postSlug}/new", name="comment_new")
      */
     public function newAction(Request $request, $postSlug)
     {
@@ -208,8 +208,8 @@ flexible:
     use Symfony\Component\HttpFoundation\Request;
 
     /**
-     * @Route("/comment/{postSlug}/new", name = "comment_new")
-     * @ParamConverter("post", options={"mapping": {"postSlug": "slug"}})
+     * @Route("/comment/{postSlug}/new", name="comment_new")
+     * @ParamConverter("post", options={"mapping"={"postSlug"="slug"}})
      */
     public function newAction(Request $request, Post $post)
     {
@@ -227,4 +227,8 @@ If you need to execute some code before or after the execution of your controlle
 you can use the EventDispatcher component to
 :doc:`set up before and after filters </event_dispatcher/before_after_filters>`.
 
+----
+
+Next: :doc:`/best_practices/templates`
+
 .. _`ParamConverter`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/converters.html

best_practices/creating-the-project.rst

@@ -168,6 +168,10 @@ structure of Symfony, you can
 :doc:`override the location of the main directories </configuration/override_dir_structure>`:
 ``cache/``, ``logs/`` and ``web/``.
 
+----
+
+Next: :doc:`/best_practices/configuration`
+
 .. _`Composer`: https://getcomposer.org/
 .. _`Phar extension`: http://php.net/manual/en/intro.phar.php
 .. _`public checksums repository`: https://github.com/sensiolabs/checksums

best_practices/forms.rst

@@ -207,3 +207,7 @@ handle everything.
 Second, is it required to call ``$form->isSubmitted()`` in the ``if`` statement
 before calling ``isValid()``. Calling ``isValid()`` with an unsubmitted form
 is deprecated since version 3.2 and will throw an exception in 4.0.
+
+----
+
+Next: :doc:`/best_practices/i18n`

best_practices/i18n.rst

@@ -93,4 +93,8 @@ English in the application would be:
         </file>
     </xliff>
 
+----
+
+Next: :doc:`/best_practices/security`
+
 .. _`JMSTranslationBundle`: https://github.com/schmittjoh/JMSTranslationBundle

best_practices/introduction.rst

@@ -98,5 +98,9 @@ practices**. The reasons for not doing it are various:
 * The amount of work spent on this could be better dedicated to improving
   your tests or adding features that provide real value to the end users.
 
+----
+
+Next: :doc:`/best_practices/creating-the-project`
+
 .. _`Fabien Potencier`: https://connect.sensiolabs.com/profile/fabpot
 .. _`download and install`: https://symfony.com/download

best_practices/security.rst

@@ -389,6 +389,10 @@ If your company uses a user login method not supported by Symfony, you can
 develop :doc:`your own user provider </security/custom_provider>` and
 :doc:`your own authentication provider </security/custom_authentication_provider>`.
 
+----
+
+Next: :doc:`/best_practices/web-assets`
+
 .. _`ParamConverter`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/converters.html
 .. _`@Security annotation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/security.html
 .. _`FOSUserBundle`: https://github.com/FriendsOfSymfony/FOSUserBundle

best_practices/templates.rst

@@ -150,5 +150,9 @@ If you're using the :ref:`default services.yml configuration <service-container-
 you're done! Symfony will automatically know about your new service and tag it to
 be used as a Twig extension.
 
+----
+
+Next: :doc:`/best_practices/forms`
+
 .. _`Twig`: http://twig.sensiolabs.org/
 .. _`Parsedown`: http://parsedown.org/

best_practices/web-assets.rst

@@ -95,4 +95,8 @@ with Assetic to reduce their size before serving them to the user. Check out
 the `official Assetic documentation`_ to learn more about all the available
 features.
 
+----
+
+Next: :doc:`/best_practices/tests`
+
 .. _`official Assetic documentation`: https://github.com/kriswallsmith/assetic