Merge branch '5.1' into master

* 5.1:
  typo
  do not document adding attachments through URLs
  Migrate Yaml config for DI calls to new syntax
  [#14076] fix typos

Author: xabbuh

components/dependency_injection.rst

@@ -259,7 +259,7 @@ config files:
             newsletter_manager:
                 class:     NewsletterManager
                 calls:
-                    - [setMailer, ['@mailer']]
+                    - setMailer: ['@mailer']
 
     .. code-block:: xml
 

form/create_custom_field_type.rst

@@ -68,7 +68,7 @@ the logic and rendering of that field type.
     The PHP class extension mechanism and the Symfony form field extension
     mechanism are not the same. The parent type returned in ``getParent()`` is
     what Symfony uses to build and manage the field type. Making the PHP class
-    extend from ``AbstractType`` is only a convenience way of implementing the
+    extend from ``AbstractType`` is only a convenient way of implementing the
     required ``FormTypeInterface``.
 
 Now you can add this form type when :doc:`creating Symfony forms </forms>`::

frontend/encore/postcss.rst

@@ -71,7 +71,8 @@ support. The best-practice is to configure this directly in your ``package.json`
     +  ]
     }
 
-The ``defaults`` option is reccommended for most users and would be equivilant to the following browserslist.
+The ``defaults`` option is recommended for most users and would be equivalent
+to the following browserslist:
 
 .. code-block:: diff
 

mailer.rst

@@ -338,9 +338,6 @@ Use the ``attachFromPath()`` method to attach files that exist on your file syst
         ->attachFromPath('/path/to/documents/privacy.pdf', 'Privacy Policy')
         // optionally you can provide an explicit MIME type (otherwise it's guessed)
         ->attachFromPath('/path/to/documents/contract.doc', 'Contract', 'application/msword')
-        // you can also use an absolute URL if your PHP config allows getting URLs using fopen()
-        // (this is not recommended because your application may or may not work depending on PHP config)
-        ->attachFromPath('http://example.com/path/to/documents/contract.doc', 'Contract', 'application/msword')
     ;
 
 Alternatively you can use the ``attach()`` method to attach contents from a stream::

service_container/calls.rst

@@ -40,7 +40,7 @@ To configure the container to call the ``setLogger`` method, use the ``calls`` k
             App\Service\MessageGenerator:
                 # ...
                 calls:
-                    - [setLogger, ['@logger']]
+                    - setLogger: ['@logger']
 
     .. code-block:: xml
 

service_container/injection_types.rst

@@ -146,7 +146,7 @@ In order to use this type of injection, don't forget to configure it:
             app.newsletter_manager:
                 class: App\Mail\NewsletterManager
                 calls:
-                    - [withMailer, ['@mailer'], true]
+                    - withMailer: !returns_clone ['@mailer']
 
     .. code-block:: xml
 
@@ -240,7 +240,7 @@ that accepts the dependency::
             app.newsletter_manager:
                 class: App\Mail\NewsletterManager
                 calls:
-                    - [setMailer, ['@mailer']]
+                    - setMailer: ['@mailer']
 
     .. code-block:: xml
 

service_container/optional_dependencies.rst

@@ -68,7 +68,7 @@ call if the service exists and remove the method call if it does not:
         services:
             App\Newsletter\NewsletterManager:
                 calls:
-                    - [setLogger, ['@?logger']]
+                    - setLogger: ['@?logger']
 
     .. code-block:: xml
 

service_container/parent_services.rst

@@ -72,7 +72,7 @@ duplicated service definitions:
                 abstract:  true
                 arguments: ['@doctrine.orm.entity_manager']
                 calls:
-                    - [setLogger, ['@logger']]
+                    - setLogger: ['@logger']
 
             App\Repository\DoctrineUserRepository:
                 # extend the App\Repository\BaseDoctrineRepository service

session/database.rst

@@ -30,15 +30,13 @@ First, define a Symfony service for the connection to the Redis server:
                 # you can also use \RedisArray, \RedisCluster or \Predis\Client classes
                 class: Redis
                 calls:
-                    - method: connect
-                      arguments:
-                          - '%env(REDIS_HOST)%'
-                          - '%env(int:REDIS_PORT)%'
+                    - connect:
+                        - '%env(REDIS_HOST)%'
+                        - '%env(int:REDIS_PORT)%'
 
                     # uncomment the following if your Redis server requires a password
-                    # - method: auth
-                    #   arguments:
-                    #       - '%env(REDIS_PASSWORD)%'
+                    # - auth:
+                    #     - '%env(REDIS_PASSWORD)%'
 
     .. code-block:: xml