minor #7119 Call isSubmitted() before calling isValid() (yceruto)

This PR was squashed before being merged into the 2.7 branch (closes #7119).

Discussion
----------

Call isSubmitted() before calling isValid()

Forward-compatibility fix

Commits
-------

995e2d9 Call isSubmitted() before calling isValid()

Author: wouterj

components/form.rst

@@ -547,7 +547,7 @@ method:
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             $data = $form->getData();
 
             // ... perform some action, such as saving the data to the database
@@ -573,7 +573,7 @@ method:
 
             $form->handleRequest($request);
 
-            if ($form->isValid()) {
+            if ($form->isSubmitted() && $form->isValid()) {
                 $data = $form->getData();
 
                 // ... perform some action, such as saving the data to the database

controller.rst

@@ -391,7 +391,7 @@ For example, imagine you're processing a :doc:`form </forms>` submission::
     {
         // ...
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             // do some sort of processing
 
             $this->addFlash(

controller/upload_file.rst

@@ -297,7 +297,7 @@ Now you're ready to use this service in the controller::
     {
         // ...
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             $file = $product->getBrochure();
             $fileName = $this->get('app.brochure_uploader')->upload($file);
 

form/direct_submit.rst

@@ -22,7 +22,7 @@ submissions::
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             // perform some action...
 
             return $this->redirectToRoute('task_success');
@@ -63,7 +63,7 @@ method, pass the submitted data directly to
         if ($request->isMethod('POST')) {
             $form->submit($request->request->get($form->getName()));
 
-            if ($form->isValid()) {
+            if ($form->isSubmitted() && $form->isValid()) {
                 // perform some action...
 
                 return $this->redirectToRoute('task_success');
@@ -115,7 +115,7 @@ a convenient shortcut to the previous example::
         if ($request->isMethod('POST')) {
             $form->submit($request);
 
-            if ($form->isValid()) {
+            if ($form->isSubmitted() && $form->isValid()) {
                 // perform some action...
 
                 return $this->redirectToRoute('task_success');

form/dynamic_form_modification.rst

@@ -605,7 +605,7 @@ your application. Assume that you have a sport meetup creation controller::
             $meetup = new SportMeetup();
             $form = $this->createForm(new SportMeetupType(), $meetup);
             $form->handleRequest($request);
-            if ($form->isValid()) {
+            if ($form->isSubmitted() && $form->isValid()) {
                 // ... save the meetup, redirect etc.
             }
 

form/form_collections.rst

@@ -178,7 +178,7 @@ In your controller, you'll now initialize a new instance of ``TaskType``::
 
             $form->handleRequest($request);
 
-            if ($form->isValid()) {
+            if ($form->isSubmitted() && $form->isValid()) {
                 // ... maybe do some form processing, like saving the Task and Tag objects
             }
 

form/multiple_buttons.rst

@@ -22,7 +22,7 @@ In your controller, use the button's
 :method:`Symfony\\Component\\Form\\ClickableInterface::isClicked` method for
 querying if the "Save and add" button was clicked::
 
-    if ($form->isValid()) {
+    if ($form->isSubmitted() && $form->isValid()) {
         // ... perform some action, such as saving the task to the database
 
         $nextAction = $form->get('saveAndAdd')->isClicked()

form/without_class.rst

@@ -27,7 +27,7 @@ an array of the submitted data. This is actually really easy::
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             // data is an array with "name", "email", and "message" keys
             $data = $form->getData();
         }

reference/forms/types/file.rst

@@ -47,7 +47,7 @@ be used to move the ``attachment`` file to a permanent location::
     {
         // ...
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             $someNewFilename = ...
 
             $form['attachment']->getData()->move($dir, $someNewFilename);

security/acl.rst

@@ -132,7 +132,7 @@ Creating an ACL and Adding an ACE
 
             // ... setup $form, and submit data
 
-            if ($form->isValid()) {
+            if ($form->isSubmitted() && $form->isValid()) {
                 $entityManager = $this->getDoctrine()->getManager();
                 $entityManager->persist($comment);
                 $entityManager->flush();