Skip to content

Commit c9b66a1

Browse files
committed
feature #15131 [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http (WouterJ)
This PR was squashed before being merged into the 2.8 branch (closes #15131). Discussion ---------- [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http Description --- The `SimpleFormAuthenticatorInterface` and `SimplePreAuthenticatorInterface` rely on `Request`, which means it's a Http land class. This means they don't belong in core. Having a form login that doesn't depend on the request is an option as well (e.g. a console application might use the question helper to implement a "form" login). However, then there is a need for a new abstraction of the request. I don't think it's worth it. Furthermore, the only classes typehinting/relying on this interfaces can be found in `Security\Http`. Implementation --- The new interfaces extend the old ones for better backwards compability. Symfony doesn't trigger deprecation errors for interfaces, see symfony/symfony@6f57b7b PR Info Table --- | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- ebb2064 [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http
2 parents 317c0b7 + 167685b commit c9b66a1

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Authentication/SimpleFormAuthenticatorInterface.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
use Symfony\Component\HttpFoundation\Request;
1515

1616
/**
17+
* @deprecated Deprecated since version 2.8, to be removed in 3.0. Use the same interface from Security\Http\Authentication instead.
18+
*
1719
* @author Jordi Boggiano <j.boggiano@seld.be>
1820
*/
1921
interface SimpleFormAuthenticatorInterface extends SimpleAuthenticatorInterface

Authentication/SimplePreAuthenticatorInterface.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
use Symfony\Component\HttpFoundation\Request;
1515

1616
/**
17+
* @deprecated Since version 2.8, to be removed in 3.0. Use the same interface from Security\Http\Authentication instead.
18+
*
1719
* @author Jordi Boggiano <j.boggiano@seld.be>
1820
*/
1921
interface SimplePreAuthenticatorInterface extends SimpleAuthenticatorInterface

0 commit comments

Comments
 (0)