Merge branch '4.4' into 5.0

nicolas-grekas · nicolas-grekas · commit 85009c888dcd · 2019-11-21T08:02:40.000+01:00
* 4.4: [Routing] fix tests [Form] group constraints when calling the validator Remove wrong @group legacy annotations [DependencyInjection] Fix dumping multiple deprecated aliases allow button names to start with uppercase letter States that the HttpClient provides a Http Async implementation
diff --git a/Tests/Authentication/Provider/DaoAuthenticationProviderTest.php b/Tests/Authentication/Provider/DaoAuthenticationProviderTest.php
@@ -23,9 +23,6 @@
 
 class DaoAuthenticationProviderTest extends TestCase
 {
-    /**
-     * @group legacy
-     */
     public function testRetrieveUserWhenProviderDoesNotReturnAnUserInterface()
     {
         $this->expectException('Symfony\Component\Security\Core\Exception\AuthenticationServiceException');
diff --git a/Tests/Authentication/Provider/UserAuthenticationProviderTest.php b/Tests/Authentication/Provider/UserAuthenticationProviderTest.php
@@ -61,9 +61,6 @@ public function testAuthenticateWhenUsernameIsNotFoundAndHideIsTrue()
         $provider->authenticate($this->getSupportedToken());
     }
 
-    /**
-     * @group legacy
-     */
     public function testAuthenticateWhenProviderDoesNotReturnAnUserInterface()
     {
         $this->expectException('Symfony\Component\Security\Core\Exception\AuthenticationServiceException');

Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,6 @@`
`23`	`23`
`24`	`24`	`class DaoAuthenticationProviderTest extends TestCase`
`25`	`25`	`{`
`26`		`- /**`
`27`		`- * @group legacy`
`28`		`- */`
`29`	`26`	`public function testRetrieveUserWhenProviderDoesNotReturnAnUserInterface()`
`30`	`27`	`{`
`31`	`28`	`$this->expectException('Symfony\Component\Security\Core\Exception\AuthenticationServiceException');`
Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,6 @@ public function testAuthenticateWhenUsernameIsNotFoundAndHideIsTrue()`
`61`	`61`	`$provider->authenticate($this->getSupportedToken());`
`62`	`62`	`}`
`63`	`63`
`64`		`- /**`
`65`		`- * @group legacy`
`66`		`- */`
`67`	`64`	`public function testAuthenticateWhenProviderDoesNotReturnAnUserInterface()`
`68`	`65`	`{`
`69`	`66`	`$this->expectException('Symfony\Component\Security\Core\Exception\AuthenticationServiceException');`