CS: Pre incrementation/decrementation should be used if possible

Author: gharlan

Encoder/MessageDigestPasswordEncoder.php

@@ -55,7 +55,7 @@ public function encodePassword($raw, $salt)
         $digest = hash($this->algorithm, $salted, true);
 
         // "stretch" hash
-        for ($i = 1; $i < $this->iterations; $i++) {
+        for ($i = 1; $i < $this->iterations; ++$i) {
             $digest = hash($this->algorithm, $digest.$salted, true);
         }
 

Encoder/Pbkdf2PasswordEncoder.php

@@ -87,11 +87,11 @@ private function hashPbkdf2($algorithm, $password, $salt, $iterations, $length =
         $blocks = ceil($length / strlen(hash($algorithm, null, true)));
         $digest = '';
 
-        for ($i = 1; $i <= $blocks; $i++) {
+        for ($i = 1; $i <= $blocks; ++$i) {
             $ib = $block = hash_hmac($algorithm, $salt.pack('N', $i), $password, true);
 
             // Iterations
-            for ($j = 1; $j < $iterations; $j++) {
+            for ($j = 1; $j < $iterations; ++$j) {
                 $ib ^= ($block = hash_hmac($algorithm, $block, $password, true));
             }
 

Util/StringUtils.php

@@ -60,7 +60,7 @@ public static function equals($knownString, $userInput)
 
         $result = 0;
 
-        for ($i = 0; $i < $knownLen; $i++) {
+        for ($i = 0; $i < $knownLen; ++$i) {
             $result |= (ord($knownString[$i]) ^ ord($userInput[$i]));
         }