Migrate to static data providers using rector/rector

Author: OskarStark

Tests/DependencyInjection/Compiler/RegisterGlobalSecurityEventListenersPassTest.php

@@ -70,7 +70,7 @@ public function testEventIsPropagated(string $configuredEvent, string $registere
         ]);
     }
 
-    public function providePropagatedEvents(): array
+    public static function providePropagatedEvents(): array
     {
         return [
             [CheckPassportEvent::class, CheckPassportEvent::class],

Tests/DependencyInjection/Security/Factory/AbstractFactoryTest.php

@@ -86,7 +86,7 @@ public function testDefaultFailureHandler($serviceId, $defaultHandlerInjection)
         }
     }
 
-    public function getFailureHandlers()
+    public static function getFailureHandlers()
     {
         return [
             [null, true],
@@ -135,7 +135,7 @@ public function testDefaultSuccessHandler($serviceId, $defaultHandlerInjection)
         }
     }
 
-    public function getSuccessHandlers()
+    public static function getSuccessHandlers()
     {
         return [
             [null, true],

Tests/DependencyInjection/Security/Factory/GuardAuthenticationFactoryTest.php

@@ -54,7 +54,7 @@ public function testAddInvalidConfiguration(array $inputConfig)
         $node->finalize($normalizedConfig);
     }
 
-    public function getValidConfigurationTests()
+    public static function getValidConfigurationTests()
     {
         $tests = [];
 
@@ -86,7 +86,7 @@ public function getValidConfigurationTests()
         return $tests;
     }
 
-    public function getInvalidConfigurationTests()
+    public static function getInvalidConfigurationTests()
     {
         $tests = [];
 

Tests/DependencyInjection/SecurityExtensionTest.php

@@ -525,7 +525,7 @@ public function testSecretRememberMeHandler()
         $this->assertSame('very', $handler->getArgument(1));
     }
 
-    public function sessionConfigurationProvider()
+    public static function sessionConfigurationProvider()
     {
         return [
             [
@@ -546,7 +546,7 @@ public function sessionConfigurationProvider()
         ];
     }
 
-    public function acceptableIpsProvider(): iterable
+    public static function acceptableIpsProvider(): iterable
     {
         yield [['127.0.0.1']];
         yield ['127.0.0.1'];
@@ -657,7 +657,7 @@ public function testAuthenticatorManagerEnabledEntryPoint(array $firewall, $entr
         $this->assertEquals($entryPointId, (string) $container->getDefinition('security.exception_listener.main')->getArgument(4));
     }
 
-    public function provideEntryPointFirewalls()
+    public static function provideEntryPointFirewalls()
     {
         // only one entry point available
         yield [['http_basic' => true], 'security.authenticator.http_basic.main'];
@@ -697,7 +697,7 @@ public function testEntryPointRequired(array $firewall, $messageRegex)
         $container->compile();
     }
 
-    public function provideEntryPointRequiredData()
+    public static function provideEntryPointRequiredData()
     {
         // more than one entry point available and not explicitly set
         yield [
@@ -747,7 +747,7 @@ public function testConfigureCustomAuthenticator(array $firewall, array $expecte
         $this->assertEquals($expectedAuthenticators, array_map('strval', $container->getDefinition('security.authenticator.manager.main')->getArgument(0)));
     }
 
-    public function provideConfigureCustomAuthenticatorData()
+    public static function provideConfigureCustomAuthenticatorData()
     {
         yield [
             ['custom_authenticator' => TestAuthenticator::class],
@@ -827,7 +827,7 @@ public function testUserCheckerWithAuthenticatorManager(array $config, string $e
         $this->assertEquals($expectedUserCheckerClass, $container->findDefinition($userCheckerId)->getClass());
     }
 
-    public function provideUserCheckerConfig()
+    public static function provideUserCheckerConfig()
     {
         yield [[], InMemoryUserChecker::class];
         yield [['user_checker' => TestUserChecker::class], TestUserChecker::class];

Tests/Functional/AuthenticatorTest.php

@@ -60,7 +60,7 @@ public function testWithoutUserProvider($email)
         $this->assertJsonStringEqualsJsonString('{"email":"'.$email.'"}', $client->getResponse()->getContent());
     }
 
-    public function provideEmails()
+    public static function provideEmails()
     {
         yield ['jane@example.org', true];
         yield ['john@example.org', false];
@@ -84,7 +84,7 @@ public function testLoginUsersWithMultipleFirewalls(string $username, string $fi
         $this->assertEquals('Welcome '.$username.'!', $client->getResponse()->getContent());
     }
 
-    public function provideEmailsWithFirewalls()
+    public static function provideEmailsWithFirewalls()
     {
         yield ['jane@example.org', 'main'];
         yield ['john@example.org', 'custom'];

Tests/Functional/CsrfFormLoginTest.php

@@ -213,13 +213,13 @@ public function testLegacyFormLoginRedirectsToProtectedResourceAfterLogin($optio
         $this->assertStringContainsString('You\'re browsing to path "/protected-resource".', $text);
     }
 
-    public function provideClientOptions()
+    public static function provideClientOptions()
     {
         yield [['test_case' => 'CsrfFormLogin', 'root_config' => 'config.yml', 'enable_authenticator_manager' => true]];
         yield [['test_case' => 'CsrfFormLogin', 'root_config' => 'routes_as_path.yml', 'enable_authenticator_manager' => true]];
     }
 
-    public function provideLegacyClientOptions()
+    public static function provideLegacyClientOptions()
     {
         yield [['test_case' => 'CsrfFormLogin', 'root_config' => 'legacy_config.yml', 'enable_authenticator_manager' => false]];
         yield [['test_case' => 'CsrfFormLogin', 'root_config' => 'legacy_routes_as_path.yml', 'enable_authenticator_manager' => false]];

Tests/Functional/FormLoginTest.php

@@ -296,13 +296,13 @@ public function testLegacyLoginThrottling()
         }
     }
 
-    public function provideClientOptions()
+    public static function provideClientOptions()
     {
         yield [['test_case' => 'StandardFormLogin', 'root_config' => 'base_config.yml', 'enable_authenticator_manager' => true]];
         yield [['test_case' => 'StandardFormLogin', 'root_config' => 'routes_as_path.yml', 'enable_authenticator_manager' => true]];
     }
 
-    public function provideLegacyClientOptions()
+    public static function provideLegacyClientOptions()
     {
         yield [['test_case' => 'StandardFormLogin', 'root_config' => 'legacy_config.yml', 'enable_authenticator_manager' => false]];
         yield [['test_case' => 'StandardFormLogin', 'root_config' => 'legacy_routes_as_path.yml', 'enable_authenticator_manager' => false]];

Tests/Functional/LocalizedRoutesAsPathTest.php

@@ -137,13 +137,13 @@ public function testLegacyAccessRestrictedResourceWithForward($locale, array $op
         $this->assertCount(1, $crawler->selectButton('login'), (string) $client->getResponse());
     }
 
-    public function getLocalesAndClientConfig()
+    public static function getLocalesAndClientConfig()
     {
         yield ['en', ['root_config' => 'localized_routes.yml']];
         yield ['de', ['root_config' => 'localized_routes.yml']];
     }
 
-    public function getLegacyLocalesAndClientConfig()
+    public static function getLegacyLocalesAndClientConfig()
     {
         yield ['en', ['root_config' => 'legacy_localized_routes.yml']];
         yield ['de', ['root_config' => 'legacy_localized_routes.yml']];

Tests/Functional/RememberMeCookieTest.php

@@ -50,7 +50,7 @@ public function testLegacySessionRememberMeSecureCookieFlagAuto($https, $expecte
         $this->assertSame($expectedSecureFlag, $cookies['']['/']['REMEMBERME']->isSecure());
     }
 
-    public function getSessionRememberMeSecureCookieFlagAutoHttpsMap()
+    public static function getSessionRememberMeSecureCookieFlagAutoHttpsMap()
     {
         return [
             [true, true],

Tests/Functional/RememberMeTest.php

@@ -174,13 +174,13 @@ public function testLegacySessionLessRememberMeLogout()
         $this->assertNull($cookieJar->get('REMEMBERME'));
     }
 
-    public function provideConfigs()
+    public static function provideConfigs()
     {
         yield [['root_config' => 'config_session.yml']];
         yield [['root_config' => 'config_persistent.yml']];
     }
 
-    public function provideLegacyConfigs()
+    public static function provideLegacyConfigs()
     {
         yield [['root_config' => 'legacy_config_session.yml']];
         yield [['root_config' => 'legacy_config_persistent.yml']];