Add "shared" flag and deprecate scopes concept

Author: dosten

Tests/Functional/Bundle/CsrfFormLoginBundle/Form/UserLoginFormType.php

@@ -16,7 +16,7 @@
 use Symfony\Component\Form\FormError;
 use Symfony\Component\Form\FormEvents;
 use Symfony\Component\Form\FormEvent;
-use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Security\Core\Security;
 
@@ -29,14 +29,14 @@
  */
 class UserLoginFormType extends AbstractType
 {
-    private $request;
+    private $requestStack;
 
     /**
-     * @param Request $request A request instance
+     * @param RequestStack $requestStack A RequestStack instance
      */
-    public function __construct(Request $request)
+    public function __construct(RequestStack $requestStack)
     {
-        $this->request = $request;
+        $this->requestStack = $requestStack;
     }
 
     /**
@@ -50,7 +50,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
             ->add('_target_path', 'hidden')
         ;
 
-        $request = $this->request;
+        $request = $this->requestStack->getCurrentRequest();
 
         /* Note: since the Security component's form login listener intercepts
          * the POST request, this form will never really be bound to the

Tests/Functional/app/CsrfFormLogin/config.yml

@@ -4,9 +4,8 @@ imports:
 services:
     csrf_form_login.form.type:
         class: Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\CsrfFormLoginBundle\Form\UserLoginFormType
-        scope: request
         arguments:
-            - @request
+            - @request_stack
         tags:
             - { name: form.type, alias: user_login }
 

composer.json

@@ -29,7 +29,7 @@
         "symfony/dom-crawler": "~2.0,>=2.0.5|~3.0.0",
         "symfony/form": "~2.7|~3.0.0",
         "symfony/framework-bundle": "~2.7|~3.0.0",
-        "symfony/http-foundation": "~2.3|~3.0.0",
+        "symfony/http-foundation": "~2.4|~3.0.0",
         "symfony/twig-bundle": "~2.7|~3.0.0",
         "symfony/twig-bridge": "~2.7|~3.0.0",
         "symfony/process": "~2.0,>=2.0.5|~3.0.0",