[Form] Deprecated FormTypeInterface::getName() and passing of type instances

Author: webmozart

Tests/Functional/Bundle/CsrfFormLoginBundle/Controller/LoginController.php

@@ -19,7 +19,7 @@ class LoginController extends ContainerAware
 {
     public function loginAction()
     {
-        $form = $this->container->get('form.factory')->create('user_login');
+        $form = $this->container->get('form.factory')->create('Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\CsrfFormLoginBundle\Form\UserLoginType');
 
         return $this->container->get('templating')->renderResponse('CsrfFormLoginBundle:Login:login.html.twig', array(
             'form' => $form->createView(),

Tests/Functional/Bundle/CsrfFormLoginBundle/Form/UserLoginFormType.php renamed to Tests/Functional/Bundle/CsrfFormLoginBundle/Form/UserLoginType.php

@@ -27,7 +27,7 @@
  * @author Henrik Bjornskov <henrik@bjrnskov.dk>
  * @author Jeremy Mikola <jmikola@gmail.com>
  */
-class UserLoginFormType extends AbstractType
+class UserLoginType extends AbstractType
 {
     private $requestStack;
 
@@ -45,9 +45,9 @@ public function __construct(RequestStack $requestStack)
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder
-            ->add('username', 'text')
-            ->add('password', 'password')
-            ->add('_target_path', 'hidden')
+            ->add('username', 'Symfony\Component\Form\Extension\Core\Type\TextType')
+            ->add('password', 'Symfony\Component\Form\Extension\Core\Type\PasswordType')
+            ->add('_target_path', 'Symfony\Component\Form\Extension\Core\Type\HiddenType')
         ;
 
         $request = $this->requestStack->getCurrentRequest();
@@ -87,12 +87,4 @@ public function configureOptions(OptionsResolver $resolver)
             'intention' => 'authenticate',
         ));
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getName()
-    {
-        return 'user_login';
-    }
 }

Tests/Functional/app/CsrfFormLogin/config.yml

@@ -3,11 +3,11 @@ imports:
 
 services:
     csrf_form_login.form.type:
-        class: Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\CsrfFormLoginBundle\Form\UserLoginFormType
+        class: Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\CsrfFormLoginBundle\Form\UserLoginType
         arguments:
             - @request_stack
         tags:
-            - { name: form.type, alias: user_login }
+            - { name: form.type }
 
 security:
     encoders: